fs/fat: Remove unnecessary wrapper fat_max_cache()

[PATCH] fs/fat: Remove unnecessary wrapper fat_max_cache()

Posted by Lalit Shankar Chowdhury 4 days, 3 hours ago

fat_max_cache() always returned FAT_MAX_CACHE and did not use the inode
parameter. So, use the FAT_MAX_CACHE constant directly.

Signed-off-by: Lalit Shankar Chowdhury <lalitshankarch@gmail.com>
---
 fs/fat/cache.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/fs/fat/cache.c b/fs/fat/cache.c
index 2af424e200b3..630f3056658e 100644
--- a/fs/fat/cache.c
+++ b/fs/fat/cache.c
@@ -29,11 +29,6 @@ struct fat_cache_id {
 	int dcluster;
 };
 
-static inline int fat_max_cache(struct inode *inode)
-{
-	return FAT_MAX_CACHE;
-}
-
 static struct kmem_cache *fat_cache_cachep;
 
 static void init_once(void *foo)
@@ -145,7 +140,7 @@ static void fat_cache_add(struct inode *inode, struct fat_cache_id *new)
 
 	cache = fat_cache_merge(inode, new);
 	if (cache == NULL) {
-		if (MSDOS_I(inode)->nr_caches < fat_max_cache(inode)) {
+		if (MSDOS_I(inode)->nr_caches < FAT_MAX_CACHE) {
 			MSDOS_I(inode)->nr_caches++;
 			spin_unlock(&MSDOS_I(inode)->cache_lru_lock);
 
-- 
2.43.0

Re: [PATCH] fs/fat: Remove unnecessary wrapper fat_max_cache()

Posted by OGAWA Hirofumi 3 days, 17 hours ago

Lalit Shankar Chowdhury <lalitshankarch@gmail.com> writes:

> fat_max_cache() always returned FAT_MAX_CACHE and did not use the inode
> parameter. So, use the FAT_MAX_CACHE constant directly.
>
> Signed-off-by: Lalit Shankar Chowdhury <lalitshankarch@gmail.com>

Looks good.

Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

> ---
>  fs/fat/cache.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/fs/fat/cache.c b/fs/fat/cache.c
> index 2af424e200b3..630f3056658e 100644
> --- a/fs/fat/cache.c
> +++ b/fs/fat/cache.c
> @@ -29,11 +29,6 @@ struct fat_cache_id {
>  	int dcluster;
>  };
>  
> -static inline int fat_max_cache(struct inode *inode)
> -{
> -	return FAT_MAX_CACHE;
> -}
> -
>  static struct kmem_cache *fat_cache_cachep;
>  
>  static void init_once(void *foo)
> @@ -145,7 +140,7 @@ static void fat_cache_add(struct inode *inode, struct fat_cache_id *new)
>  
>  	cache = fat_cache_merge(inode, new);
>  	if (cache == NULL) {
> -		if (MSDOS_I(inode)->nr_caches < fat_max_cache(inode)) {
> +		if (MSDOS_I(inode)->nr_caches < FAT_MAX_CACHE) {
>  			MSDOS_I(inode)->nr_caches++;
>  			spin_unlock(&MSDOS_I(inode)->cache_lru_lock);

-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>