[PATCH 2/2] mcb: Remove MODULE_ALIAS from all mcb client drivers

Jose Javier Rodriguez Barbarin posted 2 patches 4 days, 5 hours ago
There is a newer version of this series
[PATCH 2/2] mcb: Remove MODULE_ALIAS from all mcb client drivers
Posted by Jose Javier Rodriguez Barbarin 4 days, 5 hours ago
MODULE_ALIAS information is no longer needed as now all mcb client
drivers are reporting such information through MODULE_DEVICE_TABLE.

Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>
Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
---
 drivers/gpio/gpio-menz127.c            | 1 -
 drivers/iio/adc/men_z188_adc.c         | 1 -
 drivers/tty/serial/8250/8250_men_mcb.c | 3 ---
 drivers/tty/serial/men_z135_uart.c     | 1 -
 drivers/watchdog/menz69_wdt.c          | 1 -
 5 files changed, 7 deletions(-)

diff --git a/drivers/gpio/gpio-menz127.c b/drivers/gpio/gpio-menz127.c
index 52b13c6ae496..f51e7517f551 100644
--- a/drivers/gpio/gpio-menz127.c
+++ b/drivers/gpio/gpio-menz127.c
@@ -223,5 +223,4 @@ module_mcb_driver(men_z127_driver);
 MODULE_AUTHOR("Andreas Werner <andreas.werner@men.de>");
 MODULE_DESCRIPTION("MEN GPIO Controller");
 MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("mcb:16z127");
 MODULE_IMPORT_NS("MCB");
diff --git a/drivers/iio/adc/men_z188_adc.c b/drivers/iio/adc/men_z188_adc.c
index cf8a8c0412ec..90919d282e7b 100644
--- a/drivers/iio/adc/men_z188_adc.c
+++ b/drivers/iio/adc/men_z188_adc.c
@@ -171,5 +171,4 @@ module_mcb_driver(men_z188_driver);
 MODULE_AUTHOR("Johannes Thumshirn <johannes.thumshirn@men.de>");
 MODULE_LICENSE("GPL");
 MODULE_DESCRIPTION("IIO ADC driver for MEN 16z188 ADC Core");
-MODULE_ALIAS("mcb:16z188");
 MODULE_IMPORT_NS("MCB");
diff --git a/drivers/tty/serial/8250/8250_men_mcb.c b/drivers/tty/serial/8250/8250_men_mcb.c
index a78ef35c8187..9774a95f2980 100644
--- a/drivers/tty/serial/8250/8250_men_mcb.c
+++ b/drivers/tty/serial/8250/8250_men_mcb.c
@@ -268,7 +268,4 @@ module_mcb_driver(mcb_driver);
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("MEN 8250 UART driver");
 MODULE_AUTHOR("Michael Moese <michael.moese@men.de");
-MODULE_ALIAS("mcb:16z125");
-MODULE_ALIAS("mcb:16z025");
-MODULE_ALIAS("mcb:16z057");
 MODULE_IMPORT_NS("MCB");
diff --git a/drivers/tty/serial/men_z135_uart.c b/drivers/tty/serial/men_z135_uart.c
index 9cc15449b673..6fad57fee912 100644
--- a/drivers/tty/serial/men_z135_uart.c
+++ b/drivers/tty/serial/men_z135_uart.c
@@ -919,5 +919,4 @@ module_exit(men_z135_exit);
 MODULE_AUTHOR("Johannes Thumshirn <johannes.thumshirn@men.de>");
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("MEN 16z135 High Speed UART");
-MODULE_ALIAS("mcb:16z135");
 MODULE_IMPORT_NS("MCB");
diff --git a/drivers/watchdog/menz69_wdt.c b/drivers/watchdog/menz69_wdt.c
index 6e5e4e5c0b56..3fe23451135d 100644
--- a/drivers/watchdog/menz69_wdt.c
+++ b/drivers/watchdog/menz69_wdt.c
@@ -163,5 +163,4 @@ module_mcb_driver(men_z069_driver);
 MODULE_AUTHOR("Johannes Thumshirn <jth@kernel.org>");
 MODULE_DESCRIPTION("Watchdog driver for the MEN z069 IP-Core");
 MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("mcb:16z069");
 MODULE_IMPORT_NS("MCB");
-- 
2.51.1
Re: [PATCH 2/2] mcb: Remove MODULE_ALIAS from all mcb client drivers
Posted by Andy Shevchenko 4 days, 5 hours ago
On Thu, Nov 27, 2025 at 5:56 PM Jose Javier Rodriguez Barbarin
<dev-josejavier.rodriguez@duagon.com> wrote:
>
> MODULE_ALIAS information is no longer needed as now all mcb client
> drivers are reporting such information through MODULE_DEVICE_TABLE.

While this is not a big change, I still would recommend to split on
per-driver basis, and with pushing the first one as kinda a fix after
v6.19-rc1 (to v6.19-rcX) allows other maintainers to apply the rest on
driver-basis. This helps everybody I assume.


-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH 2/2] mcb: Remove MODULE_ALIAS from all mcb client drivers
Posted by Jose Javier Rodriguez Barbarin 3 days, 10 hours ago
On Thu, Nov 27, 2025 at 06:12:29PM +0200, Andy Shevchenko wrote:
> On Thu, Nov 27, 2025 at 5:56 PM Jose Javier Rodriguez Barbarin
> <dev-josejavier.rodriguez@duagon.com> wrote:
> >
> > MODULE_ALIAS information is no longer needed as now all mcb client
> > drivers are reporting such information through MODULE_DEVICE_TABLE.
> 
> While this is not a big change, I still would recommend to split on
> per-driver basis, and with pushing the first one as kinda a fix after
> v6.19-rc1 (to v6.19-rcX) allows other maintainers to apply the rest on
> driver-basis. This helps everybody I assume.
> 

Understood. This was my first patch that touches more than one subsystem
and I was doubting to send one unique patch or one patch per driver. 
Good to know that. 

Thank you so much.

> 
> -- 
> With Best Regards,
> Andy Shevchenko