drivers/gpio/gpio-menz127.c | 1 - drivers/iio/adc/men_z188_adc.c | 1 - drivers/tty/serial/8250/8250_men_mcb.c | 3 --- drivers/tty/serial/men_z135_uart.c | 1 - drivers/watchdog/menz69_wdt.c | 1 - scripts/mod/devicetable-offsets.c | 3 +++ scripts/mod/file2alias.c | 9 +++++++++ 7 files changed, 12 insertions(+), 7 deletions(-)
During the process of update of one of the device drivers that are part of mcb bus (gpio-menz127.c), one maintainer of the GPIO subsystem asked me why I was adding new MODULE_ALIAS when I also added the same new information on MODULE_DEVICE_TABLE. You can find the messages here: https://lore.kernel.org/linux-gpio/80a20b13-7c6a-4483-9741-568424f957ef@kernel.org/ After a deeper analysis, I came across that the mcb_table_id defined inside MODULE_DEVICE_TABLE on all device drivers was being ignored as modpost was not processing the mcb MODULE_DEVICE_TABLE entries. For this reason, former contributors were using MODULE_ALIAS for enabling mcb to autoload the device drivers. My proposal with these changes is to complete the mcb bus by adding modpost support for processing mcb MODULE_DEVICE_TABLE and removing MODULE_ALIAS from all device drivers as they are no longer needed. Jose Javier Rodriguez Barbarin (2): mcb: Add missing modpost build support mcb: Remove MODULE_ALIAS from all mcb client drivers drivers/gpio/gpio-menz127.c | 1 - drivers/iio/adc/men_z188_adc.c | 1 - drivers/tty/serial/8250/8250_men_mcb.c | 3 --- drivers/tty/serial/men_z135_uart.c | 1 - drivers/watchdog/menz69_wdt.c | 1 - scripts/mod/devicetable-offsets.c | 3 +++ scripts/mod/file2alias.c | 9 +++++++++ 7 files changed, 12 insertions(+), 7 deletions(-) -- 2.51.1
On Thu, Nov 27, 2025 at 5:56 PM Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com> wrote: > > During the process of update of one of the device drivers that are part of > mcb bus (gpio-menz127.c), > one maintainer of the GPIO subsystem Krzysztof? Did I miss something and he is now a (co)maintainer here? > asked me > why I was adding new MODULE_ALIAS when I also added the same new > information on MODULE_DEVICE_TABLE. > > You can find the messages here: > > https://lore.kernel.org/linux-gpio/80a20b13-7c6a-4483-9741-568424f957ef@kernel.org/ > > After a deeper analysis, I came across that the mcb_table_id defined inside > MODULE_DEVICE_TABLE on all device drivers was being ignored as modpost was > not processing the mcb MODULE_DEVICE_TABLE entries. For this reason, former > contributors were using MODULE_ALIAS for enabling mcb to autoload the > device drivers. > > My proposal with these changes is to complete the mcb bus by adding > modpost support for processing mcb MODULE_DEVICE_TABLE and removing > MODULE_ALIAS from all device drivers as they are no longer needed. > > Jose Javier Rodriguez Barbarin (2): > mcb: Add missing modpost build support > mcb: Remove MODULE_ALIAS from all mcb client drivers > > drivers/gpio/gpio-menz127.c | 1 - > drivers/iio/adc/men_z188_adc.c | 1 - > drivers/tty/serial/8250/8250_men_mcb.c | 3 --- > drivers/tty/serial/men_z135_uart.c | 1 - > drivers/watchdog/menz69_wdt.c | 1 - > scripts/mod/devicetable-offsets.c | 3 +++ > scripts/mod/file2alias.c | 9 +++++++++ > 7 files changed, 12 insertions(+), 7 deletions(-) > > -- > 2.51.1 -- With Best Regards, Andy Shevchenko
On Thu, Nov 27, 2025 at 06:16:03PM +0200, Andy Shevchenko wrote: > On Thu, Nov 27, 2025 at 5:56 PM Jose Javier Rodriguez Barbarin > <dev-josejavier.rodriguez@duagon.com> wrote: > > > > During the process of update of one of the device drivers that are part of > > mcb bus (gpio-menz127.c), > > > one maintainer of the GPIO subsystem > > Krzysztof? Did I miss something and he is now a (co)maintainer here? > I'm sorry, it's my fault, I confused the person who answered me the first time with one of the maintainers. Krzysztof and Linus both answered me. > > asked me > > why I was adding new MODULE_ALIAS when I also added the same new > > information on MODULE_DEVICE_TABLE. > > > > You can find the messages here: > > > > https://lore.kernel.org/linux-gpio/80a20b13-7c6a-4483-9741-568424f957ef@kernel.org/ > > > > After a deeper analysis, I came across that the mcb_table_id defined inside > > MODULE_DEVICE_TABLE on all device drivers was being ignored as modpost was > > not processing the mcb MODULE_DEVICE_TABLE entries. For this reason, former > > contributors were using MODULE_ALIAS for enabling mcb to autoload the > > device drivers. > > > > My proposal with these changes is to complete the mcb bus by adding > > modpost support for processing mcb MODULE_DEVICE_TABLE and removing > > MODULE_ALIAS from all device drivers as they are no longer needed. > > > > Jose Javier Rodriguez Barbarin (2): > > mcb: Add missing modpost build support > > mcb: Remove MODULE_ALIAS from all mcb client drivers > > > > drivers/gpio/gpio-menz127.c | 1 - > > drivers/iio/adc/men_z188_adc.c | 1 - > > drivers/tty/serial/8250/8250_men_mcb.c | 3 --- > > drivers/tty/serial/men_z135_uart.c | 1 - > > drivers/watchdog/menz69_wdt.c | 1 - > > scripts/mod/devicetable-offsets.c | 3 +++ > > scripts/mod/file2alias.c | 9 +++++++++ > > 7 files changed, 12 insertions(+), 7 deletions(-) > > > > -- > > 2.51.1 > > > > -- > With Best Regards, > Andy Shevchenko Thanks for you review, I will send a V2 following your suggestions. Regards, Javier Rodriguez.
© 2016 - 2025 Red Hat, Inc.