[PATCH 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add placeholders and sort

Robert Eckelmann via B4 Relay posted 2 patches 2 months, 1 week ago
There is a newer version of this series
[PATCH 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add placeholders and sort
Posted by Robert Eckelmann via B4 Relay 2 months, 1 week ago
From: Robert Eckelmann <longnoserob@gmail.com>

We know these devices are present, most of them are supported by
downstream and close to the mainline kernels.

This is very handy when rebasing the integration tree with the support.

No functional changes.

Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
---
 .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi   | 23 +++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
index 0fb1d7e724c4..0b219d0ff451 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
@@ -227,6 +227,10 @@ vreg_l26a_1p2: ldo26 {
 	};
 };
 
+&cci_i2c0 {
+	/* IMX363 @ 10 */
+};
+
 &cdsp_pas {
 	status = "okay";
 	firmware-name = "qcom/sdm845/beryllium/cdsp.mbn";
@@ -261,6 +265,18 @@ &ibb {
 	qcom,discharge-resistor-kohms = <300>;
 };
 
+&ipa {
+	qcom,gsi-loader = "self";
+	memory-region = <&ipa_fw_mem>;
+	firmware-name = "qcom/sdm845/beryllium/ipa_fws.mbn";
+
+	status = "okay";
+};
+
+&i2c5 {
+	/* TAS2559 @ 4C */
+};
+
 &lab {
 	regulator-min-microvolt = <4600000>;
 	regulator-max-microvolt = <6000000>;
@@ -311,13 +327,6 @@ &mss_pil {
 	firmware-name = "qcom/sdm845/beryllium/mba.mbn", "qcom/sdm845/beryllium/modem.mbn";
 };
 
-&ipa {
-	qcom,gsi-loader = "self";
-	memory-region = <&ipa_fw_mem>;
-	firmware-name = "qcom/sdm845/beryllium/ipa_fws.mbn";
-	status = "okay";
-};
-
 &pm8998_gpios {
 	vol_up_pin_a: vol-up-active-state {
 		pins = "gpio6";

-- 
2.52.0
Re: [PATCH 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add placeholders and sort
Posted by Konrad Dybcio 2 months, 1 week ago
On 11/26/25 1:08 PM, Robert Eckelmann via B4 Relay wrote:
> From: Robert Eckelmann <longnoserob@gmail.com>
> 
> We know these devices are present, most of them are supported by
> downstream and close to the mainline kernels.
> 
> This is very handy when rebasing the integration tree with the support.
> 
> No functional changes.
> 
> Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
> ---
>  .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi   | 23 +++++++++++++++-------
>  1 file changed, 16 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> index 0fb1d7e724c4..0b219d0ff451 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> @@ -227,6 +227,10 @@ vreg_l26a_1p2: ldo26 {
>  	};
>  };
>  
> +&cci_i2c0 {
> +	/* IMX363 @ 10 */

It may be useful for you to add 'status = "okay"' here, so that the busses
are accessible, and you can poke at the device with e.g. i2c-tools

Konrad
Re: [PATCH 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add placeholders and sort
Posted by Dmitry Baryshkov 2 months, 1 week ago
On Thu, Nov 27, 2025 at 11:33:40AM +0100, Konrad Dybcio wrote:
> On 11/26/25 1:08 PM, Robert Eckelmann via B4 Relay wrote:
> > From: Robert Eckelmann <longnoserob@gmail.com>
> > 
> > We know these devices are present, most of them are supported by
> > downstream and close to the mainline kernels.
> > 
> > This is very handy when rebasing the integration tree with the support.
> > 
> > No functional changes.
> > 
> > Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
> > ---
> >  .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi   | 23 +++++++++++++++-------
> >  1 file changed, 16 insertions(+), 7 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> > index 0fb1d7e724c4..0b219d0ff451 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> > @@ -227,6 +227,10 @@ vreg_l26a_1p2: ldo26 {
> >  	};
> >  };
> >  
> > +&cci_i2c0 {
> > +	/* IMX363 @ 10 */
> 
> It may be useful for you to add 'status = "okay"' here, so that the busses
> are accessible, and you can poke at the device with e.g. i2c-tools

And a bus frequency then.

> 
> Konrad

-- 
With best wishes
Dmitry
Re: [PATCH 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add placeholders and sort
Posted by David Heidelberg 2 months, 1 week ago
On 26/11/2025 13:08, Robert Eckelmann via B4 Relay wrote:
> From: Robert Eckelmann <longnoserob@gmail.com>
> 
> We know these devices are present, most of them are supported by
> downstream and close to the mainline kernels.
> 
> This is very handy when rebasing the integration tree with the support.
> 
> No functional changes.
> 
> Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
> ---
>   .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi   | 23 +++++++++++++++-------
>   1 file changed, 16 insertions(+), 7 deletions(-)
> 

Reviewed-by: David Heidelberg <david@ixit.cz>