1. Patchew
  2. linux
  3. [PATCH 0/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI
  4. View patch

[PATCH 1/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI

Robert Eckelmann via B4 Relay posted 2 patches 5 days, 10 hours ago
[PATCH 1/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI
Posted by Robert Eckelmann via B4 Relay 5 days, 10 hours ago 
From: Robert Eckelmann <longnoserob@gmail.com>

Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.

Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
index 785006a15e97..0fb1d7e724c4 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
@@ -425,6 +425,12 @@ &sdhc_2 {
 	cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>;
 };
 
+&slpi_pas {
+	firmware-name = "qcom/sdm845/beryllium/slpi.mbn";
+
+	status = "okay";
+};
+
 &sound {
 	compatible = "qcom,db845c-sndcard", "qcom,sdm845-sndcard";
 	pinctrl-0 = <&quat_mi2s_active
@@ -637,3 +643,4 @@ &wifi {
 	vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
 	vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
 };
+

-- 
2.52.0
Re: [PATCH 1/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI
Posted by Dmitry Baryshkov 5 days, 8 hours ago 
On Wed, Nov 26, 2025 at 09:08:35PM +0900, Robert Eckelmann via B4 Relay wrote:
> From: Robert Eckelmann <longnoserob@gmail.com>
> 
> Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.
> 
> Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> index 785006a15e97..0fb1d7e724c4 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> @@ -425,6 +425,12 @@ &sdhc_2 {
>  	cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>;
>  };
>  
> +&slpi_pas {
> +	firmware-name = "qcom/sdm845/beryllium/slpi.mbn";

qcom/sdm845/Xiaomi/beryllium/slpi.mbn

> +
> +	status = "okay";
> +};
> +
>  &sound {
>  	compatible = "qcom,db845c-sndcard", "qcom,sdm845-sndcard";
>  	pinctrl-0 = <&quat_mi2s_active
> @@ -637,3 +643,4 @@ &wifi {
>  	vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
>  	vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
>  };
> +
> 
> -- 
> 2.52.0
> 
> 

-- 
With best wishes
Dmitry
Re: [PATCH 1/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI
Posted by David Heidelberg 5 days, 7 hours ago 
On 26/11/2025 15:41, Dmitry Baryshkov wrote:
> On Wed, Nov 26, 2025 at 09:08:35PM +0900, Robert Eckelmann via B4 Relay wrote:
>> From: Robert Eckelmann <longnoserob@gmail.com>
>>
>> Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.
>>
>> Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>>   arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
>> index 785006a15e97..0fb1d7e724c4 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
>> @@ -425,6 +425,12 @@ &sdhc_2 {
>>   	cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>;
>>   };
>>   
>> +&slpi_pas {
>> +	firmware-name = "qcom/sdm845/beryllium/slpi.mbn";
> 
> qcom/sdm845/Xiaomi/beryllium/slpi.mbn

Could be this change done for all the firmware files at once but later?

Currently all the firmwares using this legacy path.

David

[...]
Re: [PATCH 1/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI
Posted by Dmitry Baryshkov 2 days, 21 hours ago 
On Wed, Nov 26, 2025 at 03:59:48PM +0100, David Heidelberg wrote:
> On 26/11/2025 15:41, Dmitry Baryshkov wrote:
> > On Wed, Nov 26, 2025 at 09:08:35PM +0900, Robert Eckelmann via B4 Relay wrote:
> > > From: Robert Eckelmann <longnoserob@gmail.com>
> > > 
> > > Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.
> > > 
> > > Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
> > > Signed-off-by: David Heidelberg <david@ixit.cz>
> > > ---
> > >   arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++
> > >   1 file changed, 7 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> > > index 785006a15e97..0fb1d7e724c4 100644
> > > --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> > > @@ -425,6 +425,12 @@ &sdhc_2 {
> > >   	cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>;
> > >   };
> > > +&slpi_pas {
> > > +	firmware-name = "qcom/sdm845/beryllium/slpi.mbn";
> > 
> > qcom/sdm845/Xiaomi/beryllium/slpi.mbn
> 
> Could be this change done for all the firmware files at once but later?
> 
> Currently all the firmwares using this legacy path.

I'd rather see the patch fixing firmware paths first and then the patch
adding SLPI with the correct path from the day 0 (I feel sorry for
causing pain to PmOS maintainers). Of course both patches can come as a
part of the same series.

> 
> David
> 
> [...]

-- 
With best wishes
Dmitry
Re: [PATCH 1/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI
Posted by David Heidelberg 2 days, 10 hours ago 
On 29/11/2025 02:15, Dmitry Baryshkov wrote:
> On Wed, Nov 26, 2025 at 03:59:48PM +0100, David Heidelberg wrote:
>> On 26/11/2025 15:41, Dmitry Baryshkov wrote:
>>> On Wed, Nov 26, 2025 at 09:08:35PM +0900, Robert Eckelmann via B4 Relay wrote:
>>>> From: Robert Eckelmann <longnoserob@gmail.com>
>>>>
>>>> Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.
>>>>
>>>> Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
>>>> Signed-off-by: David Heidelberg <david@ixit.cz>
>>>> ---
>>>>    arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++
>>>>    1 file changed, 7 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
>>>> index 785006a15e97..0fb1d7e724c4 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
>>>> @@ -425,6 +425,12 @@ &sdhc_2 {
>>>>    	cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>;
>>>>    };
>>>> +&slpi_pas {
>>>> +	firmware-name = "qcom/sdm845/beryllium/slpi.mbn";
>>>
>>> qcom/sdm845/Xiaomi/beryllium/slpi.mbn
>>
>> Could be this change done for all the firmware files at once but later?
>>
>> Currently all the firmwares using this legacy path.
> 
> I'd rather see the patch fixing firmware paths first and then the patch
> adding SLPI with the correct path from the day 0 (I feel sorry for
> causing pain to PmOS maintainers). Of course both patches can come as a
> part of the same series.

Would it make sense as a follow up, I would changed "the whole sdm845" 
to the new paths, so distros maintainers can update paths everywhere 
with 6.19?

David

> 
>>
>> David
>>
>> [...]
> 

-- 
David Heidelberg
Re: [PATCH 1/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI
Posted by Dmitry Baryshkov 2 days ago 
On Sat, 29 Nov 2025 at 14:08, David Heidelberg <david@ixit.cz> wrote:
>
> On 29/11/2025 02:15, Dmitry Baryshkov wrote:
> > On Wed, Nov 26, 2025 at 03:59:48PM +0100, David Heidelberg wrote:
> >> On 26/11/2025 15:41, Dmitry Baryshkov wrote:
> >>> On Wed, Nov 26, 2025 at 09:08:35PM +0900, Robert Eckelmann via B4 Relay wrote:
> >>>> From: Robert Eckelmann <longnoserob@gmail.com>
> >>>>
> >>>> Enable the SLPI dsp on the Xiaomi Pocophone F1 with Qualcom SDM845 SoC.
> >>>>
> >>>> Signed-off-by: Robert Eckelmann <longnoserob@gmail.com>
> >>>> Signed-off-by: David Heidelberg <david@ixit.cz>
> >>>> ---
> >>>>    arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 7 +++++++
> >>>>    1 file changed, 7 insertions(+)
> >>>>
> >>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> >>>> index 785006a15e97..0fb1d7e724c4 100644
> >>>> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> >>>> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> >>>> @@ -425,6 +425,12 @@ &sdhc_2 {
> >>>>            cd-gpios = <&tlmm 126 GPIO_ACTIVE_HIGH>;
> >>>>    };
> >>>> +&slpi_pas {
> >>>> +  firmware-name = "qcom/sdm845/beryllium/slpi.mbn";
> >>>
> >>> qcom/sdm845/Xiaomi/beryllium/slpi.mbn
> >>
> >> Could be this change done for all the firmware files at once but later?
> >>
> >> Currently all the firmwares using this legacy path.
> >
> > I'd rather see the patch fixing firmware paths first and then the patch
> > adding SLPI with the correct path from the day 0 (I feel sorry for
> > causing pain to PmOS maintainers). Of course both patches can come as a
> > part of the same series.
>
> Would it make sense as a follow up, I would changed "the whole sdm845"
> to the new paths, so distros maintainers can update paths everywhere
> with 6.19?

I think so.

>
> David
>
> >
> >>
> >> David
> >>
> >> [...]
> >
>
> --
> David Heidelberg
>


-- 
With best wishes
Dmitry

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.