dt-bindings: interrupt-controller: renesas,rzv2h-icu: Document RZ/V2N SoC support

[PATCH] dt-bindings: interrupt-controller: renesas,rzv2h-icu: Document RZ/V2N SoC support

Posted by Prabhakar 6 days, 1 hour ago

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Document the Interrupt Control Unit (ICU) on the Renesas RZ/V2N SoC,
which is architecturally identical to the ICU used on the RZ/V2H(P)
SoC.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 .../interrupt-controller/renesas,rzv2h-icu.yaml       | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzv2h-icu.yaml b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzv2h-icu.yaml
index 3f99c8645767..142aef5ec1f0 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzv2h-icu.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzv2h-icu.yaml
@@ -20,9 +20,14 @@ description:
 
 properties:
   compatible:
-    enum:
-      - renesas,r9a09g047-icu # RZ/G3E
-      - renesas,r9a09g057-icu # RZ/V2H(P)
+    oneOf:
+      - items:
+          - enum:
+              - renesas,r9a09g047-icu # RZ/G3E
+              - renesas,r9a09g057-icu # RZ/V2H(P)
+      - items:
+          - const: renesas,r9a09g056-icu # RZ/V2N
+          - const: renesas,r9a09g057-icu
 
   '#interrupt-cells':
     description: The first cell is the SPI number of the NMI or the
-- 
2.52.0

Re: [PATCH] dt-bindings: interrupt-controller: renesas,rzv2h-icu: Document RZ/V2N SoC support

Posted by Geert Uytterhoeven 5 days, 11 hours ago

Hi Prabhakar,

On Tue, 25 Nov 2025 at 22:32, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Document the Interrupt Control Unit (ICU) on the Renesas RZ/V2N SoC,
> which is architecturally identical to the ICU used on the RZ/V2H(P)
> SoC.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzv2h-icu.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzv2h-icu.yaml
> @@ -20,9 +20,14 @@ description:
>
>  properties:
>    compatible:
> -    enum:
> -      - renesas,r9a09g047-icu # RZ/G3E
> -      - renesas,r9a09g057-icu # RZ/V2H(P)
> +    oneOf:
> +      - items:
> +          - enum:
> +              - renesas,r9a09g047-icu # RZ/G3E
> +              - renesas,r9a09g057-icu # RZ/V2H(P)
> +      - items:
> +          - const: renesas,r9a09g056-icu # RZ/V2N
> +          - const: renesas,r9a09g057-icu

Given ICU on RZ/V2H has lots of extra registers compared to RZ/V2N,
I think it would be better to drop the fallback.

>
>    '#interrupt-cells':
>      description: The first cell is the SPI number of the NMI or the

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] dt-bindings: interrupt-controller: renesas,rzv2h-icu: Document RZ/V2N SoC support

Posted by Lad, Prabhakar 5 days, 11 hours ago

Hi Geert,

Thank you for the review.

On Wed, Nov 26, 2025 at 11:22 AM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Tue, 25 Nov 2025 at 22:32, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Document the Interrupt Control Unit (ICU) on the Renesas RZ/V2N SoC,
> > which is architecturally identical to the ICU used on the RZ/V2H(P)
> > SoC.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzv2h-icu.yaml
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzv2h-icu.yaml
> > @@ -20,9 +20,14 @@ description:
> >
> >  properties:
> >    compatible:
> > -    enum:
> > -      - renesas,r9a09g047-icu # RZ/G3E
> > -      - renesas,r9a09g057-icu # RZ/V2H(P)
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - renesas,r9a09g047-icu # RZ/G3E
> > +              - renesas,r9a09g057-icu # RZ/V2H(P)
> > +      - items:
> > +          - const: renesas,r9a09g056-icu # RZ/V2N
> > +          - const: renesas,r9a09g057-icu
>
> Given ICU on RZ/V2H has lots of extra registers compared to RZ/V2N,
> I think it would be better to drop the fallback.
>
Agreed, I had missed that. Currently the driver does not handle these
regs but in future we could so it's better to split out.

Cheers,
Prabhakar

> >
> >    '#interrupt-cells':
> >      description: The first cell is the SPI number of the NMI or the
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds