[PATCHv2 0/2] sched/deadline: Fix potential race in dl_add_task_root_domain()

Pingfan Liu posted 2 patches 2 months, 2 weeks ago
kernel/sched/deadline.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
[PATCHv2 0/2] sched/deadline: Fix potential race in dl_add_task_root_domain()
Posted by Pingfan Liu 2 months, 2 weeks ago
These two patches address the issue reported by Juri [1] (thanks!).

The first removes an unnecessary comment, the second is the actual fix.

@Tejun, while these could be squashed together, I kept them separate to
maintain the one-patch-one-purpose rule. let me know if you'd like me to
resend these in a different format, or feel free to adjust as needed.

[1]: https://lore.kernel.org/lkml/aSBjm3mN_uIy64nz@jlelli-thinkpadt14gen4.remote.csb

Pingfan Liu (2):
  sched/deadline: Remove unnecessary comment in
    dl_add_task_root_domain()
  sched/deadline: Fix potential race in dl_add_task_root_domain()

 kernel/sched/deadline.c | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

-- 
2.49.0
Re: [PATCHv2 0/2] sched/deadline: Fix potential race in dl_add_task_root_domain()
Posted by Waiman Long 2 months, 2 weeks ago
On 11/24/25 10:26 PM, Pingfan Liu wrote:
> These two patches address the issue reported by Juri [1] (thanks!).
>
> The first removes an unnecessary comment, the second is the actual fix.
>
> @Tejun, while these could be squashed together, I kept them separate to
> maintain the one-patch-one-purpose rule. let me know if you'd like me to
> resend these in a different format, or feel free to adjust as needed.
>
> [1]: https://lore.kernel.org/lkml/aSBjm3mN_uIy64nz@jlelli-thinkpadt14gen4.remote.csb
>
> Pingfan Liu (2):
>    sched/deadline: Remove unnecessary comment in
>      dl_add_task_root_domain()
>    sched/deadline: Fix potential race in dl_add_task_root_domain()
>
>   kernel/sched/deadline.c | 12 ++----------
>   1 file changed, 2 insertions(+), 10 deletions(-)
>
For the patch series,

Acked-by:  Waiman Long <longman@redhat.com>

Re: [PATCHv2 0/2] sched/deadline: Fix potential race in dl_add_task_root_domain()
Posted by Juri Lelli 2 months, 2 weeks ago
Hi,

On 25/11/25 11:26, Pingfan Liu wrote:
> These two patches address the issue reported by Juri [1] (thanks!).
> 
> The first removes an unnecessary comment, the second is the actual fix.
> 
> @Tejun, while these could be squashed together, I kept them separate to
> maintain the one-patch-one-purpose rule. let me know if you'd like me to
> resend these in a different format, or feel free to adjust as needed.
> 
> [1]: https://lore.kernel.org/lkml/aSBjm3mN_uIy64nz@jlelli-thinkpadt14gen4.remote.csb
> 
> Pingfan Liu (2):
>   sched/deadline: Remove unnecessary comment in
>     dl_add_task_root_domain()
>   sched/deadline: Fix potential race in dl_add_task_root_domain()
> 
>  kernel/sched/deadline.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)

For both

Acked-by: Juri Lelli <juri.lelli@redhat.com>

Thanks!
Juri
Re: [PATCHv2 0/2] sched/deadline: Fix potential race in dl_add_task_root_domain()
Posted by Waiman Long 1 month ago
On 11/25/25 3:14 AM, Juri Lelli wrote:
> Hi,
>
> On 25/11/25 11:26, Pingfan Liu wrote:
>> These two patches address the issue reported by Juri [1] (thanks!).
>>
>> The first removes an unnecessary comment, the second is the actual fix.
>>
>> @Tejun, while these could be squashed together, I kept them separate to
>> maintain the one-patch-one-purpose rule. let me know if you'd like me to
>> resend these in a different format, or feel free to adjust as needed.
>>
>> [1]: https://lore.kernel.org/lkml/aSBjm3mN_uIy64nz@jlelli-thinkpadt14gen4.remote.csb
>>
>> Pingfan Liu (2):
>>    sched/deadline: Remove unnecessary comment in
>>      dl_add_task_root_domain()
>>    sched/deadline: Fix potential race in dl_add_task_root_domain()
>>
>>   kernel/sched/deadline.c | 12 ++----------
>>   1 file changed, 2 insertions(+), 10 deletions(-)
> For both
>
> Acked-by: Juri Lelli <juri.lelli@redhat.com>

Peter,

Are these 2 patches eligible to be merged into the the scheduler branch 
of the tip tree? These are bug fixes to the deadline scheduler code.

Cheers,
Longman
Re: [PATCHv2 0/2] sched/deadline: Fix potential race in dl_add_task_root_domain()
Posted by Peter Zijlstra 1 month ago
On Wed, Jan 07, 2026 at 02:57:00PM -0500, Waiman Long wrote:
> 
> On 11/25/25 3:14 AM, Juri Lelli wrote:
> > Hi,
> > 
> > On 25/11/25 11:26, Pingfan Liu wrote:
> > > These two patches address the issue reported by Juri [1] (thanks!).
> > > 
> > > The first removes an unnecessary comment, the second is the actual fix.
> > > 
> > > @Tejun, while these could be squashed together, I kept them separate to
> > > maintain the one-patch-one-purpose rule. let me know if you'd like me to
> > > resend these in a different format, or feel free to adjust as needed.
> > > 
> > > [1]: https://lore.kernel.org/lkml/aSBjm3mN_uIy64nz@jlelli-thinkpadt14gen4.remote.csb
> > > 
> > > Pingfan Liu (2):
> > >    sched/deadline: Remove unnecessary comment in
> > >      dl_add_task_root_domain()
> > >    sched/deadline: Fix potential race in dl_add_task_root_domain()
> > > 
> > >   kernel/sched/deadline.c | 12 ++----------
> > >   1 file changed, 2 insertions(+), 10 deletions(-)
> > For both
> > 
> > Acked-by: Juri Lelli <juri.lelli@redhat.com>
> 
> Peter,
> 
> Are these 2 patches eligible to be merged into the the scheduler branch of
> the tip tree? These are bug fixes to the deadline scheduler code.

Thanks for the ping -- just to double check, I need to take the v2
patches, that are posted inside the v7 thread?

I mean; I absolutely detest posting new series in the same thread as an
older series and then you go and do non-linear versioning just to make
it absolutely impossible to tell what's what. :-(
Re: [PATCHv2 0/2] sched/deadline: Fix potential race in dl_add_task_root_domain()
Posted by Pingfan Liu 1 month ago
On Thu, Jan 8, 2026 at 7:42 PM Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Wed, Jan 07, 2026 at 02:57:00PM -0500, Waiman Long wrote:
> >
> > On 11/25/25 3:14 AM, Juri Lelli wrote:
> > > Hi,
> > >
> > > On 25/11/25 11:26, Pingfan Liu wrote:
> > > > These two patches address the issue reported by Juri [1] (thanks!).
> > > >
> > > > The first removes an unnecessary comment, the second is the actual fix.
> > > >
> > > > @Tejun, while these could be squashed together, I kept them separate to
> > > > maintain the one-patch-one-purpose rule. let me know if you'd like me to
> > > > resend these in a different format, or feel free to adjust as needed.
> > > >
> > > > [1]: https://lore.kernel.org/lkml/aSBjm3mN_uIy64nz@jlelli-thinkpadt14gen4.remote.csb
> > > >
> > > > Pingfan Liu (2):
> > > >    sched/deadline: Remove unnecessary comment in
> > > >      dl_add_task_root_domain()
> > > >    sched/deadline: Fix potential race in dl_add_task_root_domain()
> > > >
> > > >   kernel/sched/deadline.c | 12 ++----------
> > > >   1 file changed, 2 insertions(+), 10 deletions(-)
> > > For both
> > >
> > > Acked-by: Juri Lelli <juri.lelli@redhat.com>
> >
> > Peter,
> >
> > Are these 2 patches eligible to be merged into the the scheduler branch of
> > the tip tree? These are bug fixes to the deadline scheduler code.
>
> Thanks for the ping -- just to double check, I need to take the v2
> patches, that are posted inside the v7 thread?
>

Sorry for the confusion. The two fixes in v2 are actually intended to
address the issue in patch [2/2] of v7.

> I mean; I absolutely detest posting new series in the same thread as an
> older series and then you go and do non-linear versioning just to make
> it absolutely impossible to tell what's what. :-(
>

I will use reference format in future. Again, sorry for the confusion.

Best Regards,

Pingfan