1. Patchew
  2. linux
  3. [PATCH v2 0/3] Add support for exynos5250-manta (Google Nexus 10)
  4. View patch

[PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot

Lukas Timmermann posted 3 patches 2 months, 2 weeks ago
There is a newer version of this series
[PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot
Posted by Lukas Timmermann 2 months, 2 weeks ago 
From: Alexandre Marquet <tb@a-marquet.fr>

Add an exception to let the secondary CPU boot.

Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>
Signed-off-by: Lukas Timmermann <linux@timmermann.space>
---
 arch/arm/mach-exynos/firmware.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c
index a5e22678e27b..80e645b4d338 100644
--- a/arch/arm/mach-exynos/firmware.c
+++ b/arch/arm/mach-exynos/firmware.c
@@ -61,10 +61,10 @@ static int exynos_cpu_boot(int cpu)
 	 * Exynos3250 doesn't need to send smc command for secondary CPU boot
 	 * because Exynos3250 removes WFE in secure mode.
 	 *
-	 * On Exynos5 devices the call is ignored by trustzone firmware.
+	 * On most Exynos5 devices the call is ignored by trustzone firmware.
 	 */
 	if (!soc_is_exynos4210() && !soc_is_exynos4212() &&
-	    !soc_is_exynos4412())
+	    !soc_is_exynos4412() && !of_machine_is_compatible("samsung,nexus10-manta"))
 		return 0;
 
 	/*

-- 
2.52.0
Re: [PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot
Posted by Pavel Machek 2 months ago 
On Tue 2025-11-25 16:12:42, Lukas Timmermann wrote:
> From: Alexandre Marquet <tb@a-marquet.fr>
> 
> Add an exception to let the secondary CPU boot.
> 
> Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>
> Signed-off-by: Lukas Timmermann <linux@timmermann.space>
> ---
>  arch/arm/mach-exynos/firmware.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c
> index a5e22678e27b..80e645b4d338 100644
> --- a/arch/arm/mach-exynos/firmware.c
> +++ b/arch/arm/mach-exynos/firmware.c
> @@ -61,10 +61,10 @@ static int exynos_cpu_boot(int cpu)
>  	 * Exynos3250 doesn't need to send smc command for secondary CPU boot
>  	 * because Exynos3250 removes WFE in secure mode.
>  	 *
> -	 * On Exynos5 devices the call is ignored by trustzone firmware.
> +	 * On most Exynos5 devices the call is ignored by trustzone firmware.
>  	 */
>  	if (!soc_is_exynos4210() && !soc_is_exynos4212() &&
> -	    !soc_is_exynos4412())
> +	    !soc_is_exynos4412() && !of_machine_is_compatible("samsung,nexus10-manta"))
>  		return 0;

Strange -- +       compatible = "google,manta", "samsung,exynos5250", "samsung,exynos5";

Should this be google,manta or something?

Also please cc: phone-devel mailing list with phone related patches.

Best regards,
								Pavel

-- 
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, Netanyahu and Musk!
Re: [PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot
Posted by Krzysztof Kozlowski 2 months ago 
On 04/12/2025 12:22, Pavel Machek wrote:
> Also please cc: phone-devel mailing list with phone related patches.

You don't have to. This list is not part of any upstream Linux kernel
process (see `git grep`), it's not relevant to upstream kernel development.


Best regards,
Krzysztof
Re: [PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot
Posted by Pavel Machek 2 months ago 
On Thu 2025-12-04 12:51:36, Krzysztof Kozlowski wrote:
> On 04/12/2025 12:22, Pavel Machek wrote:
> > Also please cc: phone-devel mailing list with phone related patches.
> 
> You don't have to. This list is not part of any upstream Linux kernel
> process (see `git grep`), it's not relevant to upstream kernel development.

Yes, you should. Its a relevant mailing list.

								Pavel
-- 
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, Netanyahu and Musk!
Re: [PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot
Posted by Krzysztof Kozlowski 2 months ago 
On 04/12/2025 12:53, Pavel Machek wrote:
> On Thu 2025-12-04 12:51:36, Krzysztof Kozlowski wrote:
>> On 04/12/2025 12:22, Pavel Machek wrote:
>>> Also please cc: phone-devel mailing list with phone related patches.
>>
>> You don't have to. This list is not part of any upstream Linux kernel
>> process (see `git grep`), it's not relevant to upstream kernel development.
> 
> Yes, you should. Its a relevant mailing list.

git grep for it. Stop inventing rules.

Best regards,
Krzysztof
Re: [PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot
Posted by Pavel Machek 2 months ago 
On Thu 2025-12-04 12:54:03, Krzysztof Kozlowski wrote:
> On 04/12/2025 12:53, Pavel Machek wrote:
> > On Thu 2025-12-04 12:51:36, Krzysztof Kozlowski wrote:
> >> On 04/12/2025 12:22, Pavel Machek wrote:
> >>> Also please cc: phone-devel mailing list with phone related patches.
> >>
> >> You don't have to. This list is not part of any upstream Linux kernel
> >> process (see `git grep`), it's not relevant to upstream kernel development.
> > 
> > Yes, you should. Its a relevant mailing list.
> 
> git grep for it. Stop inventing rules.

Who is inventing rules here? Stop sabotaging review process.

"Many kernel-related lists are hosted on vger.kernel.org; you can find a
list of them at http://vger.kernel.org/vger-lists.html.  There are
kernel-related lists hosted elsewhere as well, though."

								Pavel
-- 
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, Netanyahu and Musk!
Re: [PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot
Posted by Krzysztof Kozlowski 2 months ago 
On 04/12/2025 12:55, Pavel Machek wrote:
> On Thu 2025-12-04 12:54:03, Krzysztof Kozlowski wrote:
>> On 04/12/2025 12:53, Pavel Machek wrote:
>>> On Thu 2025-12-04 12:51:36, Krzysztof Kozlowski wrote:
>>>> On 04/12/2025 12:22, Pavel Machek wrote:
>>>>> Also please cc: phone-devel mailing list with phone related patches.
>>>>
>>>> You don't have to. This list is not part of any upstream Linux kernel
>>>> process (see `git grep`), it's not relevant to upstream kernel development.
>>>
>>> Yes, you should. Its a relevant mailing list.
>>
>> git grep for it. Stop inventing rules.
> 
> Who is inventing rules here? Stop sabotaging review process.

You invented rule that some specific list of your interest has to be
CCed, even though no one knows about that list and it is nowhere documented.

> 
> "Many kernel-related lists are hosted on vger.kernel.org; you can find a
> list of them at http://vger.kernel.org/vger-lists.html.  There are
> kernel-related lists hosted elsewhere as well, though."

This proves nothing. There are just some lists there. No one has to cc
whatever list there just because Pavel Machek asks them. Kernel process
defines it or not. Not you.


Best regards,
Krzysztof
Re: [PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot
Posted by Pavel Machek 2 months ago 
On Thu 2025-12-04 13:02:00, Krzysztof Kozlowski wrote:
> On 04/12/2025 12:55, Pavel Machek wrote:
> > On Thu 2025-12-04 12:54:03, Krzysztof Kozlowski wrote:
> >> On 04/12/2025 12:53, Pavel Machek wrote:
> >>> On Thu 2025-12-04 12:51:36, Krzysztof Kozlowski wrote:
> >>>> On 04/12/2025 12:22, Pavel Machek wrote:
> >>>>> Also please cc: phone-devel mailing list with phone related patches.
> >>>>
> >>>> You don't have to. This list is not part of any upstream Linux kernel
> >>>> process (see `git grep`), it's not relevant to upstream kernel development.
> >>>
> >>> Yes, you should. Its a relevant mailing list.
> >>
> >> git grep for it. Stop inventing rules.
> > 
> > Who is inventing rules here? Stop sabotaging review process.
> 
> You invented rule that some specific list of your interest has to be
> CCed, even though no one knows about that list and it is nowhere documented.

No. I'm asking people to please cc the mailing list so that interested
people can see the patches. It is you blabbering nonsense about "git
grep" and "get_maintainer" as if those were rules.

> > "Many kernel-related lists are hosted on vger.kernel.org; you can find a
> > list of them at http://vger.kernel.org/vger-lists.html.  There are
> > kernel-related lists hosted elsewhere as well, though."
> 
> This proves nothing. There are just some lists there. No one has to cc
> whatever list there just because Pavel Machek asks them. Kernel process
> defines it or not. Not you.

And not you.

Kernel process is to cc relevant people, and relevant mailing lists,
SubmittingPatches points you to http://vger.kernel.org/vger-lists.html
. If people are interested in the patch (for example because they
reacted to previous version), you should cc them. People in
phone-devel expressed interest in phone-related kernel development, so
you should cc them.

								Pavel
-- 
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, Netanyahu and Musk!
Re: [PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot
Posted by Krzysztof Kozlowski 2 months, 2 weeks ago 
On Tue, Nov 25, 2025 at 04:12:42PM +0100, Lukas Timmermann wrote:
> From: Alexandre Marquet <tb@a-marquet.fr>
> 
> Add an exception to let the secondary CPU boot.

Please say here why.

> 
> Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>
> Signed-off-by: Lukas Timmermann <linux@timmermann.space>

Best regards,
Krzysztof
Re: [PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot
Posted by Lukas Timmermann 2 months, 1 week ago 
On Wed, Nov 26, 2025 at 10:24:02AM +0100, Krzysztof Kozlowski wrote:
> On Tue, Nov 25, 2025 at 04:12:42PM +0100, Lukas Timmermann wrote:
> > From: Alexandre Marquet <tb@a-marquet.fr>
> > 
> > Add an exception to let the secondary CPU boot.
> 
> Please say here why.
> 
> > 
> > Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>
> > Signed-off-by: Lukas Timmermann <linux@timmermann.space>
> 
> Best regards,
> Krzysztof
> 
> 
Okay, I will fix that in v3. Thanks

Best regards,
Lukas Timmermann

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.