[PATCH v2 0/3] Add support for exynos5250-manta (Google Nexus 10)

Lukas Timmermann posted 3 patches 6 days, 8 hours ago
.../bindings/arm/samsung/samsung-boards.yaml       |   1 +
arch/arm/boot/dts/samsung/Makefile                 |   1 +
arch/arm/boot/dts/samsung/exynos5250-manta.dts     | 516 +++++++++++++++++++++
arch/arm/mach-exynos/firmware.c                    |   4 +-
4 files changed, 520 insertions(+), 2 deletions(-)
[PATCH v2 0/3] Add support for exynos5250-manta (Google Nexus 10)
Posted by Lukas Timmermann 6 days, 8 hours ago
This patch series adds initial support for the google-manta board, known
as Google Nexus 10 to users. The device is powered by
the Exynos 5250 SoC. The notification led driver (as3668) is already 
(tho not applied) in the kernel mailing list and can be found here:
https://lore.kernel.org/linux-leds/20251125114015.355487-1-linux@timmermann.space/

The first two patches add the necessary device tree files and
bindings, while the last patch makes a small modification to
allow CPU1 to boot, as it requires a call to it's underlying firmware.

This first iteration only provides basic support to get the board
up and running and usable via UART and with WiFi support. We will upstream additional 
features in future patches. All patches have been tested on real hardware.

Signed-off-by: Lukas Timmermann <linux@timmermann.space>
---
Alexandre Marquet (3):
      dt-bindings: ARM: samsung: Add Google Manta (Nexus 10)
      ARM: dts: exynos: Add Google Manta (Nexus 10)
      ARM: samsung: exynos5250: Allow CPU1 to boot

 .../bindings/arm/samsung/samsung-boards.yaml       |   1 +
 arch/arm/boot/dts/samsung/Makefile                 |   1 +
 arch/arm/boot/dts/samsung/exynos5250-manta.dts     | 516 +++++++++++++++++++++
 arch/arm/mach-exynos/firmware.c                    |   4 +-
 4 files changed, 520 insertions(+), 2 deletions(-)
---
base-commit: 6a23ae0a96a600d1d12557add110e0bb6e32730c
change-id: 20251125-google-manta-79545e179d10

Best regards,
-- 
Lukas Timmermann <linux@timmermann.space>
Re: [PATCH v2 0/3] Add support for exynos5250-manta (Google Nexus 10)
Posted by Rob Herring 5 days ago
On Tue, 25 Nov 2025 16:12:39 +0100, Lukas Timmermann wrote:
> This patch series adds initial support for the google-manta board, known
> as Google Nexus 10 to users. The device is powered by
> the Exynos 5250 SoC. The notification led driver (as3668) is already
> (tho not applied) in the kernel mailing list and can be found here:
> https://lore.kernel.org/linux-leds/20251125114015.355487-1-linux@timmermann.space/
> 
> The first two patches add the necessary device tree files and
> bindings, while the last patch makes a small modification to
> allow CPU1 to boot, as it requires a call to it's underlying firmware.
> 
> This first iteration only provides basic support to get the board
> up and running and usable via UART and with WiFi support. We will upstream additional
> features in future patches. All patches have been tested on real hardware.
> 
> Signed-off-by: Lukas Timmermann <linux@timmermann.space>
> ---
> Alexandre Marquet (3):
>       dt-bindings: ARM: samsung: Add Google Manta (Nexus 10)
>       ARM: dts: exynos: Add Google Manta (Nexus 10)
>       ARM: samsung: exynos5250: Allow CPU1 to boot
> 
>  .../bindings/arm/samsung/samsung-boards.yaml       |   1 +
>  arch/arm/boot/dts/samsung/Makefile                 |   1 +
>  arch/arm/boot/dts/samsung/exynos5250-manta.dts     | 516 +++++++++++++++++++++
>  arch/arm/mach-exynos/firmware.c                    |   4 +-
>  4 files changed, 520 insertions(+), 2 deletions(-)
> ---
> base-commit: 6a23ae0a96a600d1d12557add110e0bb6e32730c
> change-id: 20251125-google-manta-79545e179d10
> 
> Best regards,
> --
> Lukas Timmermann <linux@timmermann.space>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: 6a23ae0a96a600d1d12557add110e0bb6e32730c (use --merge-base to override)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/samsung/' for 20251125-google-manta-v2-0-0f097cfff39c@timmermann.space:

arch/arm/boot/dts/samsung/exynos5250-manta.dtb: /soc/i2c@12c70000/led-controller@42: failed to match any schema with compatible: ['ams,as3668']
arch/arm/boot/dts/samsung/exynos5250-manta.dtb: rtc@101e0000 (samsung,s3c6410-rtc): clock-names: ['rtc'] is too short
	from schema $id: http://devicetree.org/schemas/rtc/s3c-rtc.yaml
arch/arm/boot/dts/samsung/exynos5250-manta.dtb: rtc@101e0000 (samsung,s3c6410-rtc): clocks: [[2, 337]] is too short
	from schema $id: http://devicetree.org/schemas/rtc/s3c-rtc.yaml
Re: [PATCH v2 0/3] Add support for exynos5250-manta (Google Nexus 10)
Posted by Krzysztof Kozlowski 6 days, 8 hours ago
On 25/11/2025 16:12, Lukas Timmermann wrote:
> This patch series adds initial support for the google-manta board, known
> as Google Nexus 10 to users. The device is powered by
> the Exynos 5250 SoC. The notification led driver (as3668) is already 
> (tho not applied) in the kernel mailing list and can be found here:
> https://lore.kernel.org/linux-leds/20251125114015.355487-1-linux@timmermann.space/
> 

Thank you for your patches.

Nothing in the cover letter improved regarding my request - you clearly
need to document, in a very explicit and obvious way, that this uses
bindings where not applied. Drivers don't matter here. I need here list
of bindings this is using which were not yet applied by maintainers.

If there is going to be v3, please be sure you fix the cover letter.

Best regards,
Krzysztof
Re: [PATCH v2 0/3] Add support for exynos5250-manta (Google Nexus 10)
Posted by Krzysztof Kozlowski 6 days, 8 hours ago
On 25/11/2025 16:20, Krzysztof Kozlowski wrote:
> On 25/11/2025 16:12, Lukas Timmermann wrote:
>> This patch series adds initial support for the google-manta board, known
>> as Google Nexus 10 to users. The device is powered by
>> the Exynos 5250 SoC. The notification led driver (as3668) is already 
>> (tho not applied) in the kernel mailing list and can be found here:
>> https://lore.kernel.org/linux-leds/20251125114015.355487-1-linux@timmermann.space/
>>
> 
> Thank you for your patches.
> 
> Nothing in the cover letter improved regarding my request - you clearly
> need to document, in a very explicit and obvious way, that this uses
> bindings where not applied. Drivers don't matter here. I need here list

... "bindings which were not applied."

> of bindings this is using which were not yet applied by maintainers.
> 
> If there is going to be v3, please be sure you fix the cover letter.
> 
> Best regards,
> Krzysztof


Best regards,
Krzysztof