Aligned macro values for usecase id along the column length
Signed-off-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
---
include/linux/soc/qcom/llcc-qcom.h | 148 ++++++++++++++++++-------------------
1 file changed, 74 insertions(+), 74 deletions(-)
diff --git a/include/linux/soc/qcom/llcc-qcom.h b/include/linux/soc/qcom/llcc-qcom.h
index 0287f9182c4d..c52464262ab3 100644
--- a/include/linux/soc/qcom/llcc-qcom.h
+++ b/include/linux/soc/qcom/llcc-qcom.h
@@ -8,80 +8,80 @@
#ifndef __LLCC_QCOM__
#define __LLCC_QCOM__
-#define LLCC_CPUSS 1
-#define LLCC_VIDSC0 2
-#define LLCC_VIDSC1 3
-#define LLCC_ROTATOR 4
-#define LLCC_VOICE 5
-#define LLCC_AUDIO 6
-#define LLCC_MDMHPGRW 7
-#define LLCC_MDM 8
-#define LLCC_MODHW 9
-#define LLCC_CMPT 10
-#define LLCC_GPUHTW 11
-#define LLCC_GPU 12
-#define LLCC_MMUHWT 13
-#define LLCC_CMPTDMA 15
-#define LLCC_DISP 16
-#define LLCC_VIDFW 17
-#define LLCC_CAMFW 18
-#define LLCC_MDMHPFX 20
-#define LLCC_MDMPNG 21
-#define LLCC_AUDHW 22
-#define LLCC_NPU 23
-#define LLCC_WLHW 24
-#define LLCC_PIMEM 25
-#define LLCC_ECC 26
-#define LLCC_CVP 28
-#define LLCC_MODPE 29
-#define LLCC_APTCM 30
-#define LLCC_WRCACHE 31
-#define LLCC_CVPFW 32
-#define LLCC_CPUSS1 33
-#define LLCC_CAMEXP0 34
-#define LLCC_CPUMTE 35
-#define LLCC_CPUHWT 36
-#define LLCC_MDMCLAD2 37
-#define LLCC_CAMEXP1 38
-#define LLCC_CMPTHCP 39
-#define LLCC_LCPDARE 40
-#define LLCC_AENPU 45
-#define LLCC_ISLAND1 46
-#define LLCC_ISLAND2 47
-#define LLCC_ISLAND3 48
-#define LLCC_ISLAND4 49
-#define LLCC_CAMEXP2 50
-#define LLCC_CAMEXP3 51
-#define LLCC_CAMEXP4 52
-#define LLCC_DISP_WB 53
-#define LLCC_DISP_1 54
-#define LLCC_VIEYE 57
-#define LLCC_VIDPTH 58
-#define LLCC_GPUMV 59
-#define LLCC_EVA_LEFT 60
-#define LLCC_EVA_RIGHT 61
-#define LLCC_EVAGAIN 62
-#define LLCC_VIPTH 63
-#define LLCC_VIDVSP 64
-#define LLCC_DISP_LEFT 65
-#define LLCC_DISP_RIGHT 66
-#define LLCC_EVCS_LEFT 67
-#define LLCC_EVCS_RIGHT 68
-#define LLCC_SPAD 69
-#define LLCC_VIDDEC 70
-#define LLCC_CAMOFE 71
-#define LLCC_CAMRTIP 72
-#define LLCC_CAMSRTIP 73
-#define LLCC_CAMRTRF 74
-#define LLCC_CAMSRTRF 75
-#define LLCC_VIDEO_APV 83
-#define LLCC_COMPUTE1 87
-#define LLCC_CPUSS_OPP 88
-#define LLCC_CPUSSMPAM 89
-#define LLCC_CAM_IPE_STROV 92
-#define LLCC_CAM_OFE_STROV 93
-#define LLCC_CPUSS_HEU 94
-#define LLCC_MDM_PNG_FIXED 100
+#define LLCC_CPUSS 1
+#define LLCC_VIDSC0 2
+#define LLCC_VIDSC1 3
+#define LLCC_ROTATOR 4
+#define LLCC_VOICE 5
+#define LLCC_AUDIO 6
+#define LLCC_MDMHPGRW 7
+#define LLCC_MDM 8
+#define LLCC_MODHW 9
+#define LLCC_CMPT 10
+#define LLCC_GPUHTW 11
+#define LLCC_GPU 12
+#define LLCC_MMUHWT 13
+#define LLCC_CMPTDMA 15
+#define LLCC_DISP 16
+#define LLCC_VIDFW 17
+#define LLCC_CAMFW 18
+#define LLCC_MDMHPFX 20
+#define LLCC_MDMPNG 21
+#define LLCC_AUDHW 22
+#define LLCC_NPU 23
+#define LLCC_WLHW 24
+#define LLCC_PIMEM 25
+#define LLCC_ECC 26
+#define LLCC_CVP 28
+#define LLCC_MODPE 29
+#define LLCC_APTCM 30
+#define LLCC_WRCACHE 31
+#define LLCC_CVPFW 32
+#define LLCC_CPUSS1 33
+#define LLCC_CAMEXP0 34
+#define LLCC_CPUMTE 35
+#define LLCC_CPUHWT 36
+#define LLCC_MDMCLAD2 37
+#define LLCC_CAMEXP1 38
+#define LLCC_CMPTHCP 39
+#define LLCC_LCPDARE 40
+#define LLCC_AENPU 45
+#define LLCC_ISLAND1 46
+#define LLCC_ISLAND2 47
+#define LLCC_ISLAND3 48
+#define LLCC_ISLAND4 49
+#define LLCC_CAMEXP2 50
+#define LLCC_CAMEXP3 51
+#define LLCC_CAMEXP4 52
+#define LLCC_DISP_WB 53
+#define LLCC_DISP_1 54
+#define LLCC_VIEYE 57
+#define LLCC_VIDPTH 58
+#define LLCC_GPUMV 59
+#define LLCC_EVA_LEFT 60
+#define LLCC_EVA_RIGHT 61
+#define LLCC_EVAGAIN 62
+#define LLCC_VIPTH 63
+#define LLCC_VIDVSP 64
+#define LLCC_DISP_LEFT 65
+#define LLCC_DISP_RIGHT 66
+#define LLCC_EVCS_LEFT 67
+#define LLCC_EVCS_RIGHT 68
+#define LLCC_SPAD 69
+#define LLCC_VIDDEC 70
+#define LLCC_CAMOFE 71
+#define LLCC_CAMRTIP 72
+#define LLCC_CAMSRTIP 73
+#define LLCC_CAMRTRF 74
+#define LLCC_CAMSRTRF 75
+#define LLCC_VIDEO_APV 83
+#define LLCC_COMPUTE1 87
+#define LLCC_CPUSS_OPP 88
+#define LLCC_CPUSSMPAM 89
+#define LLCC_CAM_IPE_STROV 92
+#define LLCC_CAM_OFE_STROV 93
+#define LLCC_CPUSS_HEU 94
+#define LLCC_MDM_PNG_FIXED 100
/**
* struct llcc_slice_desc - Cache slice descriptor
--
2.34.1On Tue, Nov 25, 2025 at 02:46:23PM +0530, Pankaj Patil wrote: > Aligned macro values for usecase id along the column length > -#define LLCC_CAMOFE 71 > -#define LLCC_CAMRTIP 72 > -#define LLCC_CAMSRTIP 73 > -#define LLCC_CAMRTRF 74 > -#define LLCC_CAMSRTRF 75 > -#define LLCC_VIDEO_APV 83 > -#define LLCC_COMPUTE1 87 > -#define LLCC_CPUSS_OPP 88 > -#define LLCC_CPUSSMPAM 89 > -#define LLCC_CAM_IPE_STROV 92 > -#define LLCC_CAM_OFE_STROV 93 > -#define LLCC_CPUSS_HEU 94 > -#define LLCC_MDM_PNG_FIXED 100 > +#define LLCC_CPUSS 1 > +#define LLCC_VIDSC0 2 > +#define LLCC_VIDSC1 3 > +#define LLCC_ROTATOR 4 > +#define LLCC_VOICE 5 This does not look right - you still have here spaces, so nothing fixed. I don't think this change is useful. You replaced one poor alignment into another poor alignment, so IMO better not to touch this at all. Best regards, Krzysztof
On 11/26/2025 2:29 PM, Krzysztof Kozlowski wrote: > On Tue, Nov 25, 2025 at 02:46:23PM +0530, Pankaj Patil wrote: >> Aligned macro values for usecase id along the column length >> -#define LLCC_CAMOFE 71 >> -#define LLCC_CAMRTIP 72 >> -#define LLCC_CAMSRTIP 73 >> -#define LLCC_CAMRTRF 74 >> -#define LLCC_CAMSRTRF 75 >> -#define LLCC_VIDEO_APV 83 >> -#define LLCC_COMPUTE1 87 >> -#define LLCC_CPUSS_OPP 88 >> -#define LLCC_CPUSSMPAM 89 >> -#define LLCC_CAM_IPE_STROV 92 >> -#define LLCC_CAM_OFE_STROV 93 >> -#define LLCC_CPUSS_HEU 94 >> -#define LLCC_MDM_PNG_FIXED 100 >> +#define LLCC_CPUSS 1 >> +#define LLCC_VIDSC0 2 >> +#define LLCC_VIDSC1 3 >> +#define LLCC_ROTATOR 4 >> +#define LLCC_VOICE 5 > This does not look right - you still have here spaces, so nothing fixed. > > I don't think this change is useful. You replaced one poor alignment > into another poor alignment, so IMO better not to touch this at all. > > Best regards, > Krzysztof > Sure, Will drop this patch in next revision
On 26/11/2025 12:38, Pankaj Patil wrote: > On 11/26/2025 2:29 PM, Krzysztof Kozlowski wrote: >> On Tue, Nov 25, 2025 at 02:46:23PM +0530, Pankaj Patil wrote: >>> Aligned macro values for usecase id along the column length >>> -#define LLCC_CAMOFE 71 >>> -#define LLCC_CAMRTIP 72 >>> -#define LLCC_CAMSRTIP 73 >>> -#define LLCC_CAMRTRF 74 >>> -#define LLCC_CAMSRTRF 75 >>> -#define LLCC_VIDEO_APV 83 >>> -#define LLCC_COMPUTE1 87 >>> -#define LLCC_CPUSS_OPP 88 >>> -#define LLCC_CPUSSMPAM 89 >>> -#define LLCC_CAM_IPE_STROV 92 >>> -#define LLCC_CAM_OFE_STROV 93 >>> -#define LLCC_CPUSS_HEU 94 >>> -#define LLCC_MDM_PNG_FIXED 100 >>> +#define LLCC_CPUSS 1 >>> +#define LLCC_VIDSC0 2 >>> +#define LLCC_VIDSC1 3 >>> +#define LLCC_ROTATOR 4 >>> +#define LLCC_VOICE 5 >> This does not look right - you still have here spaces, so nothing fixed. >> >> I don't think this change is useful. You replaced one poor alignment >> into another poor alignment, so IMO better not to touch this at all. >> >> Best regards, >> Krzysztof >> > Sure, Will drop this patch in next revision If fixing this, fix correctly, so these should be tabs accommodating future IDs, so you won't be doing the same every 3 months. But to me it is a bit of churn, does not improve readability and actually affects negatively git blame and backporting, so I would propose to drop it. Best regards, Krzysztof
On Wed, Nov 26, 2025 at 05:08:35PM +0530, Pankaj Patil wrote: > On 11/26/2025 2:29 PM, Krzysztof Kozlowski wrote: > > On Tue, Nov 25, 2025 at 02:46:23PM +0530, Pankaj Patil wrote: > >> Aligned macro values for usecase id along the column length > >> -#define LLCC_CAMOFE 71 > >> -#define LLCC_CAMRTIP 72 > >> -#define LLCC_CAMSRTIP 73 > >> -#define LLCC_CAMRTRF 74 > >> -#define LLCC_CAMSRTRF 75 > >> -#define LLCC_VIDEO_APV 83 > >> -#define LLCC_COMPUTE1 87 > >> -#define LLCC_CPUSS_OPP 88 > >> -#define LLCC_CPUSSMPAM 89 > >> -#define LLCC_CAM_IPE_STROV 92 > >> -#define LLCC_CAM_OFE_STROV 93 > >> -#define LLCC_CPUSS_HEU 94 > >> -#define LLCC_MDM_PNG_FIXED 100 > >> +#define LLCC_CPUSS 1 > >> +#define LLCC_VIDSC0 2 > >> +#define LLCC_VIDSC1 3 > >> +#define LLCC_ROTATOR 4 > >> +#define LLCC_VOICE 5 > > This does not look right - you still have here spaces, so nothing fixed. > > > > I don't think this change is useful. You replaced one poor alignment > > into another poor alignment, so IMO better not to touch this at all. > > > > Best regards, > > Krzysztof > > > Sure, Will drop this patch in next revision > No need to send a new version unless you get any additional feedback on the two useful patches. Regards, Bjorn
© 2016 - 2025 Red Hat, Inc.