[PATCH] EDAC/amd64: Add support for family 19h, models 40h-4fh

Devang Vyas posted 1 patch 1 week ago
There is a newer version of this series
drivers/edac/amd64_edac.c | 3 +++
1 file changed, 3 insertions(+)
[PATCH] EDAC/amd64: Add support for family 19h, models 40h-4fh
Posted by Devang Vyas 1 week ago
This patch updates the EDAC driver to include support
for AMD SoC family 19h models 40h-4fh to support
Ryzen 6000 CPUs/APUs ("Rembrandt").

The added changes enhance the ability to detect and
report memory errors on systems that utilize AMD SoCs
from the specified family.

Co-developed-by: Ramesh Garidapuri <ramesh.garidapuri@amd.com>
Signed-off-by: Ramesh Garidapuri <ramesh.garidapuri@amd.com>
Signed-off-by: Devang Vyas <devangnayanbhai.vyas@amd.com>
---
 drivers/edac/amd64_edac.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index 2391f3469961..6cf0b6d7b5ec 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -3863,6 +3863,9 @@ static int per_family_init(struct amd64_pvt *pvt)
 				pvt->max_mcs		= 8;
 			}
 			break;
+		case 0x40 ... 0x4f:
+			pvt->max_mcs			= 4;
+			break;
 		case 0x60 ... 0x6f:
 			pvt->flags.zn_regs_v2		= 1;
 			break;
-- 
2.25.1
Re: [PATCH] EDAC/amd64: Add support for family 19h, models 40h-4fh
Posted by Borislav Petkov 6 days, 11 hours ago
On Mon, Nov 24, 2025 at 11:43:35PM +0530, Devang Vyas wrote:
> This patch updates the EDAC driver to include support

Avoid having "This patch" or "This commit" in the commit message. It is
tautologically useless.

Also, do

$ git grep 'This patch' Documentation/process

for more details.

> for AMD SoC family 19h models 40h-4fh to support
> Ryzen 6000 CPUs/APUs ("Rembrandt").
> 
> The added changes enhance the ability to detect and
> report memory errors on systems that utilize AMD SoCs
> from the specified family.

Lemme repeat my comment from last time:

"Use the commit message to explain why those need to load the EDAC driver at
all."

Your text still doesn't explain why amd64_edac should load on a client CPU:

https://en.wikipedia.org/wiki/Zen_3#Rembrandt

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette