[PATCH 1/6] dt-bindings: phy: describe additional regulator for Qualcomm SGMII PHY

Mohd Ayaan Anwar posted 6 patches 1 week ago
[PATCH 1/6] dt-bindings: phy: describe additional regulator for Qualcomm SGMII PHY
Posted by Mohd Ayaan Anwar 1 week ago
Describe the additional vdda-0p9-supply for the Qualcomm SGMII PHY.

Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
---
 .../devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml         | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
index 90fc8c039219c739eae05cc17108a9a2fc6193df..0a1330b9118d63cf5400325c58bca05ebc641055 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
@@ -36,6 +36,10 @@ properties:
     description:
       Phandle to a regulator that provides power to the PHY.
 
+  vdda-0p9-supply:
+    description:
+      Phandle to a 0.9V regulator supply to the PHY.
+
   "#phy-cells":
     const: 0
 

-- 
2.34.1
Re: [PATCH 1/6] dt-bindings: phy: describe additional regulator for Qualcomm SGMII PHY
Posted by Krzysztof Kozlowski 6 days, 14 hours ago
On Mon, Nov 24, 2025 at 02:55:17PM +0530, Mohd Ayaan Anwar wrote:
> Describe the additional vdda-0p9-supply for the Qualcomm SGMII PHY.

Why... device was completely described or not? What else is missing?
Please read writing bindings doc - the bindings are supposed to be
complete, so you bringing up properties afterwards feels odd.

> 
> Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
> ---
>  .../devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml         | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
> index 90fc8c039219c739eae05cc17108a9a2fc6193df..0a1330b9118d63cf5400325c58bca05ebc641055 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
> @@ -36,6 +36,10 @@ properties:
>      description:
>        Phandle to a regulator that provides power to the PHY.
>  
> +  vdda-0p9-supply:

Why not vdda? What other supplies are you missing?

> +    description:
> +      Phandle to a 0.9V regulator supply to the PHY.

You just duplicated phy-supply, no? Both supply to the phy or how
exactly does it work?

Best regards,
Krzysztof