[PATCH net-next V2 0/6] selftests: drv-net: Fix issues in devlink_rate_tc_bw.py

Carolina Jubran posted 6 patches 1 week, 1 day ago
There is a newer version of this series
.../testing/selftests/drivers/net/hw/Makefile |   1 +
.../drivers/net/hw/devlink_rate_tc_bw.py      | 174 ++++++++----------
.../drivers/net/hw/lib/py/__init__.py         |   5 +-
.../selftests/drivers/net/lib/py/__init__.py  |   5 +-
.../selftests/drivers/net/lib/py/load.py      |  84 ++++++++-
5 files changed, 157 insertions(+), 112 deletions(-)
[PATCH net-next V2 0/6] selftests: drv-net: Fix issues in devlink_rate_tc_bw.py
Posted by Carolina Jubran 1 week, 1 day ago
Hi,

This series fixes issues in the devlink_rate_tc_bw.py selftest and
introduces a new Iperf3Runner that helps with measurement handling.

Thanks,
Carolina

V2:
- Insert the test in the correct sorted position. 

Carolina Jubran (6):
  selftests: drv-net: Add devlink_rate_tc_bw.py to TEST_PROGS
  selftests: drv-net: introduce Iperf3Runner for measurement use cases
  selftests: drv-net: Use Iperf3Runner in devlink_rate_tc_bw.py
  selftests: drv-net: Set shell=True for sysfs writes in
    devlink_rate_tc_bw.py
  selftests: drv-net: Fix and clarify TC bandwidth split in
    devlink_rate_tc_bw.py
  selftests: drv-net: Fix tolerance calculation in devlink_rate_tc_bw.py

 .../testing/selftests/drivers/net/hw/Makefile |   1 +
 .../drivers/net/hw/devlink_rate_tc_bw.py      | 174 ++++++++----------
 .../drivers/net/hw/lib/py/__init__.py         |   5 +-
 .../selftests/drivers/net/lib/py/__init__.py  |   5 +-
 .../selftests/drivers/net/lib/py/load.py      |  84 ++++++++-
 5 files changed, 157 insertions(+), 112 deletions(-)

-- 
2.38.1
Re: [PATCH net-next V2 0/6] selftests: drv-net: Fix issues in devlink_rate_tc_bw.py
Posted by Jakub Kicinski 6 days, 21 hours ago
On Sun, 23 Nov 2025 19:10:09 +0200 Carolina Jubran wrote:
> This series fixes issues in the devlink_rate_tc_bw.py selftest and
> introduces a new Iperf3Runner that helps with measurement handling.

Sorry to report but patch 2 doesn't apply cleanly.
-- 
pw-bot: cr
Re: [PATCH net-next V2 0/6] selftests: drv-net: Fix issues in devlink_rate_tc_bw.py
Posted by Carolina Jubran 5 days, 16 hours ago
On 25/11/2025 5:10, Jakub Kicinski wrote:
> On Sun, 23 Nov 2025 19:10:09 +0200 Carolina Jubran wrote:
>> This series fixes issues in the devlink_rate_tc_bw.py selftest and
>> introduces a new Iperf3Runner that helps with measurement handling.
> Sorry to report but patch 2 doesn't apply cleanly.


I am based on top of net-next, and I do not see any issues applying the
series. I rebased on top of commit ab084f0b8d6d2ee4b1c6a28f39a2a7430bdfa7f0
and patch 2 still applies cleanly for me.

I’ll prepare a v3 to fix the new pylint warnings in load.py while I’m at
it.

If you are applying it on a different base, please let me know which
one.


Thanks,
Carolina
Re: [PATCH net-next V2 0/6] selftests: drv-net: Fix issues in devlink_rate_tc_bw.py
Posted by Simon Horman 4 days, 4 hours ago
On Wed, Nov 26, 2025 at 10:06:18AM +0200, Carolina Jubran wrote:
> 
> On 25/11/2025 5:10, Jakub Kicinski wrote:
> > On Sun, 23 Nov 2025 19:10:09 +0200 Carolina Jubran wrote:
> > > This series fixes issues in the devlink_rate_tc_bw.py selftest and
> > > introduces a new Iperf3Runner that helps with measurement handling.
> > Sorry to report but patch 2 doesn't apply cleanly.
> 
> 
> I am based on top of net-next, and I do not see any issues applying the
> series. I rebased on top of commit ab084f0b8d6d2ee4b1c6a28f39a2a7430bdfa7f0
> and patch 2 still applies cleanly for me.
> 
> I’ll prepare a v3 to fix the new pylint warnings in load.py while I’m at
> it.
> 
> If you are applying it on a different base, please let me know which
> one.

Hi Carolina,

FWIIW, I do see that b4 shazam (which I assume runs git am) is unable to
apply this series cleanly to ab084f0b8d6d2ee4b1c6a28f39a2a7430bdfa7f0 due
to some fuzz when applying the first patch: Hunk #1 of
tools/testing/selftests/drivers/net/hw/lib/py/__init__.py

And I expect that a rebase figures this out, which is why you
aren't seeing it.