tools/testing/selftests/tpm2/tpm2.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Remove parentheses around assert statements in Python. With parentheses,
assert always evaluates to True, making the checks ineffective.
Signed-off-by: Maurice Hieronymus <mhi@mailbox.org>
---
tools/testing/selftests/tpm2/tpm2.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/tpm2/tpm2.py b/tools/testing/selftests/tpm2/tpm2.py
index bba8cb54548e..3d130c30bc7c 100644
--- a/tools/testing/selftests/tpm2/tpm2.py
+++ b/tools/testing/selftests/tpm2/tpm2.py
@@ -437,7 +437,7 @@ class Client:
def extend_pcr(self, i, dig, bank_alg = TPM2_ALG_SHA1):
ds = get_digest_size(bank_alg)
- assert(ds == len(dig))
+ assert ds == len(dig)
auth_cmd = AuthCommand()
@@ -589,7 +589,7 @@ class Client:
def seal(self, parent_key, data, auth_value, policy_dig,
name_alg = TPM2_ALG_SHA1):
ds = get_digest_size(name_alg)
- assert(not policy_dig or ds == len(policy_dig))
+ assert not policy_dig or ds == len(policy_dig)
attributes = 0
if not policy_dig:
base-commit: 821e6e2a328bb907d40f8d1141d8b6c079aa7340
--
2.50.1
On Sun, Nov 23, 2025 at 12:18:09PM +0100, Maurice Hieronymus wrote: > Remove parentheses around assert statements in Python. With parentheses, > assert always evaluates to True, making the checks ineffective. > > Signed-off-by: Maurice Hieronymus <mhi@mailbox.org> > --- > tools/testing/selftests/tpm2/tpm2.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/tpm2/tpm2.py b/tools/testing/selftests/tpm2/tpm2.py > index bba8cb54548e..3d130c30bc7c 100644 > --- a/tools/testing/selftests/tpm2/tpm2.py > +++ b/tools/testing/selftests/tpm2/tpm2.py > @@ -437,7 +437,7 @@ class Client: > > def extend_pcr(self, i, dig, bank_alg = TPM2_ALG_SHA1): > ds = get_digest_size(bank_alg) > - assert(ds == len(dig)) > + assert ds == len(dig) > > auth_cmd = AuthCommand() > > @@ -589,7 +589,7 @@ class Client: > def seal(self, parent_key, data, auth_value, policy_dig, > name_alg = TPM2_ALG_SHA1): > ds = get_digest_size(name_alg) > - assert(not policy_dig or ds == len(policy_dig)) > + assert not policy_dig or ds == len(policy_dig) > > attributes = 0 > if not policy_dig: > > base-commit: 821e6e2a328bb907d40f8d1141d8b6c079aa7340 > -- > 2.50.1 > Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> BR, Jarkko
© 2016 - 2025 Red Hat, Inc.