[v2] i2c: i2c-elektor: Allow building on SMP kernels

[PATCH v2] i2c: i2c-elektor: Allow building on SMP kernels

Posted by Magnus Lindholm 1 week, 2 days ago

In the past, the i2c-elektor driver was broken on SMP. Since then, there
appear to have been some fixes and cleanup work (as pointed out by Wolfram
Sang) to get rid of cli/sti usage and rely on spinlocks instead. Therefore,
let's allow building the driver on SMP kernels again.

I've tested this driver on an SMP kernel on an Alpha UP2000+ for a few days
without any problems.

Signed-off-by: Magnus Lindholm <linmag7@gmail.com>

Changes since v1:
- Rephrased commit message
---
 drivers/i2c/busses/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index fd81e49638aa..9b1473d720a0 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -1474,7 +1474,7 @@ config I2C_ACORN
 
 config I2C_ELEKTOR
 	tristate "Elektor ISA card"
-	depends on ISA && HAS_IOPORT_MAP && BROKEN_ON_SMP
+	depends on ISA && HAS_IOPORT_MAP
 	select I2C_ALGOPCF
 	help
 	  This supports the PCF8584 ISA bus I2C adapter.  Say Y if you own
-- 
2.51.0

Re: [PATCH v2] i2c: i2c-elektor: Allow building on SMP kernels

Posted by Wolfram Sang 2 days, 12 hours ago

On Sat, Nov 22, 2025 at 02:45:01PM +0100, Magnus Lindholm wrote:
> In the past, the i2c-elektor driver was broken on SMP. Since then, there
> appear to have been some fixes and cleanup work (as pointed out by Wolfram
> Sang) to get rid of cli/sti usage and rely on spinlocks instead. Therefore,
> let's allow building the driver on SMP kernels again.
> 
> I've tested this driver on an SMP kernel on an Alpha UP2000+ for a few days
> without any problems.
> 
> Signed-off-by: Magnus Lindholm <linmag7@gmail.com>
> 
> Changes since v1:
> - Rephrased commit message

Applied to for-next, thanks!