In some projects (HP Lampass), no GPIO was assigned for irq,
it would be better to ignore it.

Signed-off-by: Baojun Xu <baojun.xu@ti.com>
---
 drivers/platform/x86/serial-multi-instantiate.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/platform/x86/serial-multi-instantiate.c b/drivers/platform/x86/serial-multi-instantiate.c
index db030b0f176a..86cecf3ed916 100644
--- a/drivers/platform/x86/serial-multi-instantiate.c
+++ b/drivers/platform/x86/serial-multi-instantiate.c
@@ -214,8 +214,6 @@ static int smi_i2c_probe(struct platform_device *pdev, struct smi *smi,
 		board_info.dev_name = name;
 
 		ret = smi_get_irq(pdev, adev, &inst_array[i]);
-		if (ret < 0)
-			goto error;
 		board_info.irq = ret;
 
 		smi->i2c_devs[i] = i2c_acpi_new_device(dev, i, &board_info);
-- 
2.25.1

On Sat, Nov 22, 2025 at 05:59:03PM +0800, Baojun Xu wrote:
> In some projects (HP Lampass), no GPIO was assigned for irq,
> it would be better to ignore it.

I don't think this is correct approach, but Hans probably knows better
the code.

Also when touching this kind of drivers, please provide ACPI DSDT excerpt
to show the Device object description in question.

-- 
With Best Regards,
Andy Shevchenko

On Mon, 24 Nov 2025 08:36:49 +0100,
Andy Shevchenko wrote:
> 
> On Sat, Nov 22, 2025 at 05:59:03PM +0800, Baojun Xu wrote:
> > In some projects (HP Lampass), no GPIO was assigned for irq,
> > it would be better to ignore it.
> 
> I don't think this is correct approach, but Hans probably knows better
> the code.
> 
> Also when touching this kind of drivers, please provide ACPI DSDT excerpt
> to show the Device object description in question.

Yes, and the patch was submitted rather to the wrong target.
It's no sound driver but x86 platform driver.
Please resubmit to the right target.


thanks,

Takashi