[PATCH v1 07/17] perf mem-events: Don't leak online CPU map

Ian Rogers posted 17 patches 1 week, 2 days ago
[PATCH v1 07/17] perf mem-events: Don't leak online CPU map
Posted by Ian Rogers 1 week, 2 days ago
Reference count checking found the online CPU map was being gotten but
not put. Add in the missing put.

Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/util/mem-events.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
index 80b3069427bc..0b49fce251fc 100644
--- a/tools/perf/util/mem-events.c
+++ b/tools/perf/util/mem-events.c
@@ -303,12 +303,15 @@ int perf_mem_events__record_args(const char **rec_argv, int *argv_nr, char **eve
 	}
 
 	if (cpu_map) {
-		if (!perf_cpu_map__equal(cpu_map, cpu_map__online())) {
+		struct perf_cpu_map *online = cpu_map__online();
+
+		if (!perf_cpu_map__equal(cpu_map, online)) {
 			char buf[200];
 
 			cpu_map__snprint(cpu_map, buf, sizeof(buf));
 			pr_warning("Memory events are enabled on a subset of CPUs: %s\n", buf);
 		}
+		perf_cpu_map__put(online);
 		perf_cpu_map__put(cpu_map);
 	}
 
-- 
2.52.0.rc2.455.g230fcf2819-goog
Re: [PATCH v1 07/17] perf mem-events: Don't leak online CPU map
Posted by Arnaldo Carvalho de Melo 8 hours ago
On Sat, Nov 22, 2025 at 12:19:19AM -0800, Ian Rogers wrote:
> Reference count checking found the online CPU map was being gotten but
> not put. Add in the missing put.

Reviewed-by: Arnaldo Carvalho de Melo <acme@redhat.com>

- Arnaldo
 
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
>  tools/perf/util/mem-events.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
> index 80b3069427bc..0b49fce251fc 100644
> --- a/tools/perf/util/mem-events.c
> +++ b/tools/perf/util/mem-events.c
> @@ -303,12 +303,15 @@ int perf_mem_events__record_args(const char **rec_argv, int *argv_nr, char **eve
>  	}
>  
>  	if (cpu_map) {
> -		if (!perf_cpu_map__equal(cpu_map, cpu_map__online())) {
> +		struct perf_cpu_map *online = cpu_map__online();
> +
> +		if (!perf_cpu_map__equal(cpu_map, online)) {
>  			char buf[200];
>  
>  			cpu_map__snprint(cpu_map, buf, sizeof(buf));
>  			pr_warning("Memory events are enabled on a subset of CPUs: %s\n", buf);
>  		}
> +		perf_cpu_map__put(online);
>  		perf_cpu_map__put(cpu_map);
>  	}
>  
> -- 
> 2.52.0.rc2.455.g230fcf2819-goog