[PATCH v2 00/13] tools/nolibc: always use 64-bit time-related types

Thomas Weißschuh posted 13 patches 1 week, 2 days ago
tools/include/nolibc/arch-s390.h             |   3 +
tools/include/nolibc/compiler.h              |   2 +
tools/include/nolibc/poll.h                  |  14 ++--
tools/include/nolibc/std.h                   |   2 +-
tools/include/nolibc/sys/select.h            |  25 ++-----
tools/include/nolibc/sys/time.h              |   6 +-
tools/include/nolibc/sys/timerfd.h           |  32 +++------
tools/include/nolibc/time.h                  | 102 +++++++++------------------
tools/include/nolibc/types.h                 |  17 ++++-
tools/testing/selftests/nolibc/nolibc-test.c |  27 +++++++
10 files changed, 107 insertions(+), 123 deletions(-)
[PATCH v2 00/13] tools/nolibc: always use 64-bit time-related types
Posted by Thomas Weißschuh 1 week, 2 days ago
nolibc currently uses 32-bit types for various APIs. These are
problematic as their reduced value range can lead to truncated values.

Intended for 6.19.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Changes in v2:
- Drop already applied ino_t and off_t patches.
- Also handle 'struct timeval'.
- Make the progression of the series a bit clearer.
- Add compatibility assertions.
- Link to v1: https://lore.kernel.org/r/20251029-nolibc-uapi-types-v1-0-e79de3b215d8@weissschuh.net

---
Thomas Weißschuh (13):
      tools/nolibc/poll: use kernel types for system call invocations
      tools/nolibc/poll: drop __NR_poll fallback
      tools/nolibc/select: drop non-pselect based implementations
      tools/nolibc/time: drop invocation of gettimeofday system call
      tools/nolibc: prefer explicit 64-bit time-related system calls
      tools/nolibc/gettimeofday: avoid libgcc 64-bit divisions
      tools/nolibc/select: avoid libgcc 64-bit multiplications
      tools/nolibc: use custom structs timespec and timeval
      tools/nolibc: always use 64-bit time types
      selftests/nolibc: test compatibility of nolibc and kernel time types
      tools/nolibc: remove time conversions
      tools/nolibc: add __nolibc_static_assert()
      selftests/nolibc: add static assertions around time types handling

 tools/include/nolibc/arch-s390.h             |   3 +
 tools/include/nolibc/compiler.h              |   2 +
 tools/include/nolibc/poll.h                  |  14 ++--
 tools/include/nolibc/std.h                   |   2 +-
 tools/include/nolibc/sys/select.h            |  25 ++-----
 tools/include/nolibc/sys/time.h              |   6 +-
 tools/include/nolibc/sys/timerfd.h           |  32 +++------
 tools/include/nolibc/time.h                  | 102 +++++++++------------------
 tools/include/nolibc/types.h                 |  17 ++++-
 tools/testing/selftests/nolibc/nolibc-test.c |  27 +++++++
 10 files changed, 107 insertions(+), 123 deletions(-)
---
base-commit: 586e8d5137dfcddfccca44c3b992b92d2be79347
change-id: 20251001-nolibc-uapi-types-1c072d10fcc7

Best regards,
-- 
Thomas Weißschuh <linux@weissschuh.net>

Re: [PATCH v2 00/13] tools/nolibc: always use 64-bit time-related types
Posted by Willy Tarreau 1 day, 13 hours ago
On Sat, Nov 22, 2025 at 05:59:06PM +0100, Thomas Weißschuh wrote:
> nolibc currently uses 32-bit types for various APIs. These are
> problematic as their reduced value range can lead to truncated values.
> 
> Intended for 6.19.
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>

So overall I'm generally fine with the series, with some minor
reserves that can be dealt with later if needed.

Acked-by: Willy Tarreau <w@1wt.eu>

Thanks!
Willy