drivers/reset/core.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
In order to correctly handle the interaction between the reset-gpio
devices and shared GPIOs managed by GPIOLIB, we need to be able to
identify the former. Add the "compatible" property to allow us to use
the device_is_compatible() helper.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
Philipp: this can go directly into your branch, I will fix the GPIO part
in the next cycle. For now it just parses the device name.
drivers/reset/core.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/reset/core.c b/drivers/reset/core.c
index 843cffc939097..b56dace6c42ed 100644
--- a/drivers/reset/core.c
+++ b/drivers/reset/core.c
@@ -898,11 +898,11 @@ static int reset_add_gpio_aux_device(struct device *parent,
*/
static int __reset_add_reset_gpio_device(const struct of_phandle_args *args)
{
- struct property_entry properties[2] = { };
+ struct property_entry properties[3] = { };
unsigned int offset, of_flags, lflags;
struct reset_gpio_lookup *rgpio_dev;
struct device *parent;
- int id, ret;
+ int id, ret, prop = 0;
/*
* Currently only #gpio-cells=2 is supported with the meaning of:
@@ -953,7 +953,8 @@ static int __reset_add_reset_gpio_device(const struct of_phandle_args *args)
lflags = GPIO_PERSISTENT | (of_flags & GPIO_ACTIVE_LOW);
parent = gpio_device_to_device(gdev);
- properties[0] = PROPERTY_ENTRY_GPIO("reset-gpios", parent->fwnode, offset, lflags);
+ properties[prop++] = PROPERTY_ENTRY_STRING("compatible", "reset-gpio");
+ properties[prop++] = PROPERTY_ENTRY_GPIO("reset-gpios", parent->fwnode, offset, lflags);
id = ida_alloc(&reset_gpio_ida, GFP_KERNEL);
if (id < 0)
--
2.51.0
On Fr, 2025-11-21 at 14:57 +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> In order to correctly handle the interaction between the reset-gpio
> devices and shared GPIOs managed by GPIOLIB, we need to be able to
> identify the former. Add the "compatible" property to allow us to use
> the device_is_compatible() helper.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> Philipp: this can go directly into your branch, I will fix the GPIO part
> in the next cycle. For now it just parses the device name.
Applied to reset/next, thanks!
[1/1] reset: gpio: add the "compatible" property
https://git.pengutronix.de/cgit/pza/linux/commit/?id=a0d57f7504b6
regards
Philipp
On Fr, 2025-11-21 at 14:57 +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > In order to correctly handle the interaction between the reset-gpio > devices and shared GPIOs managed by GPIOLIB, we need to be able to > identify the former. Add the "compatible" property to allow us to use > the device_is_compatible() helper. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> regards Philipp
© 2016 - 2025 Red Hat, Inc.