[PATCH v3 3/6] pmdomain: Respect the CPU system wakeup QoS limit for cpuidle

Ulf Hansson posted 6 patches 1 week, 3 days ago
There is a newer version of this series
[PATCH v3 3/6] pmdomain: Respect the CPU system wakeup QoS limit for cpuidle
Posted by Ulf Hansson 1 week, 3 days ago
The CPU system wakeup QoS limit must be respected for the regular cpuidle
state selection. Therefore, let's extend the genpd governor for CPUs to
take the constraint into account when it selects a domain idle state for
the corresponding PM domain.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---

Changes in v3:
	- New patch.

---
 drivers/pmdomain/governor.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/pmdomain/governor.c b/drivers/pmdomain/governor.c
index bd1b9d66d4a5..05e68680f34b 100644
--- a/drivers/pmdomain/governor.c
+++ b/drivers/pmdomain/governor.c
@@ -351,7 +351,7 @@ static bool cpu_power_down_ok(struct dev_pm_domain *pd)
 	ktime_t domain_wakeup, next_hrtimer;
 	ktime_t now = ktime_get();
 	struct device *cpu_dev;
-	s64 cpu_constraint, global_constraint;
+	s64 cpu_constraint, global_constraint, wakeup_constraint;
 	s64 idle_duration_ns;
 	int cpu, i;
 
@@ -362,7 +362,11 @@ static bool cpu_power_down_ok(struct dev_pm_domain *pd)
 	if (!(genpd->flags & GENPD_FLAG_CPU_DOMAIN))
 		return true;
 
+	wakeup_constraint = cpu_wakeup_latency_qos_limit();
 	global_constraint = cpu_latency_qos_limit();
+	if (global_constraint > wakeup_constraint)
+		global_constraint = wakeup_constraint;
+
 	/*
 	 * Find the next wakeup for any of the online CPUs within the PM domain
 	 * and its subdomains. Note, we only need the genpd->cpus, as it already
-- 
2.43.0
Re: [PATCH v3 3/6] pmdomain: Respect the CPU system wakeup QoS limit for cpuidle
Posted by Dhruva Gole 6 days, 19 hours ago
On Nov 21, 2025 at 11:03:09 +0100, Ulf Hansson wrote:
> The CPU system wakeup QoS limit must be respected for the regular cpuidle
> state selection. Therefore, let's extend the genpd governor for CPUs to
> take the constraint into account when it selects a domain idle state for
> the corresponding PM domain.
> 
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> 
> Changes in v3:
> 	- New patch.
> 
> ---
>  drivers/pmdomain/governor.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pmdomain/governor.c b/drivers/pmdomain/governor.c
> index bd1b9d66d4a5..05e68680f34b 100644
> --- a/drivers/pmdomain/governor.c
> +++ b/drivers/pmdomain/governor.c
> @@ -351,7 +351,7 @@ static bool cpu_power_down_ok(struct dev_pm_domain *pd)
>  	ktime_t domain_wakeup, next_hrtimer;
>  	ktime_t now = ktime_get();
>  	struct device *cpu_dev;
> -	s64 cpu_constraint, global_constraint;
> +	s64 cpu_constraint, global_constraint, wakeup_constraint;
>  	s64 idle_duration_ns;
>  	int cpu, i;
>  
> @@ -362,7 +362,11 @@ static bool cpu_power_down_ok(struct dev_pm_domain *pd)
>  	if (!(genpd->flags & GENPD_FLAG_CPU_DOMAIN))
>  		return true;
>  
> +	wakeup_constraint = cpu_wakeup_latency_qos_limit();
>  	global_constraint = cpu_latency_qos_limit();
> +	if (global_constraint > wakeup_constraint)
> +		global_constraint = wakeup_constraint;
> +

Reviewed-by: Dhruva Gole <d-gole@ti.com>

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated