./drivers/resctrl/mpam_internal.h: linux/srcu.h is included more than once.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=27328
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/resctrl/mpam_internal.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/resctrl/mpam_internal.h b/drivers/resctrl/mpam_internal.h
index e79c3c47259c..f733bed011bd 100644
--- a/drivers/resctrl/mpam_internal.h
+++ b/drivers/resctrl/mpam_internal.h
@@ -14,7 +14,6 @@
 #include <linux/mutex.h>
 #include <linux/srcu.h>
 #include <linux/spinlock.h>
-#include <linux/srcu.h>
 #include <linux/types.h>
 
 #define MPAM_MSC_MAX_NUM_RIS	16
-- 
2.43.5

Hi Jiapeng,

On 21/11/2025 03:39, Jiapeng Chong wrote:
> ./drivers/resctrl/mpam_internal.h: linux/srcu.h is included more than once.

> diff --git a/drivers/resctrl/mpam_internal.h b/drivers/resctrl/mpam_internal.h
> index e79c3c47259c..f733bed011bd 100644
> --- a/drivers/resctrl/mpam_internal.h
> +++ b/drivers/resctrl/mpam_internal.h
> @@ -14,7 +14,6 @@
>  #include <linux/mutex.h>
>  #include <linux/srcu.h>
>  #include <linux/spinlock.h>
> -#include <linux/srcu.h>
>  #include <linux/types.h>

(If you removed the other entry instead the list would be alphabetical order)

Either way,
Acked-by: James Morse <james.morse@arm.com>


Thanks,

James

Hi, Jiapeng,

On 11/20/25 19:39, Jiapeng Chong wrote:
> ./drivers/resctrl/mpam_internal.h: linux/srcu.h is included more than once.
> 

Do you need to add "Fixes:" here?
Fixes: 8c90dc68a5de ("arm_mpam: Probe the hardware features resctrl 
supports")

Not sure it's necessary for this minor fix but 
Documentations/process/submitting-patches.rst says "If your patch fixes 
a bug in a specific commit, e.g. you found an issue using
``git bisect``, please use the 'Fixes:' tag with at least the first 12
characters of the SHA-1 ID, and the one line summary.  Do not split the tag
across multiple lines, tags are exempt from the "wrap at 75 columns" rule in
order to simplify parsing scripts."

> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=27328
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>   drivers/resctrl/mpam_internal.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/resctrl/mpam_internal.h b/drivers/resctrl/mpam_internal.h
> index e79c3c47259c..f733bed011bd 100644
> --- a/drivers/resctrl/mpam_internal.h
> +++ b/drivers/resctrl/mpam_internal.h
> @@ -14,7 +14,6 @@
>   #include <linux/mutex.h>
>   #include <linux/srcu.h>
>   #include <linux/spinlock.h>
> -#include <linux/srcu.h>
>   #include <linux/types.h>
>   
>   #define MPAM_MSC_MAX_NUM_RIS	16

Thanks.

-Fenghua