[PATCH 2/4] soc: qcom: llcc: Enable additional usecase id for Glymur

Pankaj Patil posted 4 patches 1 week, 3 days ago
There is a newer version of this series
[PATCH 2/4] soc: qcom: llcc: Enable additional usecase id for Glymur
Posted by Pankaj Patil 1 week, 3 days ago
Update the list of usecase id's to enable additional clients
for Glymur SoC

Signed-off-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
---
 include/linux/soc/qcom/llcc-qcom.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/linux/soc/qcom/llcc-qcom.h b/include/linux/soc/qcom/llcc-qcom.h
index 0287f9182c4d..8243ab3a12a8 100644
--- a/include/linux/soc/qcom/llcc-qcom.h
+++ b/include/linux/soc/qcom/llcc-qcom.h
@@ -74,13 +74,17 @@
 #define LLCC_CAMSRTIP	 73
 #define LLCC_CAMRTRF	 74
 #define LLCC_CAMSRTRF	 75
+#define LLCC_OOBM_NS	 81
+#define LLCC_OOBM_S	 82
 #define LLCC_VIDEO_APV	 83
 #define LLCC_COMPUTE1	 87
 #define LLCC_CPUSS_OPP	 88
 #define LLCC_CPUSSMPAM	 89
+#define LLCC_VIDSC_VSP1	 91
 #define LLCC_CAM_IPE_STROV	 92
 #define LLCC_CAM_OFE_STROV	 93
 #define LLCC_CPUSS_HEU	 94
+#define LLCC_PCIE_TCU	 97
 #define LLCC_MDM_PNG_FIXED	 100
 
 /**

-- 
2.34.1
Re: [PATCH 2/4] soc: qcom: llcc: Enable additional usecase id for Glymur
Posted by Krzysztof Kozlowski 1 week, 3 days ago
On 21/11/2025 10:53, Pankaj Patil wrote:
> Update the list of usecase id's to enable additional clients
> for Glymur SoC
> 
> Signed-off-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
> ---
>  include/linux/soc/qcom/llcc-qcom.h | 4 ++++

That's not a separate patch. We do not want defines just for defines.
You add defines because some code uses it, so there is a user. Where? It
must be in this patch, for all typical cases.

>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/soc/qcom/llcc-qcom.h b/include/linux/soc/qcom/llcc-qcom.h
> index 0287f9182c4d..8243ab3a12a8 100644
> --- a/include/linux/soc/qcom/llcc-qcom.h
> +++ b/include/linux/soc/qcom/llcc-qcom.h
> @@ -74,13 +74,17 @@
>  #define LLCC_CAMSRTIP	 73
>  #define LLCC_CAMRTRF	 74
>  #define LLCC_CAMSRTRF	 75
> +#define LLCC_OOBM_NS	 81
Best regards,
Krzysztof
Re: [PATCH 2/4] soc: qcom: llcc: Enable additional usecase id for Glymur
Posted by Pankaj Patil 1 week, 3 days ago
On 11/21/2025 4:07 PM, Krzysztof Kozlowski wrote:
> On 21/11/2025 10:53, Pankaj Patil wrote:
>> Update the list of usecase id's to enable additional clients
>> for Glymur SoC
>>
>> Signed-off-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
>> ---
>>  include/linux/soc/qcom/llcc-qcom.h | 4 ++++
> That's not a separate patch. We do not want defines just for defines.
> You add defines because some code uses it, so there is a user. Where? It
> must be in this patch, for all typical cases.

Understood, will squash with driver changes where the defines are used

>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/include/linux/soc/qcom/llcc-qcom.h b/include/linux/soc/qcom/llcc-qcom.h
>> index 0287f9182c4d..8243ab3a12a8 100644
>> --- a/include/linux/soc/qcom/llcc-qcom.h
>> +++ b/include/linux/soc/qcom/llcc-qcom.h
>> @@ -74,13 +74,17 @@
>>  #define LLCC_CAMSRTIP	 73
>>  #define LLCC_CAMRTRF	 74
>>  #define LLCC_CAMSRTRF	 75
>> +#define LLCC_OOBM_NS	 81
> Best regards,
> Krzysztof