[v1] wifi: iwlwifi: mld: remove unused variable in d3.c

[PATCH RESEND iwlwifi-next] wifi: iwlwifi: mld: remove unused variable in d3.c

Posted by Ally Heev 1 week, 3 days ago

remove unused variable `old_keys`

Signed-off-by: Ally Heev <allyheev@gmail.com>
---
 drivers/net/wireless/intel/iwlwifi/mld/d3.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mld/d3.c b/drivers/net/wireless/intel/iwlwifi/mld/d3.c
index 1d4282a21f09e0f90a52dc02c8287ecc0e0fafe1..fefb4f532a1f9fbb1a4a5cbd2ade817d5c1adb58 100644
--- a/drivers/net/wireless/intel/iwlwifi/mld/d3.c
+++ b/drivers/net/wireless/intel/iwlwifi/mld/d3.c
@@ -996,8 +996,6 @@ static void iwl_mld_mlo_rekey(struct iwl_mld *mld,
 			      struct iwl_mld_wowlan_status *wowlan_status,
 			      struct ieee80211_vif *vif)
 {
-	struct iwl_mld_old_mlo_keys *old_keys __free(kfree) = NULL;
-
 	IWL_DEBUG_WOWLAN(mld, "Num of MLO Keys: %d\n", wowlan_status->num_mlo_keys);
 
 	if (!wowlan_status->num_mlo_keys)

---
base-commit: 4427259cc7f7571a157fbc9b5011e1ef6fe0a4a8
change-id: 20251111-aheev-remove-unused-var-old-keys-104ffca9bf62

Best regards,
-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQBFRpOLrIakF7DYvaWPaLUP9d7HAUCaRLyowAKCRCWPaLUP9d7
HLG9AQDZmggT93tMLv32pq5myG3e83t12KWON9efOBg//lH4vgD+Ppw3KoTpdYtJ
20VDaWuqUVj9KLqjx9hblfEiB7s9gQw=
=A6F+
-----END PGP SIGNATURE-----
-- 
Ally Heev <allyheev@gmail.com>

Re: [PATCH RESEND iwlwifi-next] wifi: iwlwifi: mld: remove unused variable in d3.c

Posted by Krzysztof Kozlowski 1 week, 2 days ago

On 21/11/2025 15:27, Ally Heev wrote:
> remove unused variable `old_keys`
> 
> Signed-off-by: Ally Heev <allyheev@gmail.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/mld/d3.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/mld/d3.c b/drivers/net/wireless/intel/iwlwifi/mld/d3.c
> index 1d4282a21f09e0f90a52dc02c8287ecc0e0fafe1..fefb4f532a1f9fbb1a4a5cbd2ade817d5c1adb58 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mld/d3.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mld/d3.c
> @@ -996,8 +996,6 @@ static void iwl_mld_mlo_rekey(struct iwl_mld *mld,
>  			      struct iwl_mld_wowlan_status *wowlan_status,
>  			      struct ieee80211_vif *vif)
>  {
> -	struct iwl_mld_old_mlo_keys *old_keys __free(kfree) = NULL;
> -
>  	IWL_DEBUG_WOWLAN(mld, "Num of MLO Keys: %d\n", wowlan_status->num_mlo_keys);
>  
>  	if (!wowlan_status->num_mlo_keys)
> 
> ---
> base-commit: 4427259cc7f7571a157fbc9b5011e1ef6fe0a4a8
> change-id: 20251111-aheev-remove-unused-var-old-keys-104ffca9bf62
> 
> Best regards,
> -----BEGIN PGP SIGNATURE-----
> 
> iHUEABYKAB0WIQQBFRpOLrIakF7DYvaWPaLUP9d7HAUCaRLyowAKCRCWPaLUP9d7
> HLG9AQDZmggT93tMLv32pq5myG3e83t12KWON9efOBg//lH4vgD+Ppw3KoTpdYtJ
> 20VDaWuqUVj9KLqjx9hblfEiB7s9gQw=
> =A6F+
> -----END PGP SIGNATURE-----

You should switch to patatt instead, not signing emails. We don't use
that, I think at all, unlike patatt which is being actively checked by
toolkit (b4).

Anyway, not a problem, just noise, so:


Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

Re: [PATCH RESEND iwlwifi-next] wifi: iwlwifi: mld: remove unused variable in d3.c

Posted by Konstantin Ryabitsev 1 week ago

On Sat, Nov 22, 2025 at 03:18:20PM +0100, Krzysztof Kozlowski wrote:
> > Best regards,
> > -----BEGIN PGP SIGNATURE-----
> > 
> > iHUEABYKAB0WIQQBFRpOLrIakF7DYvaWPaLUP9d7HAUCaRLyowAKCRCWPaLUP9d7
> > HLG9AQDZmggT93tMLv32pq5myG3e83t12KWON9efOBg//lH4vgD+Ppw3KoTpdYtJ
> > 20VDaWuqUVj9KLqjx9hblfEiB7s9gQw=
> > =A6F+
> > -----END PGP SIGNATURE-----
> 
> You should switch to patatt instead, not signing emails. We don't use
> that, I think at all, unlike patatt which is being actively checked by
> toolkit (b4).

It's even more curious. The patch was sent with b4, but I'm pretty sure we
wouldn't have put the PGP signature in like that, so I'm curious how that even
happened.

Ally, can you shed some light on that?

-K

Re: [PATCH RESEND iwlwifi-next] wifi: iwlwifi: mld: remove unused variable in d3.c

Posted by ally heev 1 week ago

On Mon, 2025-11-24 at 10:38 -0500, Konstantin Ryabitsev wrote:
> On Sat, Nov 22, 2025 at 03:18:20PM +0100, Krzysztof Kozlowski wrote:
> > > Best regards,
> > > -----BEGIN PGP SIGNATURE-----
> > > 
> > > iHUEABYKAB0WIQQBFRpOLrIakF7DYvaWPaLUP9d7HAUCaRLyowAKCRCWPaLUP9d7
> > > HLG9AQDZmggT93tMLv32pq5myG3e83t12KWON9efOBg//lH4vgD+Ppw3KoTpdYtJ
> > > 20VDaWuqUVj9KLqjx9hblfEiB7s9gQw=
> > > =A6F+
> > > -----END PGP SIGNATURE-----
> > 
> > You should switch to patatt instead, not signing emails. We don't use
> > that, I think at all, unlike patatt which is being actively checked by
> > toolkit (b4).
> 
> It's even more curious. The patch was sent with b4, but I'm pretty sure we
> wouldn't have put the PGP signature in like that, so I'm curious how that even
> happened.
> 
> Ally, can you shed some light on that?
> 
> -K

Yes, I use b4 for my patches. I work on other open source projects
which use Github. So, my global git config commit autosign is set to
`true`, hence you have seen PGP signatures. 

I have disabled it locally now

Regards,
Ally

Re: [PATCH RESEND iwlwifi-next] wifi: iwlwifi: mld: remove unused variable in d3.c

Posted by Konstantin Ryabitsev 1 week ago

On Mon, Nov 24, 2025 at 09:28:39PM +0530, ally heev wrote:
> > > > Best regards,
> > > > -----BEGIN PGP SIGNATURE-----
> > > > 
> > > > iHUEABYKAB0WIQQBFRpOLrIakF7DYvaWPaLUP9d7HAUCaRLyowAKCRCWPaLUP9d7
> > > > HLG9AQDZmggT93tMLv32pq5myG3e83t12KWON9efOBg//lH4vgD+Ppw3KoTpdYtJ
> > > > 20VDaWuqUVj9KLqjx9hblfEiB7s9gQw=
> > > > =A6F+
> > > > -----END PGP SIGNATURE-----
> > > 
> > > You should switch to patatt instead, not signing emails. We don't use
> > > that, I think at all, unlike patatt which is being actively checked by
> > > toolkit (b4).
> > 
> > It's even more curious. The patch was sent with b4, but I'm pretty sure we
> > wouldn't have put the PGP signature in like that, so I'm curious how that even
> > happened.
> > 
> > Ally, can you shed some light on that?
> > 
> > -K
> 
> Yes, I use b4 for my patches. I work on other open source projects
> which use Github. So, my global git config commit autosign is set to
> `true`, hence you have seen PGP signatures. 

Interesting! I've not seen this cause PGP signatures to be added to "git show"
output before. I've tried to replicate it locally, but even if I have a signed
git commit, I can't make the "gpgsig" header to show up in the output of "git
show --format=email" (which is what b4 uses). Do you have some local git
configuration changes that make "gpgsig" fields show up in the output of "git
show"?

-K

Re: [PATCH RESEND iwlwifi-next] wifi: iwlwifi: mld: remove unused variable in d3.c

Posted by ally heev 6 days, 17 hours ago

On Mon, 2025-11-24 at 11:28 -0500, Konstantin Ryabitsev wrote:
> On Mon, Nov 24, 2025 at 09:28:39PM +0530, ally heev wrote:
> > > > > Best regards,
> > > > > -----BEGIN PGP SIGNATURE-----
> > > > > 
> > > > > iHUEABYKAB0WIQQBFRpOLrIakF7DYvaWPaLUP9d7HAUCaRLyowAKCRCWPaLUP9d7
> > > > > HLG9AQDZmggT93tMLv32pq5myG3e83t12KWON9efOBg//lH4vgD+Ppw3KoTpdYtJ
> > > > > 20VDaWuqUVj9KLqjx9hblfEiB7s9gQw=
> > > > > =A6F+
> > > > > -----END PGP SIGNATURE-----
> > > > 
> > > > You should switch to patatt instead, not signing emails. We don't use
> > > > that, I think at all, unlike patatt which is being actively checked by
> > > > toolkit (b4).
> > > 
> > > It's even more curious. The patch was sent with b4, but I'm pretty sure we
> > > wouldn't have put the PGP signature in like that, so I'm curious how that even
> > > happened.
> > > 
> > > Ally, can you shed some light on that?
> > > 
> > > -K
> > 
> > Yes, I use b4 for my patches. I work on other open source projects
> > which use Github. So, my global git config commit autosign is set to

typo: `tag autosign`

> > `true`, hence you have seen PGP signatures. 
> 
> Interesting! I've not seen this cause PGP signatures to be added to "git show"
> output before. I've tried to replicate it locally, but even if I have a signed
> git commit, I can't make the "gpgsig" header to show up in the output of "git
> show --format=email" (which is what b4 uses). Do you have some local git
> configuration changes that make "gpgsig" fields show up in the output of "git
> show"?
> 
> -K

I think b4 uses tags for patch series. I have checked old
patches(before disabling autosign) and found that signature is only
added on first(cover-letter) of the patch series

Regards,
Ally

Re: [PATCH RESEND iwlwifi-next] wifi: iwlwifi: mld: remove unused variable in d3.c

Posted by Konstantin Ryabitsev 6 days, 11 hours ago

On Tue, Nov 25, 2025 at 12:50:44PM +0530, ally heev wrote:
> > > Yes, I use b4 for my patches. I work on other open source projects
> > > which use Github. So, my global git config commit autosign is set to
> 
> typo: `tag autosign`
> 
> > > `true`, hence you have seen PGP signatures. 
> > 
> > Interesting! I've not seen this cause PGP signatures to be added to "git show"
> > output before. I've tried to replicate it locally, but even if I have a signed
> > git commit, I can't make the "gpgsig" header to show up in the output of "git
> > show --format=email" (which is what b4 uses). Do you have some local git
> > configuration changes that make "gpgsig" fields show up in the output of "git
> > show"?
> > 
> > -K
> 
> I think b4 uses tags for patch series. I have checked old
> patches(before disabling autosign) and found that signature is only
> added on first(cover-letter) of the patch series

Oh! Interesting, so this happened on resend? I'll test it out, thanks!

-K

Re: [PATCH RESEND iwlwifi-next] wifi: iwlwifi: mld: remove unused variable in d3.c

Posted by ally heev 6 days, 9 hours ago

On Tue, 2025-11-25 at 08:54 -0500, Konstantin Ryabitsev wrote:
> On Tue, Nov 25, 2025 at 12:50:44PM +0530, ally heev wrote:
> > > > Yes, I use b4 for my patches. I work on other open source projects
> > > > which use Github. So, my global git config commit autosign is set to
> > 
> > typo: `tag autosign`
> > 
> > > > `true`, hence you have seen PGP signatures. 
> > > 
> > > Interesting! I've not seen this cause PGP signatures to be added to "git show"
> > > output before. I've tried to replicate it locally, but even if I have a signed
> > > git commit, I can't make the "gpgsig" header to show up in the output of "git
> > > show --format=email" (which is what b4 uses). Do you have some local git
> > > configuration changes that make "gpgsig" fields show up in the output of "git
> > > show"?
> > > 
> > > -K
> > 
> > I think b4 uses tags for patch series. I have checked old
> > patches(before disabling autosign) and found that signature is only
> > added on first(cover-letter) of the patch series
> 
> Oh! Interesting, so this happened on resend? I'll test it out, thanks!

I didn't get it. Signature was added to every cover-letter of patch
series before I disabled `tag autosign`

> 
> -K