On Thu, 20 Nov 2025 15:56:01 -0500
Steven Rostedt <rostedt@kernel.org> wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
>
> In event_trigger_regex_release(), the only code is:
>
> mutex_lock(&event_mutex);
> if (file->f_mode & FMODE_READ)
> seq_release(inode, file);
> mutex_unlock(&event_mutex);
>
> return 0;
>
> There's nothing special about the file->f_mode or the seq_release() that
> requires any locking. Remove the unnecessary locks.
>
Looks good to me.
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> ---
> kernel/trace/trace_events_trigger.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/kernel/trace/trace_events_trigger.c b/kernel/trace/trace_events_trigger.c
> index 7795af600466..e5dcfcbb2cd5 100644
> --- a/kernel/trace/trace_events_trigger.c
> +++ b/kernel/trace/trace_events_trigger.c
> @@ -314,13 +314,9 @@ static ssize_t event_trigger_regex_write(struct file *file,
>
> static int event_trigger_regex_release(struct inode *inode, struct file *file)
> {
> - mutex_lock(&event_mutex);
> -
> if (file->f_mode & FMODE_READ)
> seq_release(inode, file);
>
> - mutex_unlock(&event_mutex);
> -
> return 0;
> }
>
> --
> 2.51.0
>
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>