From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>

Adjust the whitespace alignment for the RTC_BBPU_KEY macro definition
in the mt6397 RTC header file. This is a cosmetic change to improve
code consistency.

Signed-off-by: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
---
 include/linux/mfd/mt6397/rtc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mfd/mt6397/rtc.h b/include/linux/mfd/mt6397/rtc.h
index 27883af44f87..6d0bb1ea151b 100644
--- a/include/linux/mfd/mt6397/rtc.h
+++ b/include/linux/mfd/mt6397/rtc.h
@@ -16,7 +16,7 @@
 
 #define RTC_BBPU               0x0000
 #define RTC_BBPU_CBUSY         BIT(6)
-#define RTC_BBPU_KEY            (0x43 << 8)
+#define RTC_BBPU_KEY           (0x43 << 8)
 
 #define RTC_WRTGR_MT6358       0x003a
 #define RTC_WRTGR_MT6397       0x003c
-- 
2.45.2

On 20/11/2025 13:17, ot_shunxi.zhang@mediatek.com wrote:
> From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
> 
> Adjust the whitespace alignment for the RTC_BBPU_KEY macro definition
> in the mt6397 RTC header file. This is a cosmetic change to improve
> code consistency.

Please don't send such changes line by line.. You have other patches
here doing the same. Organize all such trivial stuff, including for
other drivers not only this one (!!),  in one patch. This is just churn.



Best regards,
Krzysztof

On Thu, 2025-11-20 at 14:38 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 20/11/2025 13:17, ot_shunxi.zhang@mediatek.com wrote:
> > From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
> > 
> > Adjust the whitespace alignment for the RTC_BBPU_KEY macro
> > definition
> > in the mt6397 RTC header file. This is a cosmetic change to improve
> > code consistency.
> 
> Please don't send such changes line by line.. You have other patches
> here doing the same. Organize all such trivial stuff, including for
> other drivers not only this one (!!),  in one patch. This is just
> churn.
> 
> 
> 
> Best regards,
> Krzysztof

Dear sir,
Execuse me,
do you mean we shouldn't make the "formatting changes" a separate
patch? This was based on a previous comment: 
https://patchwork.kernel.org/project/linux-mediatek/patch/20250811081543.4377-2-ot_shunxi.zhang@mediatek.com/#26517538. If it doesn't need to be a separate patch, I will make it into a patch with other changes in the next version.

Best Regards
Shunxi Zhang

On 21/11/2025 04:07, Shunxi Zhang (章顺喜) wrote:
> On Thu, 2025-11-20 at 14:38 +0100, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> On 20/11/2025 13:17, ot_shunxi.zhang@mediatek.com wrote:
>>> From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
>>>
>>> Adjust the whitespace alignment for the RTC_BBPU_KEY macro
>>> definition
>>> in the mt6397 RTC header file. This is a cosmetic change to improve
>>> code consistency.
>>
>> Please don't send such changes line by line.. You have other patches
>> here doing the same. Organize all such trivial stuff, including for
>> other drivers not only this one (!!),  in one patch. This is just
>> churn.
>>
>>
>>
>> Best regards,
>> Krzysztof
> 
> Dear sir,
> Execuse me,
> do you mean we shouldn't make the "formatting changes" a separate
> patch? This was based on a previous comment: 

Fix entire subsystem or multiple drivers not only one line.


Best regards,
Krzysztof