1. Patchew
  2. linux
  3. View series

[PATCH] net: wwan: mhi: Keep modem name match with Foxconn T99W640

Slark Xiao posted 1 patch 1 week, 4 days ago
There is a newer version of this series
drivers/net/wwan/mhi_wwan_mbim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] net: wwan: mhi: Keep modem name match with Foxconn T99W640
Posted by Slark Xiao 1 week, 4 days ago 
Correct it since M.2 device T99W640 has updated from T99W515.
We need to align it with MHI side otherwise this modem can't
get the network.

Fixes: ae5a34264354 ("bus: mhi: host: pci_generic: Fix the modem name of Foxconn T99W640")
Fixes: 65bc58c3dcad ("net: wwan: mhi: make default data link id configurable")
Signed-off-by: Slark Xiao <slark_xiao@163.com>
---
 drivers/net/wwan/mhi_wwan_mbim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wwan/mhi_wwan_mbim.c b/drivers/net/wwan/mhi_wwan_mbim.c
index a142af59a91f..1d7e3ad900c1 100644
--- a/drivers/net/wwan/mhi_wwan_mbim.c
+++ b/drivers/net/wwan/mhi_wwan_mbim.c
@@ -98,7 +98,7 @@ static struct mhi_mbim_link *mhi_mbim_get_link_rcu(struct mhi_mbim_context *mbim
 static int mhi_mbim_get_link_mux_id(struct mhi_controller *cntrl)
 {
 	if (strcmp(cntrl->name, "foxconn-dw5934e") == 0 ||
-	    strcmp(cntrl->name, "foxconn-t99w515") == 0 ||
+	    strcmp(cntrl->name, "foxconn-t99w640") == 0 ||
 	    strcmp(cntrl->name, "foxconn-t99w760") == 0)
 		return WDS_BIND_MUX_DATA_PORT_MUX_ID;
 
-- 
2.25.1
Re: [PATCH] net: wwan: mhi: Keep modem name match with Foxconn T99W640
Posted by Jakub Kicinski 1 week, 2 days ago 
On Thu, 20 Nov 2025 19:41:15 +0800 Slark Xiao wrote:
> Correct it since M.2 device T99W640 has updated from T99W515.
> We need to align it with MHI side otherwise this modem can't
> get the network.
> 
> Fixes: ae5a34264354 ("bus: mhi: host: pci_generic: Fix the modem name of Foxconn T99W640")
> Fixes: 65bc58c3dcad ("net: wwan: mhi: make default data link id configurable")
> Signed-off-by: Slark Xiao <slark_xiao@163.com>

Doesn't apply to either networking tree :(
-- 
pw-bot: cr
Re:Re: [PATCH] net: wwan: mhi: Keep modem name match with Foxconn T99W640
Posted by Slark Xiao 1 week ago 
At 2025-11-22 10:08:36, "Jakub Kicinski" <kuba@kernel.org> wrote:
>On Thu, 20 Nov 2025 19:41:15 +0800 Slark Xiao wrote:
>> Correct it since M.2 device T99W640 has updated from T99W515.
>> We need to align it with MHI side otherwise this modem can't
>> get the network.
>> 
>> Fixes: ae5a34264354 ("bus: mhi: host: pci_generic: Fix the modem name of Foxconn T99W640")
>> Fixes: 65bc58c3dcad ("net: wwan: mhi: make default data link id configurable")
>> Signed-off-by: Slark Xiao <slark_xiao@163.com>
>
>Doesn't apply to either networking tree :(
I have cc the email address by the system command 
"scripts/get_maintainer.pl patch". Do you mean shall I remove
netdev@vger.kernel.org by manual?
>-- 
>pw-bot: cr
Re: Re: [PATCH] net: wwan: mhi: Keep modem name match with Foxconn T99W640
Posted by Loic Poulain 1 week ago 
On Mon, Nov 24, 2025 at 3:31 AM Slark Xiao <slark_xiao@163.com> wrote:
>
>
> At 2025-11-22 10:08:36, "Jakub Kicinski" <kuba@kernel.org> wrote:
> >On Thu, 20 Nov 2025 19:41:15 +0800 Slark Xiao wrote:
> >> Correct it since M.2 device T99W640 has updated from T99W515.
> >> We need to align it with MHI side otherwise this modem can't
> >> get the network.
> >>
> >> Fixes: ae5a34264354 ("bus: mhi: host: pci_generic: Fix the modem name of Foxconn T99W640")
> >> Fixes: 65bc58c3dcad ("net: wwan: mhi: make default data link id configurable")
> >> Signed-off-by: Slark Xiao <slark_xiao@163.com>
> >
> >Doesn't apply to either networking tree :(
> I have cc the email address by the system command
> "scripts/get_maintainer.pl patch". Do you mean shall I remove
> netdev@vger.kernel.org by manual?

This means your patch does not apply cleanly to net.git [1] or net-next.git.
So you have to rebase your change on the net.git tree before resending.

Regards,
Loic

[1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git
Re:Re: Re: [PATCH] net: wwan: mhi: Keep modem name match with Foxconn T99W640
Posted by Slark Xiao 1 week ago 
At 2025-11-24 17:53:54, "Loic Poulain" <loic.poulain@oss.qualcomm.com> wrote:
>On Mon, Nov 24, 2025 at 3:31 AM Slark Xiao <slark_xiao@163.com> wrote:
>>
>>
>> At 2025-11-22 10:08:36, "Jakub Kicinski" <kuba@kernel.org> wrote:
>> >On Thu, 20 Nov 2025 19:41:15 +0800 Slark Xiao wrote:
>> >> Correct it since M.2 device T99W640 has updated from T99W515.
>> >> We need to align it with MHI side otherwise this modem can't
>> >> get the network.
>> >>
>> >> Fixes: ae5a34264354 ("bus: mhi: host: pci_generic: Fix the modem name of Foxconn T99W640")
>> >> Fixes: 65bc58c3dcad ("net: wwan: mhi: make default data link id configurable")
>> >> Signed-off-by: Slark Xiao <slark_xiao@163.com>
>> >
>> >Doesn't apply to either networking tree :(
>> I have cc the email address by the system command
>> "scripts/get_maintainer.pl patch". Do you mean shall I remove
>> netdev@vger.kernel.org by manual?
>
>This means your patch does not apply cleanly to net.git [1] or net-next.git.
>So you have to rebase your change on the net.git tree before resending.
>
>Regards,
>Loic
>
>[1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git
Hi Loic,
I see. Actually this patch was generated in mhi code base.
But I didn't see any difference of this file between mhi and net.
And, there is another commit may affect this change:

https://lore.kernel.org/netdev/20251119105615.48295-3-slark_xiao@163.com/
-	    strcmp(cntrl->name, "foxconn-t99w515") == 0)
+	    strcmp(cntrl->name, "foxconn-t99w515") == 0 ||
+	    strcmp(cntrl->name, "foxconn-t99w760") == 0)

I edited above commit firstly and now it's reviewed status but not applied.
If I update this change based net or net-dev, above T99W760 support 
commit then would have a conflict since they are not a common
series. How shall I do to avoid this potential conflict?

Thanks
Re: [PATCH] net: wwan: mhi: Keep modem name match with Foxconn T99W640
Posted by Jakub Kicinski 6 days, 23 hours ago 
On Mon, 24 Nov 2025 18:07:22 +0800 (CST) Slark Xiao wrote:
> I see. Actually this patch was generated in mhi code base.
> But I didn't see any difference of this file between mhi and net.
> And, there is another commit may affect this change:
> 
> https://lore.kernel.org/netdev/20251119105615.48295-3-slark_xiao@163.com/
> -	    strcmp(cntrl->name, "foxconn-t99w515") == 0)
> +	    strcmp(cntrl->name, "foxconn-t99w515") == 0 ||
> +	    strcmp(cntrl->name, "foxconn-t99w760") == 0)
> 
> I edited above commit firstly and now it's reviewed status but not applied.
> If I update this change based net or net-dev, above T99W760 support 
> commit then would have a conflict since they are not a common
> series. How shall I do to avoid this potential conflict?

Are you saying you have to concurrent submissions changing one file?
If yes please repost them as a series.
Re:Re: [PATCH] net: wwan: mhi: Keep modem name match with Foxconn T99W640
Posted by Slark Xiao 6 days, 22 hours ago 
At 2025-11-25 10:42:19, "Jakub Kicinski" <kuba@kernel.org> wrote:
>On Mon, 24 Nov 2025 18:07:22 +0800 (CST) Slark Xiao wrote:
>> I see. Actually this patch was generated in mhi code base.
>> But I didn't see any difference of this file between mhi and net.
>> And, there is another commit may affect this change:
>> 
>> https://lore.kernel.org/netdev/20251119105615.48295-3-slark_xiao@163.com/
>> -	    strcmp(cntrl->name, "foxconn-t99w515") == 0)
>> +	    strcmp(cntrl->name, "foxconn-t99w515") == 0 ||
>> +	    strcmp(cntrl->name, "foxconn-t99w760") == 0)
>> 
>> I edited above commit firstly and now it's reviewed status but not applied.
>> If I update this change based net or net-dev, above T99W760 support 
>> commit then would have a conflict since they are not a common
>> series. How shall I do to avoid this potential conflict?
>
>Are you saying you have to concurrent submissions changing one file?
>If yes please repost them as a series.
One patch of previous series has been applied. Does it matter to repost a new
series including that applied patch?
Or net team apply the rest patch of previous series , then try to review this patch
again. I guess there is no conflict any more.
Re: [PATCH] net: wwan: mhi: Keep modem name match with Foxconn T99W640
Posted by Jakub Kicinski 6 days, 22 hours ago 
On Tue, 25 Nov 2025 11:06:30 +0800 (CST) Slark Xiao wrote:
> >Are you saying you have to concurrent submissions changing one file?
> >If yes please repost them as a series.  
> One patch of previous series has been applied. 

To the mhi tree?
Re:Re: [PATCH] net: wwan: mhi: Keep modem name match with Foxconn T99W640
Posted by Slark Xiao 6 days, 22 hours ago 
At 2025-11-25 11:12:26, "Jakub Kicinski" <kuba@kernel.org> wrote:
>On Tue, 25 Nov 2025 11:06:30 +0800 (CST) Slark Xiao wrote:
>> >Are you saying you have to concurrent submissions changing one file?
>> >If yes please repost them as a series.  
>> One patch of previous series has been applied. 
>
>To the mhi tree?

Yes. It has been applied to mhi-next branch. That patch applied before posting this
patch .
Re: [PATCH] net: wwan: mhi: Keep modem name match with Foxconn T99W640
Posted by Jakub Kicinski 6 days, 22 hours ago 
On Tue, 25 Nov 2025 11:16:06 +0800 (CST) Slark Xiao wrote:
> At 2025-11-25 11:12:26, "Jakub Kicinski" <kuba@kernel.org> wrote:
> >On Tue, 25 Nov 2025 11:06:30 +0800 (CST) Slark Xiao wrote:  
> >> >Are you saying you have to concurrent submissions changing one file?
> >> >If yes please repost them as a series.    
> >> One patch of previous series has been applied.   
> >
> >To the mhi tree?  
> 
> Yes. It has been applied to mhi-next branch. That patch applied
> before posting this patch .

In this tree? 
https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git/
That'd be unacceptable for a drivers/net/ patch.
But I don't see such a patch here. 
Just patches to drivers/bus/mhi/
Re:Re: [PATCH] net: wwan: mhi: Keep modem name match with Foxconn T99W640
Posted by Slark Xiao 6 days, 22 hours ago 
At 2025-11-25 11:21:11, "Jakub Kicinski" <kuba@kernel.org> wrote:
>On Tue, 25 Nov 2025 11:16:06 +0800 (CST) Slark Xiao wrote:
>> At 2025-11-25 11:12:26, "Jakub Kicinski" <kuba@kernel.org> wrote:
>> >On Tue, 25 Nov 2025 11:06:30 +0800 (CST) Slark Xiao wrote:  
>> >> >Are you saying you have to concurrent submissions changing one file?
>> >> >If yes please repost them as a series.    
>> >> One patch of previous series has been applied.   
>> >
>> >To the mhi tree?  
>> 
>> Yes. It has been applied to mhi-next branch. That patch applied
>> before posting this patch .
>
>In this tree? 
>https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git/
Yes. 
>That'd be unacceptable for a drivers/net/ patch.
>But I don't see such a patch here. 
>Just patches to drivers/bus/mhi/
The patch for drivers/net still in a reviewed status, but not applied.
MHI side has inform NET side about the apply status. 
https://lore.kernel.org/netdev/176361751471.6039.14437856360980124388.b4-ty@oss.qualcomm.com/

So currently it shall be pending in NET side?
Re: [PATCH] net: wwan: mhi: Keep modem name match with Foxconn T99W640
Posted by Manivannan Sadhasivam 6 days, 20 hours ago 
On Tue, Nov 25, 2025 at 11:31:23AM +0800, Slark Xiao wrote:
> 
> At 2025-11-25 11:21:11, "Jakub Kicinski" <kuba@kernel.org> wrote:
> >On Tue, 25 Nov 2025 11:16:06 +0800 (CST) Slark Xiao wrote:
> >> At 2025-11-25 11:12:26, "Jakub Kicinski" <kuba@kernel.org> wrote:
> >> >On Tue, 25 Nov 2025 11:06:30 +0800 (CST) Slark Xiao wrote:  
> >> >> >Are you saying you have to concurrent submissions changing one file?
> >> >> >If yes please repost them as a series.    
> >> >> One patch of previous series has been applied.   
> >> >
> >> >To the mhi tree?  
> >> 
> >> Yes. It has been applied to mhi-next branch. That patch applied
> >> before posting this patch .
> >
> >In this tree? 
> >https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git/
> Yes. 
> >That'd be unacceptable for a drivers/net/ patch.
> >But I don't see such a patch here. 
> >Just patches to drivers/bus/mhi/
> The patch for drivers/net still in a reviewed status, but not applied.
> MHI side has inform NET side about the apply status. 
> https://lore.kernel.org/netdev/176361751471.6039.14437856360980124388.b4-ty@oss.qualcomm.com/
> 
> So currently it shall be pending in NET side?

This patch has no build dependency with the MHI patch that I applied to
mhi-next [1]. So please rebase on top of net/net-next and repost, so that this
one can go through netdev for v6.19.

- Mani

[1] https://lore.kernel.org/all/20251119105615.48295-2-slark_xiao@163.com

-- 
மணிவண்ணன் சதாசிவம்
Re: [PATCH] net: wwan: mhi: Keep modem name match with Foxconn T99W640
Posted by Loic Poulain 1 week, 3 days ago 
Hi Slark,

On Thu, Nov 20, 2025 at 12:41 PM Slark Xiao <slark_xiao@163.com> wrote:
>
> Correct it since M.2 device T99W640 has updated from T99W515.
> We need to align it with MHI side otherwise this modem can't
> get the network.
>
> Fixes: ae5a34264354 ("bus: mhi: host: pci_generic: Fix the modem name of Foxconn T99W640")
> Fixes: 65bc58c3dcad ("net: wwan: mhi: make default data link id configurable")

Only the first Fixes tag is needed, as that’s where the mismatch was
introduced and should be considered the point of correction.

> Signed-off-by: Slark Xiao <slark_xiao@163.com>
> ---
>  drivers/net/wwan/mhi_wwan_mbim.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wwan/mhi_wwan_mbim.c b/drivers/net/wwan/mhi_wwan_mbim.c
> index a142af59a91f..1d7e3ad900c1 100644
> --- a/drivers/net/wwan/mhi_wwan_mbim.c
> +++ b/drivers/net/wwan/mhi_wwan_mbim.c
> @@ -98,7 +98,7 @@ static struct mhi_mbim_link *mhi_mbim_get_link_rcu(struct mhi_mbim_context *mbim
>  static int mhi_mbim_get_link_mux_id(struct mhi_controller *cntrl)
>  {
>         if (strcmp(cntrl->name, "foxconn-dw5934e") == 0 ||
> -           strcmp(cntrl->name, "foxconn-t99w515") == 0 ||
> +           strcmp(cntrl->name, "foxconn-t99w640") == 0 ||
>             strcmp(cntrl->name, "foxconn-t99w760") == 0)
>                 return WDS_BIND_MUX_DATA_PORT_MUX_ID;
>
> --
> 2.25.1
>
Re:Re: [PATCH] net: wwan: mhi: Keep modem name match with Foxconn T99W640
Posted by Slark Xiao 1 week ago 
At 2025-11-21 20:57:07, "Loic Poulain" <loic.poulain@oss.qualcomm.com> wrote:
>Hi Slark,
>
>On Thu, Nov 20, 2025 at 12:41 PM Slark Xiao <slark_xiao@163.com> wrote:
>>
>> Correct it since M.2 device T99W640 has updated from T99W515.
>> We need to align it with MHI side otherwise this modem can't
>> get the network.
>>
>> Fixes: ae5a34264354 ("bus: mhi: host: pci_generic: Fix the modem name of Foxconn T99W640")
>> Fixes: 65bc58c3dcad ("net: wwan: mhi: make default data link id configurable")
>
>Only the first Fixes tag is needed, as that’s where the mismatch was
>introduced and should be considered the point of correction.
>
Will fix this in next version patch.

>> Signed-off-by: Slark Xiao <slark_xiao@163.com>
>> ---
>>  drivers/net/wwan/mhi_wwan_mbim.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wwan/mhi_wwan_mbim.c b/drivers/net/wwan/mhi_wwan_mbim.c
>> index a142af59a91f..1d7e3ad900c1 100644
>> --- a/drivers/net/wwan/mhi_wwan_mbim.c
>> +++ b/drivers/net/wwan/mhi_wwan_mbim.c
>> @@ -98,7 +98,7 @@ static struct mhi_mbim_link *mhi_mbim_get_link_rcu(struct mhi_mbim_context *mbim
>>  static int mhi_mbim_get_link_mux_id(struct mhi_controller *cntrl)
>>  {
>>         if (strcmp(cntrl->name, "foxconn-dw5934e") == 0 ||
>> -           strcmp(cntrl->name, "foxconn-t99w515") == 0 ||
>> +           strcmp(cntrl->name, "foxconn-t99w640") == 0 ||
>>             strcmp(cntrl->name, "foxconn-t99w760") == 0)
>>                 return WDS_BIND_MUX_DATA_PORT_MUX_ID;
>>
>> --
>> 2.25.1
>>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.