[PATCH v2 0/9] st_lsm6dsx: add tap event detection

Francesco Lavra posted 9 patches 1 week, 4 days ago
There is a newer version of this series
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h      |  56 +-
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 538 +++++++++++++------
2 files changed, 395 insertions(+), 199 deletions(-)
[PATCH v2 0/9] st_lsm6dsx: add tap event detection
Posted by Francesco Lavra 1 week, 4 days ago
The bulk of this patch set consists of reworking the existing code for
event detection (which supports IIO_EV_TYPE_THRESH events only) in order to
make it generic to accommodate different event types. Actual support for
tap events is implemented in the last patch.
Tested on LSMDSV16X.

Changes from v1 [1]:
- added Fixes tag to patch 1/9 (Andy, Lorenzo)
- added st_lsm6dsx_field_get() temporary macro, to be removed once the
  generic FIELD_GET() macro lands (Andy)
- refactored st_lsm6dsx_write_event_config() with the addition of two
  helper functions st_lsm6dsx_check_other_events() and
  st_lsm6dsx_events_enable() (Andy)
- replaced dynamic allocation of iio_chan_spec and iio_event_spec arrays
  with the addition of new static arrays (Jonathan)
- changed line wrapping to 80 characters (Lorenzo, Andy)
- changed line wrapping for commit messages to 75 characters (Jonathan)
- added comments to st_lsm6dsx_event_setup() and st_lsm6dsx_get_event_reg()
  (Andy)
- miscellaneous stylistic changes (Andy)

[1] https://lore.kernel.org/linux-iio/20251030072752.349633-1-flavra@baylibre.com/T/

Francesco Lavra (9):
  iio: imu: st_lsm6dsx: fix iio_chan_spec for sensors without event
    detection
  iio: imu: st_lsm6dsx: make event_settings more generic
  iio: imu: st_lsm6dsx: move wakeup event enable mask to event_src
  iio: imu: st_lsm6dsx: rework code to check for enabled events
  iio: imu: st_lsm6dsx: remove event_threshold field from hw struct
  iio: imu: st_lsm6dsx: make event management functions generic
  iio: imu: st_lsm6dsx: add event configurability on a per axis basis
  iio: imu: st_lsm6dsx: add event spec parameter to iio_chan_spec
    initializer
  iio: imu: st_lsm6dsx: add tap event detection

 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h      |  56 +-
 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 538 +++++++++++++------
 2 files changed, 395 insertions(+), 199 deletions(-)

-- 
2.39.5
Re: [PATCH v2 0/9] st_lsm6dsx: add tap event detection
Posted by Andy Shevchenko 1 week, 4 days ago
On Thu, Nov 20, 2025 at 09:26:06AM +0100, Francesco Lavra wrote:
> The bulk of this patch set consists of reworking the existing code for
> event detection (which supports IIO_EV_TYPE_THRESH events only) in order to
> make it generic to accommodate different event types. Actual support for
> tap events is implemented in the last patch.
> Tested on LSMDSV16X.

Still one piece to get better, but overall looks good to me now,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
(at least for the patches with no comments from me, and for the one more
 after addressing the comment)

-- 
With Best Regards,
Andy Shevchenko