Monaco-evk has LT8713sx which act as DP to 3 DP output
converter. Edp PHY from monaco soc is connected to lt8713sx
as input and output of lt8713sx is connected to 3 mini DP ports.
Two of these ports are available in mainboard and one port
is available on Mezz board. lt8713sx is connected to soc over
i2c0 and with reset gpio connected to pin6 or ioexpander5.
Enable the edp nodes from monaco and enable lontium lt8713sx
bridge node.
Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/monaco-evk.dts | 44 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
index bb35893da73d..947807f8a9cb 100644
--- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
+++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
@@ -317,6 +317,20 @@ &gpu_zap_shader {
firmware-name = "qcom/qcs8300/a623_zap.mbn";
};
+&i2c0 {
+ pinctrl-0 = <&qup_i2c0_default>;
+ pinctrl-names = "default";
+
+ status = "okay";
+
+ lt8713sx: lt8713sx@4f {
+ /*Display bridge chip, DP1.4/HDMI2.0/DP++ hub*/
+ compatible = "lontium,lt8713sx";
+ reg = <0x4f>;
+ reset-gpios = <&expander5 6 GPIO_ACTIVE_HIGH>;
+ };
+};
+
&i2c1 {
pinctrl-0 = <&qup_i2c1_default>;
pinctrl-names = "default";
@@ -396,6 +410,23 @@ expander6: gpio@3e {
};
};
+&mdss {
+ status = "okay";
+};
+
+&mdss_dp0 {
+ status = "okay";
+};
+
+&mdss_dp0_out {
+ data-lanes = <0 1 2 3>;
+ link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+};
+
+&mdss_dp0_phy {
+ status = "okay";
+};
+
&iris {
status = "okay";
};
@@ -435,6 +466,12 @@ &serdes0 {
};
&tlmm {
+ dp_hot_plug_det: dp-hot-plug-det-state {
+ pins = "gpio94";
+ function = "edp0_hot";
+ bias-disable;
+ };
+
ethernet0_default: ethernet0-default-state {
ethernet0_mdc: ethernet0-mdc-pins {
pins = "gpio5";
@@ -451,6 +488,13 @@ ethernet0_mdio: ethernet0-mdio-pins {
};
};
+ qup_i2c0_default: qup-i2c0-state {
+ pins = "gpio17", "gpio18";
+ function = "qup0_se0";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
+
qup_i2c1_default: qup-i2c1-state {
pins = "gpio19", "gpio20";
function = "qup0_se1";
--
2.34.1Hi Vishnu, kernel test robot noticed the following build errors: [auto build test ERROR on 3c3d81183061b9e49dd3207fbbbc36314744bf3f] url: https://github.com/intel-lab-lkp/linux/commits/Vishnu-Saini/arm64-dts-qcom-monaco-add-lt8713sx-bridge-with-displayport/20251120-190522 base: 3c3d81183061b9e49dd3207fbbbc36314744bf3f patch link: https://lore.kernel.org/r/20251120-lt8713sx-bridge-linux-for-next-v1-1-2246fc5fb490%40qti.qualcomm.com patch subject: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport config: arm64-defconfig (https://download.01.org/0day-ci/archive/20251124/202511241826.Maela061-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 15.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251124/202511241826.Maela061-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202511241826.Maela061-lkp@intel.com/ All errors (new ones prefixed by >>): Error: arch/arm64/boot/dts/qcom/monaco-evk.dts:413.1-6 Label or path mdss not found Error: arch/arm64/boot/dts/qcom/monaco-evk.dts:417.1-10 Label or path mdss_dp0 not found Error: arch/arm64/boot/dts/qcom/monaco-evk.dts:421.1-14 Label or path mdss_dp0_out not found Error: arch/arm64/boot/dts/qcom/monaco-evk.dts:426.1-14 Label or path mdss_dp0_phy not found >> FATAL ERROR: Syntax error parsing input tree -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
On Thu, Nov 20, 2025 at 04:28:05PM +0530, Vishnu Saini wrote:
> Monaco-evk has LT8713sx which act as DP to 3 DP output
> converter. Edp PHY from monaco soc is connected to lt8713sx
> as input and output of lt8713sx is connected to 3 mini DP ports.
> Two of these ports are available in mainboard and one port
> is available on Mezz board. lt8713sx is connected to soc over
> i2c0 and with reset gpio connected to pin6 or ioexpander5.
>
This is good, you're describing the role of LT8713sx and how it's
connected on the board. Thank you for taking the time to do so!
I think one aspect that's worth pointing out on its own is the
placement of the mini DP ports. You do capture it, but the fact that
we have two on the EVK and one on the expansion board is "hidden" there
in the middle of the paragraph.
I think extracting this part of the message into its own paragraph would
improve the commit message further.
> Enable the edp nodes from monaco and enable lontium lt8713sx
> bridge node.
>
> Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/monaco-evk.dts | 44 ++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> index bb35893da73d..947807f8a9cb 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> @@ -317,6 +317,20 @@ &gpu_zap_shader {
> firmware-name = "qcom/qcs8300/a623_zap.mbn";
> };
>
Would it be possible to add dp-connector nodes and wire them up to the
<8713sx, like I did in sa8295-adp.dts?
> +&i2c0 {
> + pinctrl-0 = <&qup_i2c0_default>;
> + pinctrl-names = "default";
> +
> + status = "okay";
> +
> + lt8713sx: lt8713sx@4f {
This should be bridge@4f.
Also, unless we need to reference this from a overlay there's no need to
give it a label.
> + /*Display bridge chip, DP1.4/HDMI2.0/DP++ hub*/
This comment explains what "lontium,lt8713sx" is. The binding call tell
me that, so the value of this comment would be for you to tell us what
it is used for on this particular board - and if that's obvious you can
omit the comment.
> + compatible = "lontium,lt8713sx";
> + reg = <0x4f>;
> + reset-gpios = <&expander5 6 GPIO_ACTIVE_HIGH>;
In addition to using an of_graph to describe the connectors that this is
wired to, it would be nice to have a port describing the relationship to
the DP controller here as well - so we know where the signal is coming
from.
Would that be possible to add?
Regards,
Bjorn
> + };
> +};
> +
> &i2c1 {
> pinctrl-0 = <&qup_i2c1_default>;
> pinctrl-names = "default";
> @@ -396,6 +410,23 @@ expander6: gpio@3e {
> };
> };
>
> +&mdss {
> + status = "okay";
> +};
> +
> +&mdss_dp0 {
> + status = "okay";
> +};
> +
> +&mdss_dp0_out {
> + data-lanes = <0 1 2 3>;
> + link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
> +};
> +
> +&mdss_dp0_phy {
> + status = "okay";
> +};
> +
> &iris {
> status = "okay";
> };
> @@ -435,6 +466,12 @@ &serdes0 {
> };
>
> &tlmm {
> + dp_hot_plug_det: dp-hot-plug-det-state {
> + pins = "gpio94";
> + function = "edp0_hot";
> + bias-disable;
> + };
> +
> ethernet0_default: ethernet0-default-state {
> ethernet0_mdc: ethernet0-mdc-pins {
> pins = "gpio5";
> @@ -451,6 +488,13 @@ ethernet0_mdio: ethernet0-mdio-pins {
> };
> };
>
> + qup_i2c0_default: qup-i2c0-state {
> + pins = "gpio17", "gpio18";
> + function = "qup0_se0";
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> +
> qup_i2c1_default: qup-i2c1-state {
> pins = "gpio19", "gpio20";
> function = "qup0_se1";
>
> --
> 2.34.1
>
On Thu, Nov 20, 2025 at 08:26:40AM -0600, Bjorn Andersson wrote:
> On Thu, Nov 20, 2025 at 04:28:05PM +0530, Vishnu Saini wrote:
> > Monaco-evk has LT8713sx which act as DP to 3 DP output
> > converter. Edp PHY from monaco soc is connected to lt8713sx
> > as input and output of lt8713sx is connected to 3 mini DP ports.
> > Two of these ports are available in mainboard and one port
> > is available on Mezz board. lt8713sx is connected to soc over
> > i2c0 and with reset gpio connected to pin6 or ioexpander5.
> >
>
> This is good, you're describing the role of LT8713sx and how it's
> connected on the board. Thank you for taking the time to do so!
>
> I think one aspect that's worth pointing out on its own is the
> placement of the mini DP ports. You do capture it, but the fact that
> we have two on the EVK and one on the expansion board is "hidden" there
> in the middle of the paragraph.
> I think extracting this part of the message into its own paragraph would
> improve the commit message further.
>
Yes, Updated in V2.
> > Enable the edp nodes from monaco and enable lontium lt8713sx
> > bridge node.
> >
> > Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> > ---
> > arch/arm64/boot/dts/qcom/monaco-evk.dts | 44 ++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 44 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> > index bb35893da73d..947807f8a9cb 100644
> > --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> > +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> > @@ -317,6 +317,20 @@ &gpu_zap_shader {
> > firmware-name = "qcom/qcs8300/a623_zap.mbn";
> > };
> >
>
> Would it be possible to add dp-connector nodes and wire them up to the
> <8713sx, like I did in sa8295-adp.dts?
>
Yes, added dp-connectors in V2.
> > +&i2c0 {
> > + pinctrl-0 = <&qup_i2c0_default>;
> > + pinctrl-names = "default";
> > +
> > + status = "okay";
> > +
> > + lt8713sx: lt8713sx@4f {
>
> This should be bridge@4f.
>
> Also, unless we need to reference this from a overlay there's no need to
> give it a label.
Yes, done.
>
> > + /*Display bridge chip, DP1.4/HDMI2.0/DP++ hub*/
>
> This comment explains what "lontium,lt8713sx" is. The binding call tell
> me that, so the value of this comment would be for you to tell us what
> it is used for on this particular board - and if that's obvious you can
> omit the comment.
Yes, removed it.
> > + compatible = "lontium,lt8713sx";
> > + reg = <0x4f>;
> > + reset-gpios = <&expander5 6 GPIO_ACTIVE_HIGH>;
>
> In addition to using an of_graph to describe the connectors that this is
> wired to, it would be nice to have a port describing the relationship to
> the DP controller here as well - so we know where the signal is coming
> from.
>
> Would that be possible to add?
Yes, added ports and connectors in v2.
> Regards,
> Bjorn
>
> > + };
> > +};
> > +
> > &i2c1 {
> > pinctrl-0 = <&qup_i2c1_default>;
> > pinctrl-names = "default";
> > @@ -396,6 +410,23 @@ expander6: gpio@3e {
> > };
> > };
> >
> > +&mdss {
> > + status = "okay";
> > +};
> > +
> > +&mdss_dp0 {
> > + status = "okay";
> > +};
> > +
> > +&mdss_dp0_out {
> > + data-lanes = <0 1 2 3>;
> > + link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
> > +};
> > +
> > +&mdss_dp0_phy {
> > + status = "okay";
> > +};
> > +
> > &iris {
> > status = "okay";
> > };
> > @@ -435,6 +466,12 @@ &serdes0 {
> > };
> >
> > &tlmm {
> > + dp_hot_plug_det: dp-hot-plug-det-state {
> > + pins = "gpio94";
> > + function = "edp0_hot";
> > + bias-disable;
> > + };
> > +
> > ethernet0_default: ethernet0-default-state {
> > ethernet0_mdc: ethernet0-mdc-pins {
> > pins = "gpio5";
> > @@ -451,6 +488,13 @@ ethernet0_mdio: ethernet0-mdio-pins {
> > };
> > };
> >
> > + qup_i2c0_default: qup-i2c0-state {
> > + pins = "gpio17", "gpio18";
> > + function = "qup0_se0";
> > + drive-strength = <2>;
> > + bias-pull-up;
> > + };
> > +
> > qup_i2c1_default: qup-i2c1-state {
> > pins = "gpio19", "gpio20";
> > function = "qup0_se1";
> >
> > --
> > 2.34.1
> >
On 11/20/25 11:58 AM, Vishnu Saini wrote:
> Monaco-evk has LT8713sx which act as DP to 3 DP output
> converter. Edp PHY from monaco soc is connected to lt8713sx
> as input and output of lt8713sx is connected to 3 mini DP ports.
> Two of these ports are available in mainboard and one port
> is available on Mezz board. lt8713sx is connected to soc over
> i2c0 and with reset gpio connected to pin6 or ioexpander5.
>
> Enable the edp nodes from monaco and enable lontium lt8713sx
> bridge node.
>
> Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> ---
[...]
> +&i2c0 {
> + pinctrl-0 = <&qup_i2c0_default>;
> + pinctrl-names = "default";
> +
> + status = "okay";
> +
> + lt8713sx: lt8713sx@4f {
Node names should be generic, so bridge@4f
> + /*Display bridge chip, DP1.4/HDMI2.0/DP++ hub*/
Comment start/stop markers should have a space after/before them
respectively, however I'm not sure this comment is useful given the
dt-bindings already describe what it is
[...]
> &tlmm {
> + dp_hot_plug_det: dp-hot-plug-det-state {
> + pins = "gpio94";
> + function = "edp0_hot";
> + bias-disable;
This is an SoC-mandated function on the pin, so please move it to
monaco.dtsi
> + };
> +
> ethernet0_default: ethernet0-default-state {
> ethernet0_mdc: ethernet0-mdc-pins {
> pins = "gpio5";
> @@ -451,6 +488,13 @@ ethernet0_mdio: ethernet0-mdio-pins {
> };
> };
>
> + qup_i2c0_default: qup-i2c0-state {
> + pins = "gpio17", "gpio18";
> + function = "qup0_se0";
> + drive-strength = <2>;
> + bias-pull-up;
Similarly, you can move these settings to monaco.dtsi and keep them as
defaults since 99.99% of I2C users will share them
Konrad
On Thu, Nov 20, 2025 at 01:11:00PM +0100, Konrad Dybcio wrote:
> On 11/20/25 11:58 AM, Vishnu Saini wrote:
> > Monaco-evk has LT8713sx which act as DP to 3 DP output
> > converter. Edp PHY from monaco soc is connected to lt8713sx
> > as input and output of lt8713sx is connected to 3 mini DP ports.
> > Two of these ports are available in mainboard and one port
> > is available on Mezz board. lt8713sx is connected to soc over
> > i2c0 and with reset gpio connected to pin6 or ioexpander5.
> >
> > Enable the edp nodes from monaco and enable lontium lt8713sx
> > bridge node.
> >
> > Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> > ---
>
> [...]
>
> > +&i2c0 {
> > + pinctrl-0 = <&qup_i2c0_default>;
> > + pinctrl-names = "default";
> > +
> > + status = "okay";
> > +
> > + lt8713sx: lt8713sx@4f {
>
> Node names should be generic, so bridge@4f
Yes, done in V2.
> > + /*Display bridge chip, DP1.4/HDMI2.0/DP++ hub*/
>
> Comment start/stop markers should have a space after/before them
> respectively, however I'm not sure this comment is useful given the
> dt-bindings already describe what it is
>
Removed this comment in V2.
> [...]
>
> > &tlmm {
> > + dp_hot_plug_det: dp-hot-plug-det-state {
> > + pins = "gpio94";
> > + function = "edp0_hot";
> > + bias-disable;
>
> This is an SoC-mandated function on the pin, so please move it to
> monaco.dtsi
Yes, done in V2.
>
> > + };
> > +
> > ethernet0_default: ethernet0-default-state {
> > ethernet0_mdc: ethernet0-mdc-pins {
> > pins = "gpio5";
> > @@ -451,6 +488,13 @@ ethernet0_mdio: ethernet0-mdio-pins {
> > };
> > };
> >
> > + qup_i2c0_default: qup-i2c0-state {
> > + pins = "gpio17", "gpio18";
> > + function = "qup0_se0";
> > + drive-strength = <2>;
> > + bias-pull-up;
>
> Similarly, you can move these settings to monaco.dtsi and keep them as
> defaults since 99.99% of I2C users will share them
Is it ok if i update this in a different series, similar other nodes like qup_i2c1_default
added in monaco-evk.dts?
> Konrad
On 12/19/25 12:20 PM, Vishnu Saini wrote:
> On Thu, Nov 20, 2025 at 01:11:00PM +0100, Konrad Dybcio wrote:
>> On 11/20/25 11:58 AM, Vishnu Saini wrote:
>>> Monaco-evk has LT8713sx which act as DP to 3 DP output
>>> converter. Edp PHY from monaco soc is connected to lt8713sx
>>> as input and output of lt8713sx is connected to 3 mini DP ports.
>>> Two of these ports are available in mainboard and one port
>>> is available on Mezz board. lt8713sx is connected to soc over
>>> i2c0 and with reset gpio connected to pin6 or ioexpander5.
>>>
>>> Enable the edp nodes from monaco and enable lontium lt8713sx
>>> bridge node.
>>>
>>> Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
>>> Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
>>> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
>>> ---
[...]
>>> + qup_i2c0_default: qup-i2c0-state {
>>> + pins = "gpio17", "gpio18";
>>> + function = "qup0_se0";
>>> + drive-strength = <2>;
>>> + bias-pull-up;
>>
>> Similarly, you can move these settings to monaco.dtsi and keep them as
>> defaults since 99.99% of I2C users will share them
> Is it ok if i update this in a different series, similar other nodes like qup_i2c1_default
> added in monaco-evk.dts?
No, I don't want you to introduce something "wrong" only because you
don't want to run git commit --amend
I see you've now sent a v2 just 7 minutes after asking this question.
Should I interpret that as you expecting me to drop everything and rush
to respond to your queries immediately, or do you not care about my
feedback anyway?
Konrad
On Fri, Dec 19, 2025 at 01:10:19PM +0100, Konrad Dybcio wrote:
> On 12/19/25 12:20 PM, Vishnu Saini wrote:
> > On Thu, Nov 20, 2025 at 01:11:00PM +0100, Konrad Dybcio wrote:
> >> On 11/20/25 11:58 AM, Vishnu Saini wrote:
> >>> Monaco-evk has LT8713sx which act as DP to 3 DP output
> >>> converter. Edp PHY from monaco soc is connected to lt8713sx
> >>> as input and output of lt8713sx is connected to 3 mini DP ports.
> >>> Two of these ports are available in mainboard and one port
> >>> is available on Mezz board. lt8713sx is connected to soc over
> >>> i2c0 and with reset gpio connected to pin6 or ioexpander5.
> >>>
> >>> Enable the edp nodes from monaco and enable lontium lt8713sx
> >>> bridge node.
> >>>
> >>> Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> >>> Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> >>> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> >>> ---
>
> [...]
>
> >>> + qup_i2c0_default: qup-i2c0-state {
> >>> + pins = "gpio17", "gpio18";
> >>> + function = "qup0_se0";
> >>> + drive-strength = <2>;
> >>> + bias-pull-up;
> >>
> >> Similarly, you can move these settings to monaco.dtsi and keep them as
> >> defaults since 99.99% of I2C users will share them
> > Is it ok if i update this in a different series, similar other nodes like qup_i2c1_default
> > added in monaco-evk.dts?
>
> No, I don't want you to introduce something "wrong" only because you
> don't want to run git commit --amend
>
> I see you've now sent a v2 just 7 minutes after asking this question.
> Should I interpret that as you expecting me to drop everything and rush
> to respond to your queries immediately, or do you not care about my
> feedback anyway?
Apologies, for quickly raising the new patch, i thought of correcting this
in next V3 patch if you ask for.
I am new contributor to the upstream community, just now i setup mutt and learned a bit about
sending reply to the emails and V2 patch was already validated that's why i submitted it.
monaco.dtsi already have below node except drive-strength and bias-pull-up.
tlmm {
qup_i2c0_data_clk: qup-i2c0-data-clk-state {
pins = "gpio17", "gpio18";
function = "qup0_se0";
};
};
I will add drive-strength and bias-pull-up in monaco-evk.dts, let me know if this is ok?
> Konrad
On 12/19/25 1:59 PM, Vishnu Saini wrote:
> On Fri, Dec 19, 2025 at 01:10:19PM +0100, Konrad Dybcio wrote:
>> On 12/19/25 12:20 PM, Vishnu Saini wrote:
>>> On Thu, Nov 20, 2025 at 01:11:00PM +0100, Konrad Dybcio wrote:
>>>> On 11/20/25 11:58 AM, Vishnu Saini wrote:
>>>>> Monaco-evk has LT8713sx which act as DP to 3 DP output
>>>>> converter. Edp PHY from monaco soc is connected to lt8713sx
>>>>> as input and output of lt8713sx is connected to 3 mini DP ports.
>>>>> Two of these ports are available in mainboard and one port
>>>>> is available on Mezz board. lt8713sx is connected to soc over
>>>>> i2c0 and with reset gpio connected to pin6 or ioexpander5.
>>>>>
>>>>> Enable the edp nodes from monaco and enable lontium lt8713sx
>>>>> bridge node.
>>>>>
>>>>> Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
>>>>> Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
>>>>> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
>>>>> ---
>>
>> [...]
>>
>>>>> + qup_i2c0_default: qup-i2c0-state {
>>>>> + pins = "gpio17", "gpio18";
>>>>> + function = "qup0_se0";
>>>>> + drive-strength = <2>;
>>>>> + bias-pull-up;
>>>>
>>>> Similarly, you can move these settings to monaco.dtsi and keep them as
>>>> defaults since 99.99% of I2C users will share them
>>> Is it ok if i update this in a different series, similar other nodes like qup_i2c1_default
>>> added in monaco-evk.dts?
>>
>> No, I don't want you to introduce something "wrong" only because you
>> don't want to run git commit --amend
>>
>> I see you've now sent a v2 just 7 minutes after asking this question.
>> Should I interpret that as you expecting me to drop everything and rush
>> to respond to your queries immediately, or do you not care about my
>> feedback anyway?
> Apologies, for quickly raising the new patch, i thought of correcting this
> in next V3 patch if you ask for.
> I am new contributor to the upstream community, just now i setup mutt and learned a bit about
> sending reply to the emails and V2 patch was already validated that's why i submitted it.
It's okay. Just please try not to do it again - it's really an anti-pattern.
> monaco.dtsi already have below node except drive-strength and bias-pull-up.
> tlmm {
> qup_i2c0_data_clk: qup-i2c0-data-clk-state {
> pins = "gpio17", "gpio18";
> function = "qup0_se0";
> };
> };
> I will add drive-strength and bias-pull-up in monaco-evk.dts, let me know if this is ok?
That should be fine. Other SoC DTSIs do that already
Konrad
© 2016 - 2026 Red Hat, Inc.