Hi,

the driver is in a bad shape -- this is a minimal cleanup, so that it is
more or less readable.

Jiri Slaby (SUSE) (6):
  char/mwave: remove dead code
  char/mwave: remove MWAVE_FUTZ_WITH_OTHER_DEVICES ifdeffery
  char/mwave: remove unneeded fops
  char/mwave: remove printk tracing
  char/mwave: drop printk wrapper
  char/mwave: drop typedefs

 drivers/char/mwave/3780i.c    | 218 +---------------------
 drivers/char/mwave/3780i.h    |  12 +-
 drivers/char/mwave/Makefile   |   6 -
 drivers/char/mwave/README     |  10 -
 drivers/char/mwave/mwavedd.c  | 337 ++++------------------------------
 drivers/char/mwave/mwavedd.h  |  76 +-------
 drivers/char/mwave/mwavepub.h |  22 +--
 drivers/char/mwave/smapi.c    | 244 ++++--------------------
 drivers/char/mwave/smapi.h    |   6 +-
 drivers/char/mwave/tp3780i.c  | 209 ++++++---------------
 drivers/char/mwave/tp3780i.h  |  30 +--
 11 files changed, 177 insertions(+), 993 deletions(-)

-- 
2.51.1

On Wed, Nov 19, 2025, at 10:19, Jiri Slaby (SUSE) wrote:
> Hi,
>
> the driver is in a bad shape -- this is a minimal cleanup, so that it is
> more or less readable.
>
> Jiri Slaby (SUSE) (6):
>   char/mwave: remove dead code
>   char/mwave: remove MWAVE_FUTZ_WITH_OTHER_DEVICES ifdeffery
>   char/mwave: remove unneeded fops
>   char/mwave: remove printk tracing
>   char/mwave: drop printk wrapper
>   char/mwave: drop typedefs

The cleanups all look good to me,

Acked-by: Arnd Bergmann <arnd@arndb.de>

I assume you are not actually trying to use this driver, right?
According to thinkwiki.de, the 3780i modem was only used in a
couple of Thinkpad models that are now over 25 years old, using
Pentium II processors, and they all have a physical RS232 port
that can be used to connect an external modem instead.

Maybe we can just retire this driver?

     Arnd