arch/x86/events/intel/uncore.c | 2 -- 1 file changed, 2 deletions(-)
pmu cannot be NULL as is taken as a pointer to an array. Remove the
superfluous NULL check.
Found by Coverity: CID#1497507.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
---
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: "Liang, Kan" <kan.liang@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
Cc: linux-perf-users@vger.kernel.org
---
arch/x86/events/intel/uncore.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/events/intel/uncore.c b/arch/x86/events/intel/uncore.c
index d6c945cc5d07..e228e564b15e 100644
--- a/arch/x86/events/intel/uncore.c
+++ b/arch/x86/events/intel/uncore.c
@@ -1325,8 +1325,6 @@ static void uncore_pci_sub_driver_init(void)
continue;
pmu = &type->pmus[UNCORE_PCI_DEV_IDX(ids->driver_data)];
- if (!pmu)
- continue;
if (uncore_pci_get_dev_die_info(pci_sub_dev, &die))
continue;
--
2.51.1On 11/19/2025 5:15 PM, Jiri Slaby (SUSE) wrote: > pmu cannot be NULL as is taken as a pointer to an array. Remove the > superfluous NULL check. > > Found by Coverity: CID#1497507. > > Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> > --- > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Arnaldo Carvalho de Melo <acme@kernel.org> > Cc: Namhyung Kim <namhyung@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> > Cc: Jiri Olsa <jolsa@kernel.org> > Cc: Ian Rogers <irogers@google.com> > Cc: Adrian Hunter <adrian.hunter@intel.com> > Cc: "Liang, Kan" <kan.liang@linux.intel.com> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Borislav Petkov <bp@alien8.de> > Cc: Dave Hansen <dave.hansen@linux.intel.com> > Cc: "H. Peter Anvin" <hpa@zytor.com> > Cc: x86@kernel.org > Cc: linux-perf-users@vger.kernel.org > --- > arch/x86/events/intel/uncore.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/x86/events/intel/uncore.c b/arch/x86/events/intel/uncore.c > index d6c945cc5d07..e228e564b15e 100644 > --- a/arch/x86/events/intel/uncore.c > +++ b/arch/x86/events/intel/uncore.c > @@ -1325,8 +1325,6 @@ static void uncore_pci_sub_driver_init(void) > continue; > > pmu = &type->pmus[UNCORE_PCI_DEV_IDX(ids->driver_data)]; > - if (!pmu) > - continue; > > if (uncore_pci_get_dev_die_info(pci_sub_dev, &die)) > continue; LGTM. Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
On Wed, Nov 19, 2025 at 2:25 AM Mi, Dapeng <dapeng1.mi@linux.intel.com> wrote: > > > On 11/19/2025 5:15 PM, Jiri Slaby (SUSE) wrote: > > pmu cannot be NULL as is taken as a pointer to an array. Remove the > > superfluous NULL check. > > > > Found by Coverity: CID#1497507. > > > > Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> > > --- > > Cc: Peter Zijlstra <peterz@infradead.org> > > Cc: Ingo Molnar <mingo@redhat.com> > > Cc: Arnaldo Carvalho de Melo <acme@kernel.org> > > Cc: Namhyung Kim <namhyung@kernel.org> > > Cc: Mark Rutland <mark.rutland@arm.com> > > Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> > > Cc: Jiri Olsa <jolsa@kernel.org> > > Cc: Ian Rogers <irogers@google.com> > > Cc: Adrian Hunter <adrian.hunter@intel.com> > > Cc: "Liang, Kan" <kan.liang@linux.intel.com> > > Cc: Thomas Gleixner <tglx@linutronix.de> > > Cc: Borislav Petkov <bp@alien8.de> > > Cc: Dave Hansen <dave.hansen@linux.intel.com> > > Cc: "H. Peter Anvin" <hpa@zytor.com> > > Cc: x86@kernel.org > > Cc: linux-perf-users@vger.kernel.org > > --- > > arch/x86/events/intel/uncore.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/arch/x86/events/intel/uncore.c b/arch/x86/events/intel/uncore.c > > index d6c945cc5d07..e228e564b15e 100644 > > --- a/arch/x86/events/intel/uncore.c > > +++ b/arch/x86/events/intel/uncore.c > > @@ -1325,8 +1325,6 @@ static void uncore_pci_sub_driver_init(void) > > continue; > > > > pmu = &type->pmus[UNCORE_PCI_DEV_IDX(ids->driver_data)]; > > - if (!pmu) > > - continue; > > > > if (uncore_pci_get_dev_die_info(pci_sub_dev, &die)) > > continue; > > LGTM. > > Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com> Reviewed-by: Ian Rogers <irogers@google.com> Thanks, Ian
The following commit has been merged into the perf/urgent branch of tip:
Commit-ID: a24074ca8840cf28fa50c40e957fdc50f29971b3
Gitweb: https://git.kernel.org/tip/a24074ca8840cf28fa50c40e957fdc50f29971b3
Author: Jiri Slaby (SUSE) <jirislaby@kernel.org>
AuthorDate: Wed, 19 Nov 2025 10:15:38 +01:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Wed, 19 Nov 2025 10:26:31 +01:00
perf/x86/intel/uncore: Remove superfluous check
The 'pmu' pointer cannot be NULL, as it is taken as a pointer to an array.
Remove the superfluous NULL check.
Found by Coverity: CID#1497507.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Liang Kan <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://patch.msgid.link/20251119091538.825307-1-jirislaby@kernel.org
---
arch/x86/events/intel/uncore.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/events/intel/uncore.c b/arch/x86/events/intel/uncore.c
index d6c945c..e228e56 100644
--- a/arch/x86/events/intel/uncore.c
+++ b/arch/x86/events/intel/uncore.c
@@ -1325,8 +1325,6 @@ static void uncore_pci_sub_driver_init(void)
continue;
pmu = &type->pmus[UNCORE_PCI_DEV_IDX(ids->driver_data)];
- if (!pmu)
- continue;
if (uncore_pci_get_dev_die_info(pci_sub_dev, &die))
continue;© 2016 - 2025 Red Hat, Inc.