[PATCH net-next v2] r8169: add support for RTL9151A

javen posted 1 patch 1 week, 5 days ago
There is a newer version of this series
drivers/net/ethernet/realtek/r8169_main.c | 3 +++
1 file changed, 3 insertions(+)
[PATCH net-next v2] r8169: add support for RTL9151A
Posted by javen 1 week, 5 days ago
This adds support for chip RTL9151A. Its XID is 0x68b. It is bascially
basd on the one with XID 0x688, but with different firmware file.

Signed-off-by: javen <javen_xu@realsil.com.cn>

---
v2: Rebase to master, no content changes.
---
 drivers/net/ethernet/realtek/r8169_main.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index d18734fe12e4..dfc824326b16 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -58,6 +58,7 @@
 #define FIRMWARE_8125D_1	"rtl_nic/rtl8125d-1.fw"
 #define FIRMWARE_8125D_2	"rtl_nic/rtl8125d-2.fw"
 #define FIRMWARE_8125BP_2	"rtl_nic/rtl8125bp-2.fw"
+#define FIRMWARE_9151A_1	"rtl_nic/rtl9151a-1.fw"
 #define FIRMWARE_8126A_2	"rtl_nic/rtl8126a-2.fw"
 #define FIRMWARE_8126A_3	"rtl_nic/rtl8126a-3.fw"
 #define FIRMWARE_8127A_1	"rtl_nic/rtl8127a-1.fw"
@@ -110,6 +111,7 @@ static const struct rtl_chip_info {
 	{ 0x7cf, 0x681,	RTL_GIGA_MAC_VER_66, "RTL8125BP", FIRMWARE_8125BP_2 },
 
 	/* 8125D family. */
+	{ 0x7cf, 0x68b, RTL_GIGA_MAC_VER_64, "RTL9151A", FIRMWARE_9151A_1 },
 	{ 0x7cf, 0x689,	RTL_GIGA_MAC_VER_64, "RTL8125D", FIRMWARE_8125D_2 },
 	{ 0x7cf, 0x688,	RTL_GIGA_MAC_VER_64, "RTL8125D", FIRMWARE_8125D_1 },
 
@@ -771,6 +773,7 @@ MODULE_FIRMWARE(FIRMWARE_8125B_2);
 MODULE_FIRMWARE(FIRMWARE_8125D_1);
 MODULE_FIRMWARE(FIRMWARE_8125D_2);
 MODULE_FIRMWARE(FIRMWARE_8125BP_2);
+MODULE_FIRMWARE(FIRMWARE_9151A_1);
 MODULE_FIRMWARE(FIRMWARE_8126A_2);
 MODULE_FIRMWARE(FIRMWARE_8126A_3);
 MODULE_FIRMWARE(FIRMWARE_8127A_1);
-- 
2.43.0
Re: [PATCH net-next v2] r8169: add support for RTL9151A
Posted by Jakub Kicinski 1 week, 4 days ago
On Wed, 19 Nov 2025 10:32:16 +0800 javen wrote:
> This adds support for chip RTL9151A. Its XID is 0x68b. It is bascially
> basd on the one with XID 0x688, but with different firmware file.
> 
> Signed-off-by: javen <javen_xu@realsil.com.cn>

Presumably your fuller name is javen xu? Please include all the parts.

The patch does not apply, please rebase on net-next.
-- 
pw-bot: c
Re: [PATCH net-next v2] r8169: add support for RTL9151A
Posted by Heiner Kallweit 1 week, 5 days ago
On 11/19/2025 3:32 AM, javen wrote:
> This adds support for chip RTL9151A. Its XID is 0x68b. It is bascially
> basd on the one with XID 0x688, but with different firmware file.
> 
> Signed-off-by: javen <javen_xu@realsil.com.cn>
> 
> ---
> v2: Rebase to master, no content changes.
> ---


Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>

For my understanding:
Any specific reason for the different version number scheme?
RE: [PATCH net-next v2] r8169: add support for RTL9151A
Posted by Hau 1 week, 5 days ago

> -----Original Message-----
> From: Heiner Kallweit [mailto:hkallweit1@gmail.com]
> Sent: Wednesday, November 19, 2025 2:37 PM
> To: javen_xu@realsil.com.cn; nic_swsd <nic_swsd@realtek.com>;
> andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com; horms@kernel.org
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next v2] r8169: add support for RTL9151A
> 
> 
> External mail : This email originated from outside the organization. Do not
> reply, click links, or open attachments unless you recognize the sender and
> know the content is safe.
> 
> 
> 
> On 11/19/2025 3:32 AM, javen wrote:
> > This adds support for chip RTL9151A. Its XID is 0x68b. It is bascially
> > basd on the one with XID 0x688, but with different firmware file.
> >
> > Signed-off-by: javen <javen_xu@realsil.com.cn>
> >
> > ---
> > v2: Rebase to master, no content changes.
> > ---
> 
> 
> Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
> 
> For my understanding:
> Any specific reason for the different version number scheme?

Unlike RTL8125d, it is a multi-function device. The LAN function in on function 2.
That is why it has a new xid.