[PATCH v3 1/2] dt-bindings: leds: qcom-lpg: Explain standalone PWM usage

Fenglin Wu via B4 Relay posted 2 patches 1 week, 5 days ago
[PATCH v3 1/2] dt-bindings: leds: qcom-lpg: Explain standalone PWM usage
Posted by Fenglin Wu via B4 Relay 1 week, 5 days ago
From: Fenglin Wu <fenglin.wu@oss.qualcomm.com>

LPG channels can be used for only outputting PWM signals by routing to
PMIC GPIOs without enabling TRILED. Explain this usage in the description
for better clarity.

Signed-off-by: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
index 841a0229c472a4764426d25d9dbb900adc20fc11..c4b7e57b251845a6970b34bc9ae0c00647b1bf96 100644
--- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
@@ -13,6 +13,11 @@ description: >
   The Qualcomm Light Pulse Generator consists of three different hardware blocks;
   a ramp generator with lookup table (LUT), the light pulse generator and a three
   channel current sink. These blocks are found in a wide range of Qualcomm PMICs.
+  The light pulse generator (LPG) can also be used independently to output PWM
+  signal for standard PWM applications. In this scenario, the LPG output should
+  be routed to a specific PMIC GPIO by setting the GPIO pin mux to the special
+  functions indicated in the datasheet, the TRILED driver for the channel will
+  not be enabled in this configuration.
 
 properties:
   compatible:

-- 
2.34.1
Re: [PATCH v3 1/2] dt-bindings: leds: qcom-lpg: Explain standalone PWM usage
Posted by Rob Herring 1 week, 4 days ago
On Wed, Nov 19, 2025 at 02:06:42PM +0800, Fenglin Wu wrote:
> LPG channels can be used for only outputting PWM signals by routing to
> PMIC GPIOs without enabling TRILED. Explain this usage in the description
> for better clarity.
> 
> Signed-off-by: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> index 841a0229c472a4764426d25d9dbb900adc20fc11..c4b7e57b251845a6970b34bc9ae0c00647b1bf96 100644
> --- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> @@ -13,6 +13,11 @@ description: >
>    The Qualcomm Light Pulse Generator consists of three different hardware blocks;
>    a ramp generator with lookup table (LUT), the light pulse generator and a three
>    channel current sink. These blocks are found in a wide range of Qualcomm PMICs.
> +  The light pulse generator (LPG) can also be used independently to output PWM

Is this a separate paragraph or the same paragraph? The former needs a 
blank line.

Acked-by: Rob Herring (Arm) <robh@kernel.org>

> +  signal for standard PWM applications. In this scenario, the LPG output should
> +  be routed to a specific PMIC GPIO by setting the GPIO pin mux to the special
> +  functions indicated in the datasheet, the TRILED driver for the channel will
> +  not be enabled in this configuration.
>  
>  properties:
>    compatible:
> 
> -- 
> 2.34.1
>
Re: [PATCH v3 1/2] dt-bindings: leds: qcom-lpg: Explain standalone PWM usage
Posted by Bjorn Andersson 1 week, 5 days ago
On Wed, Nov 19, 2025 at 02:06:42PM +0800, Fenglin Wu via B4 Relay wrote:
> From: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
> 
> LPG channels can be used for only outputting PWM signals by routing to
> PMIC GPIOs without enabling TRILED. Explain this usage in the description
> for better clarity.
> 

Reviewed-by: Bjorn Andersson <andersson@kernel.org>

> Signed-off-by: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> index 841a0229c472a4764426d25d9dbb900adc20fc11..c4b7e57b251845a6970b34bc9ae0c00647b1bf96 100644
> --- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> @@ -13,6 +13,11 @@ description: >
>    The Qualcomm Light Pulse Generator consists of three different hardware blocks;
>    a ramp generator with lookup table (LUT), the light pulse generator and a three
>    channel current sink. These blocks are found in a wide range of Qualcomm PMICs.
> +  The light pulse generator (LPG) can also be used independently to output PWM
> +  signal for standard PWM applications. In this scenario, the LPG output should
> +  be routed to a specific PMIC GPIO by setting the GPIO pin mux to the special
> +  functions indicated in the datasheet, the TRILED driver for the channel will
> +  not be enabled in this configuration.
>  
>  properties:
>    compatible:
> 
> -- 
> 2.34.1
> 
>