[PATCH 1/3] dt-bindings: i2c: spacemit: add optional resets

Encrow Thorne posted 3 patches 1 week, 5 days ago
[PATCH 1/3] dt-bindings: i2c: spacemit: add optional resets
Posted by Encrow Thorne 1 week, 5 days ago
Add optional reset property for the SpacemiT K1 I2C.

Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
---
 Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml b/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
index b7220fff2235..3d4faec41abe 100644
--- a/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
@@ -27,6 +27,9 @@ properties:
       - description: I2C Functional Clock
       - description: APB Bus Clock
 
+  resets:
+    maxItems: 1
+
   clock-names:
     items:
       - const: func

-- 
2.25.1
Re: [PATCH 1/3] dt-bindings: i2c: spacemit: add optional resets
Posted by Krzysztof Kozlowski 1 week, 4 days ago
On Wed, Nov 19, 2025 at 07:46:43PM +0800, Encrow Thorne wrote:
> Add optional reset property for the SpacemiT K1 I2C.

Why? You just repeated diff and we can read the diff. Please explain WHY
you are doing things in terms of hardware.

> 
> Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
> ---
>  Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml b/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> index b7220fff2235..3d4faec41abe 100644
> --- a/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> @@ -27,6 +27,9 @@ properties:
>        - description: I2C Functional Clock
>        - description: APB Bus Clock
>  
> +  resets:
> +    maxItems: 1
> +

Completely misplaced. There are never random properties between xxx and
xxx-names.

Best regards,
Krzysztof
Re: [PATCH 1/3] dt-bindings: i2c: spacemit: add optional resets
Posted by Troy Mitchell 1 week, 5 days ago
On Wed, Nov 19, 2025 at 07:46:43PM +0800, Encrow Thorne wrote:
> Add optional reset property for the SpacemiT K1 I2C.
> 
> Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
>
Thanks.

Acked-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>