[PATCH 03/26] drm/todo: add entry about converting to drm_of_find_bridge()

Luca Ceresoli posted 26 patches 1 week, 5 days ago
There is a newer version of this series
[PATCH 03/26] drm/todo: add entry about converting to drm_of_find_bridge()
Posted by Luca Ceresoli 1 week, 5 days ago
of_drm_find_bridge() is deprecated, but converting some users is very
complex and should be reasonably doable only after the DRM panel bridge
lifetime rework. Add a TODO to track this.

Suggested-by: Maxime Ripard <mripard@kernel.org>
Link: https://lore.kernel.org/dri-devel/20250319-stylish-lime-mongoose-0a18ad@houat/
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
 Documentation/gpu/todo.rst | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index 9013ced318cb..1a4a11dee036 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -506,6 +506,22 @@ Contact: Maxime Ripard <mripard@kernel.org>,
 
 Level: Intermediate
 
+Convert users of of_drm_find_bridge() to drm_of_find_bridge()
+-------------------------------------------------------------
+
+Taking a struct drm_bridge pointer requires getting a reference and putting
+it after disposing of the pointer. Most functions returning a struct
+drm_bridge pointer already call drm_bridge_get() to increment the refcount
+and their users have been updated to call drm_bridge_put() when
+appropriate. of_drm_find_bridge() does not get a reference and it has been
+deprecated in favor of drm_of_find_bridge() which does, but some users
+still need to be converted.
+
+Contact: Maxime Ripard <mripard@kernel.org>,
+         Luca Ceresoli <luca.ceresoli@bootlin.com>
+
+Level: Intermediate
+
 Core refactorings
 =================
 

-- 
2.51.1
Re: [PATCH 03/26] drm/todo: add entry about converting to drm_of_find_bridge()
Posted by Maxime Ripard 1 week ago
On Wed, Nov 19, 2025 at 02:05:34PM +0100, Luca Ceresoli wrote:
> of_drm_find_bridge() is deprecated, but converting some users is very
> complex and should be reasonably doable only after the DRM panel bridge
> lifetime rework. Add a TODO to track this.
> 
> Suggested-by: Maxime Ripard <mripard@kernel.org>
> Link: https://lore.kernel.org/dri-devel/20250319-stylish-lime-mongoose-0a18ad@houat/
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
>  Documentation/gpu/todo.rst | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index 9013ced318cb..1a4a11dee036 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -506,6 +506,22 @@ Contact: Maxime Ripard <mripard@kernel.org>,
>  
>  Level: Intermediate
>  
> +Convert users of of_drm_find_bridge() to drm_of_find_bridge()
> +-------------------------------------------------------------
> +
> +Taking a struct drm_bridge pointer requires getting a reference and putting
> +it after disposing of the pointer. Most functions returning a struct
> +drm_bridge pointer already call drm_bridge_get() to increment the refcount
> +and their users have been updated to call drm_bridge_put() when
> +appropriate. of_drm_find_bridge() does not get a reference and it has been
> +deprecated in favor of drm_of_find_bridge() which does, but some users
> +still need to be converted.
> +
> +Contact: Maxime Ripard <mripard@kernel.org>,
> +         Luca Ceresoli <luca.ceresoli@bootlin.com>
> +
> +Level: Intermediate
> +

My understanding is that there's no users left after this series, so do
we really need a todo?

Maxime