test_kho: always print restore status

[PATCH] test_kho: always print restore status

Posted by Pratyush Yadav 1 week, 6 days ago

Currently the KHO test only prints a message on success, and remains
silent on failure. This makes it difficult to notice a failing test. A
failing test is usually more interesting than a successful one.

Always print the test status after attempting restore.

Signed-off-by: Pratyush Yadav <pratyush@kernel.org>
---
 lib/test_kho.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/lib/test_kho.c b/lib/test_kho.c
index 85b60d87a50ad..47de562807955 100644
--- a/lib/test_kho.c
+++ b/lib/test_kho.c
@@ -306,7 +306,6 @@ static int kho_test_restore(phys_addr_t fdt_phys)
 	if (err)
 		return err;
 
-	pr_info("KHO restore succeeded\n");
 	return 0;
 }
 
@@ -319,8 +318,15 @@ static int __init kho_test_init(void)
 		return 0;
 
 	err = kho_retrieve_subtree(KHO_TEST_FDT, &fdt_phys);
-	if (!err)
-		return kho_test_restore(fdt_phys);
+	if (!err) {
+		err = kho_test_restore(fdt_phys);
+		if (err)
+			pr_err("KHO restore failed\n");
+		else
+			pr_info("KHO restore succeeded\n");
+
+		return err;
+	}
 
 	if (err != -ENOENT) {
 		pr_warn("failed to retrieve %s FDT: %d\n", KHO_TEST_FDT, err);

base-commit: f0bfdc2b69f5c600b88ee484c01b213712c63d94
-- 
2.47.3

Re: [PATCH] test_kho: always print restore status

Posted by SeongJae Park 1 week, 5 days ago

On Tue, 18 Nov 2025 19:10:45 +0100 Pratyush Yadav <pratyush@kernel.org> wrote:

> Currently the KHO test only prints a message on success, and remains
> silent on failure. This makes it difficult to notice a failing test. A
> failing test is usually more interesting than a successful one.
> 
> Always print the test status after attempting restore.
> 
> Signed-off-by: Pratyush Yadav <pratyush@kernel.org>

Acked-by: SeongJae Park <sj@kerneel.org>


Thanks,
SJ

[...]

Re: [PATCH] test_kho: always print restore status

Posted by Mike Rapoport 1 week, 5 days ago

On Tue, Nov 18, 2025 at 07:10:45PM +0100, Pratyush Yadav wrote:
> Currently the KHO test only prints a message on success, and remains
> silent on failure. This makes it difficult to notice a failing test. A
> failing test is usually more interesting than a successful one.
> 
> Always print the test status after attempting restore.
> 
> Signed-off-by: Pratyush Yadav <pratyush@kernel.org>

Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>

> ---
>  lib/test_kho.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/test_kho.c b/lib/test_kho.c
> index 85b60d87a50ad..47de562807955 100644
> --- a/lib/test_kho.c
> +++ b/lib/test_kho.c
> @@ -306,7 +306,6 @@ static int kho_test_restore(phys_addr_t fdt_phys)
>  	if (err)
>  		return err;
>  
> -	pr_info("KHO restore succeeded\n");
>  	return 0;
>  }
>  
> @@ -319,8 +318,15 @@ static int __init kho_test_init(void)
>  		return 0;
>  
>  	err = kho_retrieve_subtree(KHO_TEST_FDT, &fdt_phys);
> -	if (!err)
> -		return kho_test_restore(fdt_phys);
> +	if (!err) {
> +		err = kho_test_restore(fdt_phys);
> +		if (err)
> +			pr_err("KHO restore failed\n");
> +		else
> +			pr_info("KHO restore succeeded\n");
> +
> +		return err;
> +	}
>  
>  	if (err != -ENOENT) {
>  		pr_warn("failed to retrieve %s FDT: %d\n", KHO_TEST_FDT, err);
> 
> base-commit: f0bfdc2b69f5c600b88ee484c01b213712c63d94
> -- 
> 2.47.3
> 

-- 
Sincerely yours,
Mike.

Re: [PATCH] test_kho: always print restore status

Posted by Pasha Tatashin 1 week, 6 days ago

On Tue, Nov 18, 2025 at 1:10 PM Pratyush Yadav <pratyush@kernel.org> wrote:
>
> Currently the KHO test only prints a message on success, and remains
> silent on failure. This makes it difficult to notice a failing test. A
> failing test is usually more interesting than a successful one.
>
> Always print the test status after attempting restore.
>
> Signed-off-by: Pratyush Yadav <pratyush@kernel.org>

Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>