arm64: dts: ti: k3-j721e-sk: Fix pinmux for power regulator

[PATCH] arm64: dts: ti: k3-j721e-sk: Fix pinmux for power regulator

Posted by Siddharth Vadapalli 1 week, 6 days ago

Commit under Fixes added support for power regulators on the J721E SK
board. However, while doing so, it incorrectly assigned a non-existent
pinmux within the WKUP Pinmux region (pinctrl@4301c000) instead of using
the MAIN Pinmux region (pinctrl@11c000). This leads to the following
silent failure:

    pinctrl-single 4301c000.pinctrl: mux offset out of range: 0x1dc (0x178)

The datasheet for the J721E SoC [0] specifies on page 142 that the
pinmux of interest which is Ball Y1 is PADCONFIG119 and the address
corresponding to it is 0x00011C1DC which belongs to the MAIN Pinmux
region.

Hence, fix this.

[0]: https://www.ti.com/lit/ds/symlink/tda4vm.pdf
Fixes: 97b67cc102dc ("arm64: dts: ti: k3-j721e-sk: Add DT nodes for power regulators")
Cc: <stable@vger.kernel.org>
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
---

Hello,

This patch is based on commit
e7c375b18160 Merge tag 'vfs-6.18-rc7.fixes' of gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs
of Mainline Linux.

Regards,
Siddharth.

 arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
index 5e5784ef6f85..77dcc160eda3 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
@@ -474,6 +474,12 @@ rpi_header_gpio1_pins_default: rpi-header-gpio1-default-pins {
 			J721E_IOPAD(0x234, PIN_INPUT, 7) /* (U3) EXT_REFCLK1.GPIO1_12 */
 		>;
 	};
+
+	vdd_sd_dv_pins_default: vdd-sd-dv-default-pins {
+		pinctrl-single,pins = <
+			J721E_IOPAD(0x1dc, PIN_OUTPUT, 7) /* (Y1) SPI1_CLK.GPIO0_118 */
+		>;
+	};
 };
 
 &wkup_pmx0 {
@@ -536,12 +542,6 @@ J721E_WKUP_IOPAD(0xd4, PIN_OUTPUT, 7) /* (G26) WKUP_GPIO0_9 */
 		>;
 	};
 
-	vdd_sd_dv_pins_default: vdd-sd-dv-default-pins {
-		pinctrl-single,pins = <
-			J721E_IOPAD(0x1dc, PIN_OUTPUT, 7) /* (Y1) SPI1_CLK.GPIO0_118 */
-		>;
-	};
-
 	wkup_uart0_pins_default: wkup-uart0-default-pins {
 		pinctrl-single,pins = <
 			J721E_WKUP_IOPAD(0xa0, PIN_INPUT, 0) /* (J29) WKUP_UART0_RXD */
-- 
2.51.1

Re: [PATCH] arm64: dts: ti: k3-j721e-sk: Fix pinmux for power regulator

Posted by Vignesh Raghavendra 1 week, 5 days ago


On 18/11/25 17:19, Siddharth Vadapalli wrote:
> Commit under Fixes added support for power regulators on the J721E SK

^^^ not the right way to quote a commit. Should follow commit SHA
("$subject") format. Moreover this paragraph can be simply be stated as
node is under wrong pmx region (wakeup) and instead should be moved to main

> board. However, while doing so, it incorrectly assigned a non-existent
> pinmux within the WKUP Pinmux region (pinctrl@4301c000) instead of using
> the MAIN Pinmux region (pinctrl@11c000). This leads to the following
> silent failure:
> 
>     pinctrl-single 4301c000.pinctrl: mux offset out of range: 0x1dc (0x178)
> 
> The datasheet for the J721E SoC [0] specifies on page 142 that the
> pinmux of interest which is Ball Y1 is PADCONFIG119 and the address
> corresponding to it is 0x00011C1DC which belongs to the MAIN Pinmux
> region.
> 
> Hence, fix this.
> 
> [0]: https://www.ti.com/lit/ds/symlink/tda4vm.pdf
> Fixes: 97b67cc102dc ("arm64: dts: ti: k3-j721e-sk: Add DT nodes for power regulators")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> ---
> 
> Hello,
> 
> This patch is based on commit
> e7c375b18160 Merge tag 'vfs-6.18-rc7.fixes' of gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs
> of Mainline Linux.
> 
> Regards,
> Siddharth.
> 
>  arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> index 5e5784ef6f85..77dcc160eda3 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> @@ -474,6 +474,12 @@ rpi_header_gpio1_pins_default: rpi-header-gpio1-default-pins {
>  			J721E_IOPAD(0x234, PIN_INPUT, 7) /* (U3) EXT_REFCLK1.GPIO1_12 */
>  		>;
>  	};
> +
> +	vdd_sd_dv_pins_default: vdd-sd-dv-default-pins {
> +		pinctrl-single,pins = <
> +			J721E_IOPAD(0x1dc, PIN_OUTPUT, 7) /* (Y1) SPI1_CLK.GPIO0_118 */
> +		>;
> +	};
>  };
>  
>  &wkup_pmx0 {
> @@ -536,12 +542,6 @@ J721E_WKUP_IOPAD(0xd4, PIN_OUTPUT, 7) /* (G26) WKUP_GPIO0_9 */
>  		>;
>  	};
>  
> -	vdd_sd_dv_pins_default: vdd-sd-dv-default-pins {
> -		pinctrl-single,pins = <
> -			J721E_IOPAD(0x1dc, PIN_OUTPUT, 7) /* (Y1) SPI1_CLK.GPIO0_118 */
> -		>;
> -	};
> -
>  	wkup_uart0_pins_default: wkup-uart0-default-pins {
>  		pinctrl-single,pins = <
>  			J721E_WKUP_IOPAD(0xa0, PIN_INPUT, 0) /* (J29) WKUP_UART0_RXD */

-- 
Regards
Vignesh
https://ti.com/opensource

Re: [PATCH] arm64: dts: ti: k3-j721e-sk: Fix pinmux for power regulator

Posted by Siddharth Vadapalli 1 week, 5 days ago

On Wed, 2025-11-19 at 13:38 +0530, Vignesh Raghavendra wrote:

Hello Vignesh,

> 
> On 18/11/25 17:19, Siddharth Vadapalli wrote:
> > Commit under Fixes added support for power regulators on the J721E SK
> 
> ^^^ not the right way to quote a commit. Should follow commit SHA

I started following this format after I noticed that an earlier patch of
mine at [0]
was merged to the Networking Tree with the commit message updated to follow
this format [1]. I acknowledge that the expected format might be different
across subsystems, but I used this format since it seemed concise to me and
I believe that it makes it easier for the reader.

However, if the format should be:
commit SHA ("$subject")
for the TI-K3-DTS Tree as a policy, I will fix the format and post the v2
patch.

[0]: https://lore.kernel.org/r/20241220075618.228202-1-s-vadapalli@ti.com/
[1]:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=4a4d38ace1fb

> ("$subject") format. Moreover this paragraph can be simply be stated as
> node is under wrong pmx region (wakeup) and instead should be moved to main

Please let me know if I should post a v2 for this or if you plan to correct
it locally
(in case the 'commit SHA ("$subject") format doesn't require a v2).

Regards,
Siddharth.

Re: [PATCH] arm64: dts: ti: k3-j721e-sk: Fix pinmux for power regulator

Posted by Vignesh Raghavendra 1 week, 5 days ago


On 19/11/25 14:13, Siddharth Vadapalli wrote:
> On Wed, 2025-11-19 at 13:38 +0530, Vignesh Raghavendra wrote:
> 
> Hello Vignesh,
> 
>>
>> On 18/11/25 17:19, Siddharth Vadapalli wrote:
>>> Commit under Fixes added support for power regulators on the J721E SK
>>
>> ^^^ not the right way to quote a commit. Should follow commit SHA
> 
> I started following this format after I noticed that an earlier patch of
> mine at [0]
> was merged to the Networking Tree with the commit message updated to follow
> this format [1]. I acknowledge that the expected format might be different
> across subsystems, but I used this format since it seemed concise to me and
> I believe that it makes it easier for the reader.
> 

Ok,  seems common in netdev but not outside of that tree.

> However, if the format should be:
> commit SHA ("$subject")
> for the TI-K3-DTS Tree as a policy, I will fix the format and post the v2
> patch.
> 
> [0]: https://lore.kernel.org/r/20241220075618.228202-1-s-vadapalli@ti.com/
> [1]:
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=4a4d38ace1fb
> 
>> ("$subject") format. Moreover this paragraph can be simply be stated as
>> node is under wrong pmx region (wakeup) and instead should be moved to main
> 
> Please let me know if I should post a v2 for this or if you plan to correct
> it locally
> (in case the 'commit SHA ("$subject") format doesn't require a v2).

There really is no need to quote the offending commit as part of the
text as Fixes Tag makes it obvious. You would just have to describe that
node is in the wrong parent node and needs to be moved under main pmx
node with appropriate reference to TRM/Doc

> 
> Regards,
> Siddharth.

-- 
Regards
Vignesh
https://ti.com/opensource

Re: [PATCH] arm64: dts: ti: k3-j721e-sk: Fix pinmux for power regulator

Posted by Siddharth Vadapalli 1 week, 5 days ago

On 19/11/25 7:57 PM, Vignesh Raghavendra wrote:
> 
> 
> On 19/11/25 14:13, Siddharth Vadapalli wrote:
>> On Wed, 2025-11-19 at 13:38 +0530, Vignesh Raghavendra wrote:
>>
>> Hello Vignesh,
>>
>>>
>>> On 18/11/25 17:19, Siddharth Vadapalli wrote:
>>>> Commit under Fixes added support for power regulators on the J721E SK
>>>
>>> ^^^ not the right way to quote a commit. Should follow commit SHA
>>
>> I started following this format after I noticed that an earlier patch of
>> mine at [0]
>> was merged to the Networking Tree with the commit message updated to follow
>> this format [1]. I acknowledge that the expected format might be different
>> across subsystems, but I used this format since it seemed concise to me and
>> I believe that it makes it easier for the reader.
>>
> 
> Ok,  seems common in netdev but not outside of that tree.
> 
>> However, if the format should be:
>> commit SHA ("$subject")
>> for the TI-K3-DTS Tree as a policy, I will fix the format and post the v2
>> patch.
>>
>> [0]: https://lore.kernel.org/r/20241220075618.228202-1-s-vadapalli@ti.com/
>> [1]:
>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=4a4d38ace1fb
>>
>>> ("$subject") format. Moreover this paragraph can be simply be stated as
>>> node is under wrong pmx region (wakeup) and instead should be moved to main
>>
>> Please let me know if I should post a v2 for this or if you plan to correct
>> it locally
>> (in case the 'commit SHA ("$subject") format doesn't require a v2).
> 
> There really is no need to quote the offending commit as part of the
> text as Fixes Tag makes it obvious. You would just have to describe that
> node is in the wrong parent node and needs to be moved under main pmx
> node with appropriate reference to TRM/Doc

Thank you for the clarification. I will keep the commit message concise 
and post the v2 patch.

Regards,
Siddharth.

Re: [PATCH] arm64: dts: ti: k3-j721e-sk: Fix pinmux for power regulator

Posted by Yemike Abhilash Chandra 1 week, 5 days ago

Hi Siddharth,
Thanks for the fix.

On 18/11/25 17:19, Siddharth Vadapalli wrote:
> Commit under Fixes added support for power regulators on the J721E SK
> board. However, while doing so, it incorrectly assigned a non-existent
> pinmux within the WKUP Pinmux region (pinctrl@4301c000) instead of using
> the MAIN Pinmux region (pinctrl@11c000). This leads to the following
> silent failure:
> 
>      pinctrl-single 4301c000.pinctrl: mux offset out of range: 0x1dc (0x178)
> 
> The datasheet for the J721E SoC [0] specifies on page 142 that the
> pinmux of interest which is Ball Y1 is PADCONFIG119 and the address
> corresponding to it is 0x00011C1DC which belongs to the MAIN Pinmux
> region.
> 
> Hence, fix this.
> 
> [0]: https://www.ti.com/lit/ds/symlink/tda4vm.pdf
> Fixes: 97b67cc102dc ("arm64: dts: ti: k3-j721e-sk: Add DT nodes for power regulators")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>

Reviewed-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>

Thanks and Regards
Yemike Abhilash Chandra

> ---
> 
> Hello,
> 
> This patch is based on commit
> e7c375b18160 Merge tag 'vfs-6.18-rc7.fixes' of gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs
> of Mainline Linux.
> 
> Regards,
> Siddharth.
> 
>   arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> index 5e5784ef6f85..77dcc160eda3 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> @@ -474,6 +474,12 @@ rpi_header_gpio1_pins_default: rpi-header-gpio1-default-pins {
>   			J721E_IOPAD(0x234, PIN_INPUT, 7) /* (U3) EXT_REFCLK1.GPIO1_12 */
>   		>;
>   	};
> +
> +	vdd_sd_dv_pins_default: vdd-sd-dv-default-pins {
> +		pinctrl-single,pins = <
> +			J721E_IOPAD(0x1dc, PIN_OUTPUT, 7) /* (Y1) SPI1_CLK.GPIO0_118 */
> +		>;
> +	};
>   };
>   
>   &wkup_pmx0 {
> @@ -536,12 +542,6 @@ J721E_WKUP_IOPAD(0xd4, PIN_OUTPUT, 7) /* (G26) WKUP_GPIO0_9 */
>   		>;
>   	};
>   
> -	vdd_sd_dv_pins_default: vdd-sd-dv-default-pins {
> -		pinctrl-single,pins = <
> -			J721E_IOPAD(0x1dc, PIN_OUTPUT, 7) /* (Y1) SPI1_CLK.GPIO0_118 */
> -		>;
> -	};
> -
>   	wkup_uart0_pins_default: wkup-uart0-default-pins {
>   		pinctrl-single,pins = <
>   			J721E_WKUP_IOPAD(0xa0, PIN_INPUT, 0) /* (J29) WKUP_UART0_RXD */