[PATCH v2 0/2] add WQ_UNBOUND to alloc_workqueue users

Marco Crivellari posted 2 patches 1 week, 6 days ago
drivers/net/wireless/realtek/rtlwifi/base.c | 2 +-
drivers/net/wireless/realtek/rtw88/usb.c    | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
[PATCH v2 0/2] add WQ_UNBOUND to alloc_workqueue users
Posted by Marco Crivellari 1 week, 6 days ago
Hi,

=== Current situation: problems ===

Let's consider a nohz_full system with isolated CPUs: wq_unbound_cpumask is
set to the housekeeping CPUs, for !WQ_UNBOUND the local CPU is selected.

This leads to different scenarios if a work item is scheduled on an
isolated CPU where "delay" value is 0 or greater then 0:
        schedule_delayed_work(, 0);

This will be handled by __queue_work() that will queue the work item on the
current local (isolated) CPU, while:

        schedule_delayed_work(, 1);

Will move the timer on an housekeeping CPU, and schedule the work there.

Currently if a user enqueue a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.

This lack of consistency cannot be addressed without refactoring the API.

=== Recent changes to the WQ API ===

The following, address the recent changes in the Workqueue API:

- commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
- commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

The old workqueues will be removed in a future release cycle.

=== Introduced Changes by this series ===

1) [P 1-2] add WQ_UNBOUND to alloc_workqueue()

	This explicitly adds WQ_UNBOUND because this workload has no benefit
	from being per-cpu.


Thanks!

---
Changes in v2:
- Switch from WQ_PERCPU to WQ_UNBOUND: this workload benefits from an
  unbound workqueue.

- Rebased on 6.18-rc6


Marco Crivellari (2):
  wifi: rtlwifi: add WQ_UNBOUND to alloc_workqueue users
  wifi: rtw88: add WQ_UNBOUND to alloc_workqueue users

 drivers/net/wireless/realtek/rtlwifi/base.c | 2 +-
 drivers/net/wireless/realtek/rtw88/usb.c    | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

-- 
2.51.1