[PATCH v7 1/2] dt-bindings: arm: aspeed: Add compatible for Facebook Anacapa BMC

Peter Shen posted 2 patches 1 week, 6 days ago
There is a newer version of this series
[PATCH v7 1/2] dt-bindings: arm: aspeed: Add compatible for Facebook Anacapa BMC
Posted by Peter Shen 1 week, 6 days ago
This patch adds the compatible string for the Facebook Anacapa BMC
which uses an Aspeed AST2600 SoC. This is required before adding
the board's device tree source file.

Signed-off-by: Peter Shen <sjg168@gmail.com>
---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
index aedefca7cf4a..bcb874ebd9d2 100644
--- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
+++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
@@ -80,6 +80,7 @@ properties:
               - aspeed,ast2600-evb
               - aspeed,ast2600-evb-a1
               - asus,x4tf-bmc
+              - facebook,anacapa-bmc
               - facebook,bletchley-bmc
               - facebook,catalina-bmc
               - facebook,clemente-bmc
-- 
2.34.1
Re: [PATCH v7 1/2] dt-bindings: arm: aspeed: Add compatible for Facebook Anacapa BMC
Posted by Krzysztof Kozlowski 1 week, 6 days ago
On 18/11/2025 05:10, Peter Shen wrote:
> This patch adds the compatible string for the Facebook Anacapa BMC
> which uses an Aspeed AST2600 SoC. This is required before adding
> the board's device tree source file.
> 
> Signed-off-by: Peter Shen <sjg168@gmail.com>
> ---
>  Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
>  1 file changed, 1 insertion(+)


So you just ignored everything I wrote? Long explanation and you just
don't care?

If so, then:

NAK,

Also, do not attach (thread) your patchsets to some other threads
(unrelated or older versions). This buries them deep in the mailbox and
might interfere with applying entire sets. See also:
https://elixir.bootlin.com/linux/v6.16-rc2/source/Documentation/process/submitting-patches.rst#L830

Best regards,
Krzysztof
Re: [PATCH v7 1/2] dt-bindings: arm: aspeed: Add compatible for Facebook Anacapa BMC
Posted by Peter Shen 1 week, 6 days ago
Hi Krzysztof,

Thanks for your detailed explanation. I apologize for ignoring it earlier.
I now understand the importance of Acked-by/Reviewed-by/Tested-by tags, and of
not attaching patchsets to unrelated threads.

I will follow the proper process from now on, and also fix my local b4
environment so that generating the correct trailers works smoothly.

Best regards,
Peter

Krzysztof Kozlowski <krzk@kernel.org> 於 2025年11月18日 週二 上午2:21寫道:
>
> On 18/11/2025 05:10, Peter Shen wrote:
> > This patch adds the compatible string for the Facebook Anacapa BMC
> > which uses an Aspeed AST2600 SoC. This is required before adding
> > the board's device tree source file.
> >
> > Signed-off-by: Peter Shen <sjg168@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
> >  1 file changed, 1 insertion(+)
>
>
> So you just ignored everything I wrote? Long explanation and you just
> don't care?
>
> If so, then:
>
> NAK,
>
> Also, do not attach (thread) your patchsets to some other threads
> (unrelated or older versions). This buries them deep in the mailbox and
> might interfere with applying entire sets. See also:
> https://elixir.bootlin.com/linux/v6.16-rc2/source/Documentation/process/submitting-patches.rst#L830
>
> Best regards,
> Krzysztof
Re: [PATCH v7 1/2] dt-bindings: arm: aspeed: Add compatible for Facebook Anacapa BMC
Posted by Andrew Jeffery 1 week ago
Hi Peter,

On Tue, 2025-11-18 at 03:11 -0500, Peter Shen wrote:
> Hi Krzysztof,
> 
> Thanks for your detailed explanation. I apologize for ignoring it earlier.
> I now understand the importance of Acked-by/Reviewed-by/Tested-by tags, and of
> not attaching patchsets to unrelated threads.
> 
> I will follow the proper process from now on, and also fix my local b4
> environment so that generating the correct trailers works smoothly.

Can you please apply Krzysztof's tag and resend the series as v8,
separated from the v6 and v7 combo thread?

Thanks,

Andrew