[PATCH] ovl: remove unneeded semicolon

Chen Ni posted 1 patch 1 week, 6 days ago
fs/overlayfs/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] ovl: remove unneeded semicolon
Posted by Chen Ni 1 week, 6 days ago
Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
semantic patch at scripts/coccinelle/misc/semicolon.cocci.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 fs/overlayfs/dir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c
index d21f81a524f6..7c2407b8c3a4 100644
--- a/fs/overlayfs/dir.c
+++ b/fs/overlayfs/dir.c
@@ -105,7 +105,7 @@ static struct dentry *ovl_whiteout(struct ovl_fs *ofs)
 			whiteout = dget(link);
 		end_creating(link);
 		if (!err)
-			return whiteout;;
+			return whiteout;
 
 		if (err != -EMLINK) {
 			pr_warn("Failed to link whiteout - disabling whiteout inode sharing(nlink=%u, err=%u)\n",
-- 
2.25.1
Re: [PATCH] ovl: remove unneeded semicolon
Posted by Amir Goldstein 1 week, 6 days ago
On Tue, Nov 18, 2025 at 3:48 AM Chen Ni <nichen@iscas.ac.cn> wrote:
>
> Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
> semantic patch at scripts/coccinelle/misc/semicolon.cocci.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  fs/overlayfs/dir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c
> index d21f81a524f6..7c2407b8c3a4 100644
> --- a/fs/overlayfs/dir.c
> +++ b/fs/overlayfs/dir.c
> @@ -105,7 +105,7 @@ static struct dentry *ovl_whiteout(struct ovl_fs *ofs)
>                         whiteout = dget(link);
>                 end_creating(link);
>                 if (!err)
> -                       return whiteout;;
> +                       return whiteout;
>
>                 if (err != -EMLINK) {
>                         pr_warn("Failed to link whiteout - disabling whiteout inode sharing(nlink=%u, err=%u)\n",
> --
> 2.25.1
>

Hi Chen,

Thank you for the report!

Which branch is this patch against? linux-next?

It fixes a typo that got in with this patch
https://lore.kernel.org/linux-fsdevel/20251113002050.676694-5-neilb@ownmail.net/

Currently staged on branch vfs-6.19.directory.locking in Christian's vfs tree.

Christian, do you want to squash this fix?

Thanks,
Amir.