media: mali-c55: Remove unneeded semicolon

[PATCH] media: mali-c55: Remove unneeded semicolon

Posted by Chen Ni 2 weeks ago

Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
semantic patch at scripts/coccinelle/misc/semicolon.cocci.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/media/platform/arm/mali-c55/mali-c55-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-core.c b/drivers/media/platform/arm/mali-c55/mali-c55-core.c
index 43b834459ccf..e4118e8e0faa 100644
--- a/drivers/media/platform/arm/mali-c55/mali-c55-core.c
+++ b/drivers/media/platform/arm/mali-c55/mali-c55-core.c
@@ -458,7 +458,7 @@ static int mali_c55_media_frameworks_init(struct mali_c55 *mali_c55)
 	if (ret) {
 		dev_err(mali_c55->dev, "failed to register V4L2 device\n");
 		goto err_unregister_media_device;
-	};
+	}
 
 	mali_c55->notifier.ops = &mali_c55_notifier_ops;
 	v4l2_async_nf_init(&mali_c55->notifier, &mali_c55->v4l2_dev);
-- 
2.25.1

Re: [PATCH] media: mali-c55: Remove unneeded semicolon

Posted by Dan Scally 1 week, 6 days ago

Hi Chen, thanks for the patch

On 18/11/2025 02:04, Chen Ni wrote:
> Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
> semantic patch at scripts/coccinelle/misc/semicolon.cocci.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---

Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>

>   drivers/media/platform/arm/mali-c55/mali-c55-core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-core.c b/drivers/media/platform/arm/mali-c55/mali-c55-core.c
> index 43b834459ccf..e4118e8e0faa 100644
> --- a/drivers/media/platform/arm/mali-c55/mali-c55-core.c
> +++ b/drivers/media/platform/arm/mali-c55/mali-c55-core.c
> @@ -458,7 +458,7 @@ static int mali_c55_media_frameworks_init(struct mali_c55 *mali_c55)
>   	if (ret) {
>   		dev_err(mali_c55->dev, "failed to register V4L2 device\n");
>   		goto err_unregister_media_device;
> -	};
> +	}
>   
>   	mali_c55->notifier.ops = &mali_c55_notifier_ops;
>   	v4l2_async_nf_init(&mali_c55->notifier, &mali_c55->v4l2_dev);

Re: [PATCH] media: mali-c55: Remove unneeded semicolon

Posted by Jacopo Mondi 1 week, 6 days ago

Hi Chen Ni

On Tue, Nov 18, 2025 at 10:04:30AM +0800, Chen Ni wrote:
> Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
> semantic patch at scripts/coccinelle/misc/semicolon.cocci.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Indeed, thanks for catching!

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

> ---
>  drivers/media/platform/arm/mali-c55/mali-c55-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-core.c b/drivers/media/platform/arm/mali-c55/mali-c55-core.c
> index 43b834459ccf..e4118e8e0faa 100644
> --- a/drivers/media/platform/arm/mali-c55/mali-c55-core.c
> +++ b/drivers/media/platform/arm/mali-c55/mali-c55-core.c
> @@ -458,7 +458,7 @@ static int mali_c55_media_frameworks_init(struct mali_c55 *mali_c55)
>  	if (ret) {
>  		dev_err(mali_c55->dev, "failed to register V4L2 device\n");
>  		goto err_unregister_media_device;
> -	};
> +	}
>
>  	mali_c55->notifier.ops = &mali_c55_notifier_ops;
>  	v4l2_async_nf_init(&mali_c55->notifier, &mali_c55->v4l2_dev);
> --
> 2.25.1
>
>