[PATCH 3/3] ARM: dts: aspeed: yosemite5: Rename sgpio P0_I3C_APML_ALERT_L

Kevin Tung posted 3 patches 2 months, 3 weeks ago
There is a newer version of this series
[PATCH 3/3] ARM: dts: aspeed: yosemite5: Rename sgpio P0_I3C_APML_ALERT_L
Posted by Kevin Tung 2 months, 3 weeks ago
Rename P0_I3C_APML_ALERT_L to FM_APML_CPU_ALERT_N for clarity.

Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
---
 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
index 45b8ac2e8c65a4f672e64571631b7f6944f26213..060757b7211a6da777c51d9f0c886796cf2450a4 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
@@ -964,7 +964,7 @@ &sgpiom0 {
 	"FAULT_P3V3_NIC_N","",
 	"FAULT_P12V_NIC_N","",
 	"FAULT_P12V_SCM_N","",
-	"P0_I3C_APML_ALERT_L","",
+	"FM_APML_CPU_ALERT_N","",
 	"ALERT_INLET_TEMP_N","",
 	"FM_CPU_PROCHOT_R_N","",
 	"FM_CPU_THERMTRIP_N","",

-- 
2.51.2
Re: [PATCH 3/3] ARM: dts: aspeed: yosemite5: Rename sgpio P0_I3C_APML_ALERT_L
Posted by Andrew Jeffery 2 months, 2 weeks ago
On Tue, 2025-11-18 at 18:53 +0800, Kevin Tung wrote:
> Rename P0_I3C_APML_ALERT_L to FM_APML_CPU_ALERT_N for clarity.

Are user space components looking for these names? Will updating the
devicetree break older applications? I'd like to see more discussion of
these problems in the commit message.

Cheers,

Andrew

> 
> Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
> ---
>  arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> index 45b8ac2e8c65a4f672e64571631b7f6944f26213..060757b7211a6da777c51d9f0c886796cf2450a4 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> @@ -964,7 +964,7 @@ &sgpiom0 {
>  	"FAULT_P3V3_NIC_N","",
>  	"FAULT_P12V_NIC_N","",
>  	"FAULT_P12V_SCM_N","",
> -	"P0_I3C_APML_ALERT_L","",
> +	"FM_APML_CPU_ALERT_N","",
>  	"ALERT_INLET_TEMP_N","",
>  	"FM_CPU_PROCHOT_R_N","",
>  	"FM_CPU_THERMTRIP_N","",
Re: [PATCH 3/3] ARM: dts: aspeed: yosemite5: Rename sgpio P0_I3C_APML_ALERT_L
Posted by Kevin Tung 1 month, 3 weeks ago
Hi Andrew,

I’ve sent v3 of this series to address these concerns.
The signal rename has been reverted to avoid breaking any existing
user space dependencies. In addition, a new patch has been added to
introduce additional SGPIO line names and a more detailed
discussion in the commit message.

BR,
Kevin

On Mon, Nov 24, 2025 at 12:44 PM Andrew Jeffery
<andrew@codeconstruct.com.au> wrote:
>
> On Tue, 2025-11-18 at 18:53 +0800, Kevin Tung wrote:
> > Rename P0_I3C_APML_ALERT_L to FM_APML_CPU_ALERT_N for clarity.
>
> Are user space components looking for these names? Will updating the
> devicetree break older applications? I'd like to see more discussion of
> these problems in the commit message.
>
> Cheers,
>
> Andrew
>
> >
> > Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
> > ---
> >  arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> > index 45b8ac2e8c65a4f672e64571631b7f6944f26213..060757b7211a6da777c51d9f0c886796cf2450a4 100644
> > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> > @@ -964,7 +964,7 @@ &sgpiom0 {
> >       "FAULT_P3V3_NIC_N","",
> >       "FAULT_P12V_NIC_N","",
> >       "FAULT_P12V_SCM_N","",
> > -     "P0_I3C_APML_ALERT_L","",
> > +     "FM_APML_CPU_ALERT_N","",
> >       "ALERT_INLET_TEMP_N","",
> >       "FM_CPU_PROCHOT_R_N","",
> >       "FM_CPU_THERMTRIP_N","",