[PATCH 2/3] ARM: dts: aspeed: yosemite5: Update sensor configuration

Kevin Tung posted 3 patches 1 week, 6 days ago
There is a newer version of this series
[PATCH 2/3] ARM: dts: aspeed: yosemite5: Update sensor configuration
Posted by Kevin Tung 1 week, 6 days ago
Remove sensors 10-0040 and 10-0045 to align with the latest
hardware design changes.

Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
---
 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
index 7991e9360847532cff9aad4ad4ed57d4c30668a0..45b8ac2e8c65a4f672e64571631b7f6944f26213 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
@@ -674,20 +674,6 @@ gpio-expander@22 {
 			"PWRGD_P3V3_AUX","ALERT_TEMP";
 	};
 
-	power-sensor@40 {
-		compatible = "ti,ina233";
-		reg = <0x40>;
-		shunt-resistor = <2000>;
-		ti,maximum-expected-current-microamp = <32768000>;
-	};
-
-	power-sensor@45 {
-		compatible = "ti,ina233";
-		reg = <0x45>;
-		shunt-resistor = <2000>;
-		ti,maximum-expected-current-microamp = <32768000>;
-	};
-
 	adc@48 {
 		compatible = "ti,ads7830";
 		reg = <0x48>;

-- 
2.51.2
Re: [PATCH 2/3] ARM: dts: aspeed: yosemite5: Update sensor configuration
Posted by Andrew Jeffery 1 week ago
On Tue, 2025-11-18 at 18:53 +0800, Kevin Tung wrote:
> Remove sensors 10-0040 and 10-0045 to align with the latest
> hardware design changes.

Can you please elaborate on this commit message? I'd like this
description to be much more specific about revisions of the hardware
design, and why you expect all instances of the previous design to
suddenly stop existing.

I can't imagine this is the only hardware change that occurred. What
other changes are lurking?

Andrew

> 
> Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
> ---
>  arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> index 7991e9360847532cff9aad4ad4ed57d4c30668a0..45b8ac2e8c65a4f672e64571631b7f6944f26213 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> @@ -674,20 +674,6 @@ gpio-expander@22 {
>  			"PWRGD_P3V3_AUX","ALERT_TEMP";
>  	};
>  
> -	power-sensor@40 {
> -		compatible = "ti,ina233";
> -		reg = <0x40>;
> -		shunt-resistor = <2000>;
> -		ti,maximum-expected-current-microamp = <32768000>;
> -	};
> -
> -	power-sensor@45 {
> -		compatible = "ti,ina233";
> -		reg = <0x45>;
> -		shunt-resistor = <2000>;
> -		ti,maximum-expected-current-microamp = <32768000>;
> -	};
> -
>  	adc@48 {
>  		compatible = "ti,ads7830";
>  		reg = <0x48>;