Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
which are SBCs based on the Rockchip 3566 SoC.
The "3S" version ("S" for "storage") just adds a 16 GB eMMC
and a "mask ROM" DIP switch to the "3" version.
[1] https://tinker-board.asus.com/series/tinker-board-3.html
[2] https://tinker-board.asus.com/series/tinker-board-3s.html
Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
---
Changes in V3:
- Remove this Acked-by as the binding code changed substantially:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 6aceaa8acbb2..800c11323a4f 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -86,6 +86,13 @@ properties:
- const: asus,rk3288-tinker-s
- const: rockchip,rk3288
+ - description: Asus Tinker Board 3/3S
+ items:
+ - enum:
+ - asus,rk3566-tinker-board-3
+ - asus,rk3566-tinker-board-3s
+ - const: rockchip,rk3566
+
- description: Beelink A1
items:
- const: azw,beelink-a1
--
2.43.0Hello Michael,
On Tuesday, November 18, 2025 16:56 CET, Michael Opdenacker <michael.opdenacker@rootcommit.com> wrote:
> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
> which are SBCs based on the Rockchip 3566 SoC.
>
> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
> and a "mask ROM" DIP switch to the "3" version.
>
> [1] https://tinker-board.asus.com/series/tinker-board-3.html
> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>
> ---
>
> Changes in V3:
>
> - Remove this Acked-by as the binding code changed substantially:
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 6aceaa8acbb2..800c11323a4f 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -86,6 +86,13 @@ properties:
> - const: asus,rk3288-tinker-s
> - const: rockchip,rk3288
>
> + - description: Asus Tinker Board 3/3S
> + items:
> + - enum:
> + - asus,rk3566-tinker-board-3
> + - asus,rk3566-tinker-board-3s
> + - const: rockchip,rk3566
> +
> - description: Beelink A1
> items:
> - const: azw,beelink-a1
Please see my delayed response in the v2. [1] I think that would be
a better approach.
[1] https://lore.kernel.org/linux-rockchip/3c96ee6b-dca7-1a0a-792b-f8c165ec997d@manjaro.org/
On 19/11/2025 08:00, Dragan Simic wrote:
> Hello Michael,
>
> On Tuesday, November 18, 2025 16:56 CET, Michael Opdenacker <michael.opdenacker@rootcommit.com> wrote:
>> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
>> which are SBCs based on the Rockchip 3566 SoC.
>>
>> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
>> and a "mask ROM" DIP switch to the "3" version.
>>
>> [1] https://tinker-board.asus.com/series/tinker-board-3.html
>> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>
>> ---
>>
>> Changes in V3:
>>
>> - Remove this Acked-by as the binding code changed substantially:
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> index 6aceaa8acbb2..800c11323a4f 100644
>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> @@ -86,6 +86,13 @@ properties:
>> - const: asus,rk3288-tinker-s
>> - const: rockchip,rk3288
>>
>> + - description: Asus Tinker Board 3/3S
>> + items:
>> + - enum:
>> + - asus,rk3566-tinker-board-3
>> + - asus,rk3566-tinker-board-3s
>> + - const: rockchip,rk3566
>> +
>> - description: Beelink A1
>> items:
>> - const: azw,beelink-a1
>
> Please see my delayed response in the v2. [1] I think that would be
> a better approach.
>
> [1] https://lore.kernel.org/linux-rockchip/3c96ee6b-dca7-1a0a-792b-f8c165ec997d@manjaro.org/
>
Your reviews are not helpful. You nitpick irrelevant things and propose
solutions which later reverse leading to wasted effort on contributors side.
Michael implemented what you asked here:
https://lore.kernel.org/linux-rockchip/e4cd11d0-463c-e707-5110-6b92899b1ba3@manjaro.org/
This patch implements exactly what you wanted. On v4 you will ask to
reverse back to v1?
Now you claim that you want back v2. Really, you are NOT HELPING. It is
clear you do not understand what you are proposing and this is not
helping ion the process. Please refrain from such confusing reviews.
Best regards,
Krzysztof
On Wednesday, November 19, 2025 08:09 CET, Krzysztof Kozlowski <krzk@kernel.org> wrote: > Now you claim that you want back v2. Really, you are NOT HELPING. It is > clear you do not understand what you are proposing and this is not > helping ion the process. Please refrain from such confusing reviews. > > Best regards, > Krzysztof Oh, i forgot to mention that it certainly may be that I don't know everything when it comes to DT bindings and definitions, but you also may not know how to handle communication with people in a polite and friendly way. Thus, I'd suggest that you replace "Best regards" in your signature with "No regards".
Hello Krzysztof,
On Wednesday, November 19, 2025 08:09 CET, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 19/11/2025 08:00, Dragan Simic wrote:
> > On Tuesday, November 18, 2025 16:56 CET, Michael Opdenacker <michael.opdenacker@rootcommit.com> wrote:
> >> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
> >> which are SBCs based on the Rockchip 3566 SoC.
> >>
> >> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
> >> and a "mask ROM" DIP switch to the "3" version.
> >>
> >> [1] https://tinker-board.asus.com/series/tinker-board-3.html
> >> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
> >>
> >> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> >>
> >> ---
> >>
> >> Changes in V3:
> >>
> >> - Remove this Acked-by as the binding code changed substantially:
> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> >> Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
> >> 1 file changed, 7 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> >> index 6aceaa8acbb2..800c11323a4f 100644
> >> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> >> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> >> @@ -86,6 +86,13 @@ properties:
> >> - const: asus,rk3288-tinker-s
> >> - const: rockchip,rk3288
> >>
> >> + - description: Asus Tinker Board 3/3S
> >> + items:
> >> + - enum:
> >> + - asus,rk3566-tinker-board-3
> >> + - asus,rk3566-tinker-board-3s
> >> + - const: rockchip,rk3566
> >> +
> >> - description: Beelink A1
> >> items:
> >> - const: azw,beelink-a1
> >
> > Please see my delayed response in the v2. [1] I think that would be
> > a better approach.
> >
> > [1] https://lore.kernel.org/linux-rockchip/3c96ee6b-dca7-1a0a-792b-f8c165ec997d@manjaro.org/
>
> Your reviews are not helpful. You nitpick irrelevant things and propose
> solutions which later reverse leading to wasted effort on contributors side.
>
> Michael implemented what you asked here:
>
> https://lore.kernel.org/linux-rockchip/e4cd11d0-463c-e707-5110-6b92899b1ba3@manjaro.org/
Not exactly, because I didn't ask for any compatibles to be removed
from the new board dts files.
In this case, we could also say that it was Michael's fault not to
give enough time for the reviewers to respond.
> This patch implements exactly what you wanted. On v4 you will ask to
> reverse back to v1?
No, I will not, and please note this version doesn't exactly implement
what I suggested, as already explained above.
> Now you claim that you want back v2. Really, you are NOT HELPING. It is
> clear you do not understand what you are proposing and this is not
> helping ion the process. Please refrain from such confusing reviews.
No, I'm not suggesting that the series goes back to v2, but Michael
failed to give me enough time to respond. If that were the case,
the v3 would've been in nicer shape, with, from my point of view, no
need for further adjustments.
On 11/19/25 08:23, Dragan Simic wrote: > No, I'm not suggesting that the series goes back to v2, but Michael > failed to give me enough time to respond. If that were the case, > the v3 would've been in nicer shape, with, from my point of view, no > need for further adjustments. I'm sorry if I caused trouble. I agree I didn't leave you much time to react to my reply to your review. What happens is that I'm new to this subsystem and I was feeling some pressure to avoid missing the launch window for 6.19, which I don't know exactly when it will be. Michael. -- Michael Opdenacker Root Commit Yocto Project and OpenEmbedded Training course - Learn by doing: https://rootcommit.com/training/yocto/
On 19/11/2025 08:23, Dragan Simic wrote:
> Hello Krzysztof,
>
> On Wednesday, November 19, 2025 08:09 CET, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On 19/11/2025 08:00, Dragan Simic wrote:
>>> On Tuesday, November 18, 2025 16:56 CET, Michael Opdenacker <michael.opdenacker@rootcommit.com> wrote:
>>>> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
>>>> which are SBCs based on the Rockchip 3566 SoC.
>>>>
>>>> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
>>>> and a "mask ROM" DIP switch to the "3" version.
>>>>
>>>> [1] https://tinker-board.asus.com/series/tinker-board-3.html
>>>> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
>>>>
>>>> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>>>
>>>> ---
>>>>
>>>> Changes in V3:
>>>>
>>>> - Remove this Acked-by as the binding code changed substantially:
>>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>> ---
>>>> Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
>>>> 1 file changed, 7 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
>>>> index 6aceaa8acbb2..800c11323a4f 100644
>>>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>>>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>>>> @@ -86,6 +86,13 @@ properties:
>>>> - const: asus,rk3288-tinker-s
>>>> - const: rockchip,rk3288
>>>>
>>>> + - description: Asus Tinker Board 3/3S
>>>> + items:
>>>> + - enum:
>>>> + - asus,rk3566-tinker-board-3
>>>> + - asus,rk3566-tinker-board-3s
>>>> + - const: rockchip,rk3566
>>>> +
>>>> - description: Beelink A1
>>>> items:
>>>> - const: azw,beelink-a1
>>>
>>> Please see my delayed response in the v2. [1] I think that would be
>>> a better approach.
>>>
>>> [1] https://lore.kernel.org/linux-rockchip/3c96ee6b-dca7-1a0a-792b-f8c165ec997d@manjaro.org/
>>
>> Your reviews are not helpful. You nitpick irrelevant things and propose
>> solutions which later reverse leading to wasted effort on contributors side.
>>
>> Michael implemented what you asked here:
>>
>> https://lore.kernel.org/linux-rockchip/e4cd11d0-463c-e707-5110-6b92899b1ba3@manjaro.org/
>
> Not exactly, because I didn't ask for any compatibles to be removed
> from the new board dts files.
Read your answer again. You wanted ENTIRE bindings, to be like this:
- description: Asus Tinker Board 3/3S
items:
- enum:
- asus,rk3566-tinker-board-3
- asus,rk3566-tinker-board-3s
- const: rockchip,rk3566
(skipping obvious indentation fixup)
There are exactly like this.
>
> In this case, we could also say that it was Michael's fault not to
> give enough time for the reviewers to respond.
Michael implemented EXACTLY what you asked. Now, you ask to change it to
what Michael did BEFORE.
Your reviews are completely irresponsible and incorrect.
Best regards,
Krzysztof
On Wednesday, November 19, 2025 08:31 CET, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 19/11/2025 08:23, Dragan Simic wrote:
> > On Wednesday, November 19, 2025 08:09 CET, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >> On 19/11/2025 08:00, Dragan Simic wrote:
> >>> On Tuesday, November 18, 2025 16:56 CET, Michael Opdenacker <michael.opdenacker@rootcommit.com> wrote:
> >>>> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
> >>>> which are SBCs based on the Rockchip 3566 SoC.
> >>>>
> >>>> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
> >>>> and a "mask ROM" DIP switch to the "3" version.
> >>>>
> >>>> [1] https://tinker-board.asus.com/series/tinker-board-3.html
> >>>> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
> >>>>
> >>>> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> >>>>
> >>>> ---
> >>>>
> >>>> Changes in V3:
> >>>>
> >>>> - Remove this Acked-by as the binding code changed substantially:
> >>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>>> ---
> >>>> Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
> >>>> 1 file changed, 7 insertions(+)
> >>>>
> >>>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> >>>> index 6aceaa8acbb2..800c11323a4f 100644
> >>>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> >>>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> >>>> @@ -86,6 +86,13 @@ properties:
> >>>> - const: asus,rk3288-tinker-s
> >>>> - const: rockchip,rk3288
> >>>>
> >>>> + - description: Asus Tinker Board 3/3S
> >>>> + items:
> >>>> + - enum:
> >>>> + - asus,rk3566-tinker-board-3
> >>>> + - asus,rk3566-tinker-board-3s
> >>>> + - const: rockchip,rk3566
> >>>> +
> >>>> - description: Beelink A1
> >>>> items:
> >>>> - const: azw,beelink-a1
> >>>
> >>> Please see my delayed response in the v2. [1] I think that would be
> >>> a better approach.
> >>>
> >>> [1] https://lore.kernel.org/linux-rockchip/3c96ee6b-dca7-1a0a-792b-f8c165ec997d@manjaro.org/
> >>
> >> Your reviews are not helpful. You nitpick irrelevant things and propose
> >> solutions which later reverse leading to wasted effort on contributors side.
> >>
> >> Michael implemented what you asked here:
> >>
> >> https://lore.kernel.org/linux-rockchip/e4cd11d0-463c-e707-5110-6b92899b1ba3@manjaro.org/
> >
> > Not exactly, because I didn't ask for any compatibles to be removed
> > from the new board dts files.
>
> Read your answer again. You wanted ENTIRE bindings, to be like this:
>
> - description: Asus Tinker Board 3/3S
> items:
> - enum:
> - asus,rk3566-tinker-board-3
> - asus,rk3566-tinker-board-3s
> - const: rockchip,rk3566
>
> (skipping obvious indentation fixup)
> There are exactly like this.
>
> >
> > In this case, we could also say that it was Michael's fault not to
> > give enough time for the reviewers to respond.
>
> Michael implemented EXACTLY what you asked. Now, you ask to change it to
> what Michael did BEFORE.
Not really, because it wasn't some kind of a request from my side,
but merely a suggestion that was intended to be discussed further
so the best possible solution is reached before v3 is submitted.
> Your reviews are completely irresponsible and incorrect.
Calling my reviews irresponsible hurts me a lot, really, but I'm
unfortunately already used to hear hurtful things from your side.
On 19/11/2025 08:40, Dragan Simic wrote:
> On Wednesday, November 19, 2025 08:31 CET, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On 19/11/2025 08:23, Dragan Simic wrote:
>>> On Wednesday, November 19, 2025 08:09 CET, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>> On 19/11/2025 08:00, Dragan Simic wrote:
>>>>> On Tuesday, November 18, 2025 16:56 CET, Michael Opdenacker <michael.opdenacker@rootcommit.com> wrote:
>>>>>> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
>>>>>> which are SBCs based on the Rockchip 3566 SoC.
>>>>>>
>>>>>> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
>>>>>> and a "mask ROM" DIP switch to the "3" version.
>>>>>>
>>>>>> [1] https://tinker-board.asus.com/series/tinker-board-3.html
>>>>>> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
>>>>>>
>>>>>> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>>>>>
>>>>>> ---
>>>>>>
>>>>>> Changes in V3:
>>>>>>
>>>>>> - Remove this Acked-by as the binding code changed substantially:
>>>>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>>> ---
>>>>>> Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
>>>>>> 1 file changed, 7 insertions(+)
>>>>>>
>>>>>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
>>>>>> index 6aceaa8acbb2..800c11323a4f 100644
>>>>>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>>>>>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>>>>>> @@ -86,6 +86,13 @@ properties:
>>>>>> - const: asus,rk3288-tinker-s
>>>>>> - const: rockchip,rk3288
>>>>>>
>>>>>> + - description: Asus Tinker Board 3/3S
>>>>>> + items:
>>>>>> + - enum:
>>>>>> + - asus,rk3566-tinker-board-3
>>>>>> + - asus,rk3566-tinker-board-3s
>>>>>> + - const: rockchip,rk3566
>>>>>> +
>>>>>> - description: Beelink A1
>>>>>> items:
>>>>>> - const: azw,beelink-a1
>>>>>
>>>>> Please see my delayed response in the v2. [1] I think that would be
>>>>> a better approach.
>>>>>
>>>>> [1] https://lore.kernel.org/linux-rockchip/3c96ee6b-dca7-1a0a-792b-f8c165ec997d@manjaro.org/
>>>>
>>>> Your reviews are not helpful. You nitpick irrelevant things and propose
>>>> solutions which later reverse leading to wasted effort on contributors side.
>>>>
>>>> Michael implemented what you asked here:
>>>>
>>>> https://lore.kernel.org/linux-rockchip/e4cd11d0-463c-e707-5110-6b92899b1ba3@manjaro.org/
>>>
>>> Not exactly, because I didn't ask for any compatibles to be removed
>>> from the new board dts files.
>>
>> Read your answer again. You wanted ENTIRE bindings, to be like this:
>>
>> - description: Asus Tinker Board 3/3S
>> items:
>> - enum:
>> - asus,rk3566-tinker-board-3
>> - asus,rk3566-tinker-board-3s
>> - const: rockchip,rk3566
>>
>> (skipping obvious indentation fixup)
>> There are exactly like this.
>>
>>>
>>> In this case, we could also say that it was Michael's fault not to
>>> give enough time for the reviewers to respond.
>>
>> Michael implemented EXACTLY what you asked. Now, you ask to change it to
>> what Michael did BEFORE.
>
> Not really, because it wasn't some kind of a request from my side,
> but merely a suggestion that was intended to be discussed further
> so the best possible solution is reached before v3 is submitted.
>
>> Your reviews are completely irresponsible and incorrect.
>
> Calling my reviews irresponsible hurts me a lot, really, but I'm
> unfortunately already used to hear hurtful things from your side.
You do not bear the cost of your reviews, so maybe that's why you think
nitpicking, poking around, pin pointing irrelevant things and adding 2
cents is okay, but that leads to additional effort on contributors and
reviewers. And not respecting total effort is irresponsible.
Best regards,
Krzysztof
On Wednesday, November 19, 2025 08:48 CET, Krzysztof Kozlowski <krzk@kernel.org> wrote: > On 19/11/2025 08:40, Dragan Simic wrote: > > On Wednesday, November 19, 2025 08:31 CET, Krzysztof Kozlowski <krzk@kernel.org> wrote: > >> On 19/11/2025 08:23, Dragan Simic wrote: > >>> On Wednesday, November 19, 2025 08:09 CET, Krzysztof Kozlowski <krzk@kernel.org> wrote: > >>>> Your reviews are not helpful. You nitpick irrelevant things and propose > >>>> solutions which later reverse leading to wasted effort on contributors side. > >>>> > >>>> Michael implemented what you asked here: > >>>> > >>>> https://lore.kernel.org/linux-rockchip/e4cd11d0-463c-e707-5110-6b92899b1ba3@manjaro.org/ > >>> > >>> Not exactly, because I didn't ask for any compatibles to be removed > >>> from the new board dts files. > >> > >> Read your answer again. You wanted ENTIRE bindings, to be like this: > >> > >> - description: Asus Tinker Board 3/3S > >> items: > >> - enum: > >> - asus,rk3566-tinker-board-3 > >> - asus,rk3566-tinker-board-3s > >> - const: rockchip,rk3566 > >> > >> (skipping obvious indentation fixup) > >> There are exactly like this. > >>> > >>> In this case, we could also say that it was Michael's fault not to > >>> give enough time for the reviewers to respond. > >> > >> Michael implemented EXACTLY what you asked. Now, you ask to change it to > >> what Michael did BEFORE. > > > > Not really, because it wasn't some kind of a request from my side, > > but merely a suggestion that was intended to be discussed further > > so the best possible solution is reached before v3 is submitted. > > > >> Your reviews are completely irresponsible and incorrect. > > > > Calling my reviews irresponsible hurts me a lot, really, but I'm > > unfortunately already used to hear hurtful things from your side. > > You do not bear the cost of your reviews, so maybe that's why you think > nitpicking, poking around, pin pointing irrelevant things and adding 2 > cents is okay, but that leads to additional effort on contributors and > reviewers. And not respecting total effort is irresponsible. Thank you very much for finding additional ways to hurt my feelings. However, please think about how your unfriendly approach may or may not contribute to the overall effort.
On 18/11/2025 16:56, Michael Opdenacker wrote:
> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
> which are SBCs based on the Rockchip 3566 SoC.
>
> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
> and a "mask ROM" DIP switch to the "3" version.
>
> [1] https://tinker-board.asus.com/series/tinker-board-3.html
> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>
> ---
>
> Changes in V3:
>
> - Remove this Acked-by as the binding code changed substantially:
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Above commit msg and DTS suggests they are pretty compatible with each
other, so I don't quite get why this changed. Your changelog says
"unexpectedly turns out to be compatible with 3 but not 3S.", but is
this real or are you just guessing? I think you were tricked to change
correct code into this.
Anyway, however odd this is, I don't care enough to stop this patchset, so:
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
Hi Krzysztof
Thanks for the new review!
On 11/18/25 17:31, Krzysztof Kozlowski wrote:
> On 18/11/2025 16:56, Michael Opdenacker wrote:
>> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
>> which are SBCs based on the Rockchip 3566 SoC.
>>
>> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
>> and a "mask ROM" DIP switch to the "3" version.
>>
>> [1] https://tinker-board.asus.com/series/tinker-board-3.html
>> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>
>> ---
>>
>> Changes in V3:
>>
>> - Remove this Acked-by as the binding code changed substantially:
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Above commit msg and DTS suggests they are pretty compatible with each
> other, so I don't quite get why this changed. Your changelog says
> "unexpectedly turns out to be compatible with 3 but not 3S.", but is
> this real or are you just guessing? I think you were tricked to change
> correct code into this.
I was just guessing. The likelihood that something working on 3 doesn't
work on 3s looks very small indeed, but I'm not the manufacturer to
completely rule this out.
>
> Anyway, however odd this is, I don't care enough to stop this patchset, so:
>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
Thanks again!
Cheers
Michael.
--
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/
© 2016 - 2025 Red Hat, Inc.