On Tue, Nov 18, 2025 at 12:30:38PM +0100, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
>
> The supported panel is LH546WF1-ED01, add compatible and adjust the
> struct name to reflect that.
>
> The standalone compatible lg,sw43408 will continue to work, even thou
> there are no users yet.
.. no users _left_ ?
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> drivers/gpu/drm/panel/panel-lg-sw43408.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-lg-sw43408.c b/drivers/gpu/drm/panel/panel-lg-sw43408.c
> index 46a56ea92ad9f..bd55f6d8f2771 100644
> --- a/drivers/gpu/drm/panel/panel-lg-sw43408.c
> +++ b/drivers/gpu/drm/panel/panel-lg-sw43408.c
> @@ -149,7 +149,7 @@ static int sw43408_prepare(struct drm_panel *panel)
> return ret;
> }
>
> -static const struct drm_display_mode sw43408_mode = {
> +static const struct drm_display_mode lh546wf1_ed01_mode = {
> .clock = (1080 + 20 + 32 + 20) * (2160 + 20 + 4 + 20) * 60 / 1000,
>
> .hdisplay = 1080,
> @@ -171,7 +171,7 @@ static const struct drm_display_mode sw43408_mode = {
> static int sw43408_get_modes(struct drm_panel *panel,
> struct drm_connector *connector)
> {
> - return drm_connector_helper_get_modes_fixed(connector, &sw43408_mode);
> + return drm_connector_helper_get_modes_fixed(connector, &lh546wf1_ed01_mode);
> }
>
> static int sw43408_backlight_update_status(struct backlight_device *bl)
> @@ -214,7 +214,9 @@ static const struct drm_panel_funcs sw43408_funcs = {
> };
>
> static const struct of_device_id sw43408_of_match[] = {
> + /* legacy */
Nit: I'd read this comment in a way that both entries are legacy. Would
it be possible to adjust this somehow (e.g. put legacy on the same line
or extend it, explaining that only lg,sw43408 is legacy).
> { .compatible = "lg,sw43408", },
> + { .compatible = "lg,sw43408-lh546wf1-ed01", },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, sw43408_of_match);
>
> --
> 2.51.0
>
>
--
With best wishes
Dmitry