[PATCH] scsi: qla4xxx: use time conversion macros

Shi Hao posted 1 patch 2 weeks ago
drivers/scsi/qla4xxx/ql4_nx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] scsi: qla4xxx: use time conversion macros
Posted by Shi Hao 2 weeks ago
Replace the raw use of 500 value in schedule_timeout()
function with msecs_to_jiffies() to ensure intended value
across different kernel configurations regardless of HZ
value.

Signed-off-by: Shi Hao <i.shihao.999@gmail.com>
---
 drivers/scsi/qla4xxx/ql4_nx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c
index da2fc66ffedd..b0a62aaa1cca 100644
--- a/drivers/scsi/qla4xxx/ql4_nx.c
+++ b/drivers/scsi/qla4xxx/ql4_nx.c
@@ -1552,7 +1552,7 @@ static int qla4_82xx_cmdpeg_ready(struct scsi_qla_host *ha, int pegtune_val)
 			    (val == PHAN_INITIALIZE_ACK))
 				return 0;
 			set_current_state(TASK_UNINTERRUPTIBLE);
-			schedule_timeout(500);
+			schedule_timeout(msecs_to_jiffies(500));

 		} while (--retries);

--
2.51.0
Re: [PATCH] scsi: qla4xxx: use time conversion macros
Posted by Martin K. Petersen 2 days, 5 hours ago
Shi,

> Replace the raw use of 500 value in schedule_timeout() function with
> msecs_to_jiffies() to ensure intended value across different kernel
> configurations regardless of HZ value.

Applied to 6.19/scsi-staging, thanks!

-- 
Martin K. Petersen