1. Patchew
  2. linux
  3. View series

[PATCH] platform/x86: acer-wmi: Ignore backlight event

Armin Wolf posted 1 patch 2 weeks ago 
drivers/platform/x86/acer-wmi.c | 4 ++++
1 file changed, 4 insertions(+)
[PATCH] platform/x86: acer-wmi: Ignore backlight event
Posted by Armin Wolf 2 weeks ago 
On the Acer Nitro AN515-58, the event 4 - 0 is send by the ACPI
firmware when the backlight up/down keys are pressed. Ignore this
event to avoid spamming the kernel log with error messages, as the
acpi-video driver already handles brightness up/down events.

Reported-by: Bugaddr <Bugaddr@protonmail.com>
Closes: https://bugaddr.tech/posts/2025-11-16-debugging-the-acer-nitro-5-an515-58-fn-f10-keyboard-backlight-bug-on-linux/#wmi-interface-issues
Tested-by: Reported-by: Bugaddr <Bugaddr@protonmail.com>
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
 drivers/platform/x86/acer-wmi.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 18cb18e98e5d..bf97381faf58 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -121,6 +121,7 @@ MODULE_ALIAS("wmi:676AA15E-6A47-4D9F-A2CC-1E6D18D14026");
 
 enum acer_wmi_event_ids {
 	WMID_HOTKEY_EVENT = 0x1,
+	WMID_BACKLIGHT_EVENT = 0x4,
 	WMID_ACCEL_OR_KBD_DOCK_EVENT = 0x5,
 	WMID_GAMING_TURBO_KEY_EVENT = 0x7,
 	WMID_AC_EVENT = 0x8,
@@ -2512,6 +2513,9 @@ static void acer_wmi_notify(union acpi_object *obj, void *context)
 			sparse_keymap_report_event(acer_wmi_input_dev, scancode, 1, true);
 		}
 		break;
+	case WMID_BACKLIGHT_EVENT:
+		/* Already handled by acpi-video */
+		break;
 	case WMID_ACCEL_OR_KBD_DOCK_EVENT:
 		acer_gsensor_event();
 		acer_kbd_dock_event(&return_value);
-- 
2.39.5
Re: [PATCH] platform/x86: acer-wmi: Ignore backlight event
Posted by Ilpo Järvinen 1 week, 6 days ago 
On Mon, 17 Nov 2025 16:59:38 +0100, Armin Wolf wrote:

> On the Acer Nitro AN515-58, the event 4 - 0 is send by the ACPI
> firmware when the backlight up/down keys are pressed. Ignore this
> event to avoid spamming the kernel log with error messages, as the
> acpi-video driver already handles brightness up/down events.
> 
> 


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: acer-wmi: Ignore backlight event
      commit: 444a9256f8d106e08a6bc2dc8ef28a8699e4b3ba

--
 i.
Re: [PATCH] platform/x86: acer-wmi: Ignore backlight event
Posted by Armin Wolf 1 week, 6 days ago 
Am 18.11.25 um 09:11 schrieb Ilpo Järvinen:

> On Mon, 17 Nov 2025 16:59:38 +0100, Armin Wolf wrote:
>
>> On the Acer Nitro AN515-58, the event 4 - 0 is send by the ACPI
>> firmware when the backlight up/down keys are pressed. Ignore this
>> event to avoid spamming the kernel log with error messages, as the
>> acpi-video driver already handles brightness up/down events.
>>
>>
>
> Thank you for your contribution, it has been applied to my local
> review-ilpo-fixes branch. Note it will show up in the public
> platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
> local branch there, which might take a while.

Thank you. I just noticed that i made a slight error inside the patch description:
Tested-by: Reported-by: Bugaddr<Bugaddr@protonmail.com>

Could you fix that up inside your branch?

Thank,
Armin Wolf

> The list of commits applied:
> [1/1] platform/x86: acer-wmi: Ignore backlight event
>        commit: 444a9256f8d106e08a6bc2dc8ef28a8699e4b3ba
>
> --
>   i.
>
>
Re: [PATCH] platform/x86: acer-wmi: Ignore backlight event
Posted by Ilpo Järvinen 1 week, 6 days ago 
On Tue, 18 Nov 2025, Armin Wolf wrote:

> Am 18.11.25 um 09:11 schrieb Ilpo Järvinen:
> 
> > On Mon, 17 Nov 2025 16:59:38 +0100, Armin Wolf wrote:
> > 
> > > On the Acer Nitro AN515-58, the event 4 - 0 is send by the ACPI
> > > firmware when the backlight up/down keys are pressed. Ignore this
> > > event to avoid spamming the kernel log with error messages, as the
> > > acpi-video driver already handles brightness up/down events.
> > > 
> > > 
> > 
> > Thank you for your contribution, it has been applied to my local
> > review-ilpo-fixes branch. Note it will show up in the public
> > platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
> > local branch there, which might take a while.
> 
> Thank you. I just noticed that i made a slight error inside the patch
> description:
> Tested-by: Reported-by: Bugaddr<Bugaddr@protonmail.com>
> 
> Could you fix that up inside your branch?

Hi,

Hmm, I didn't notice it myself but think b4 did change it as this is 
what I've in the commit 444a9256f8d106e08a6bc2dc8ef28a8699e4b3ba:

    Reported-by: Bugaddr <Bugaddr@protonmail.com>
    Closes: https://bugaddr.tech/posts/2025-11-16-debugging-the-acer-nitro-5-an515-58-fn-f10-keyboard-backlight-bug-on-linux/#wmi-interface-issues
    Tested-by: Bugaddr <Bugaddr@protonmail.com>
    Signed-off-by: Armin Wolf <W_Armin@gmx.de>
    Link: https://patch.msgid.link/20251117155938.3030-1-W_Armin@gmx.de
    Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
    Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

?

-- 
 i.
Re: [PATCH] platform/x86: acer-wmi: Ignore backlight event
Posted by Armin Wolf 1 week, 6 days ago 
Am 18.11.25 um 11:47 schrieb Ilpo Järvinen:

> On Tue, 18 Nov 2025, Armin Wolf wrote:
>
>> Am 18.11.25 um 09:11 schrieb Ilpo Järvinen:
>>
>>> On Mon, 17 Nov 2025 16:59:38 +0100, Armin Wolf wrote:
>>>
>>>> On the Acer Nitro AN515-58, the event 4 - 0 is send by the ACPI
>>>> firmware when the backlight up/down keys are pressed. Ignore this
>>>> event to avoid spamming the kernel log with error messages, as the
>>>> acpi-video driver already handles brightness up/down events.
>>>>
>>>>
>>> Thank you for your contribution, it has been applied to my local
>>> review-ilpo-fixes branch. Note it will show up in the public
>>> platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
>>> local branch there, which might take a while.
>> Thank you. I just noticed that i made a slight error inside the patch
>> description:
>> Tested-by: Reported-by: Bugaddr<Bugaddr@protonmail.com>
>>
>> Could you fix that up inside your branch?
> Hi,
>
> Hmm, I didn't notice it myself but think b4 did change it as this is
> what I've in the commit 444a9256f8d106e08a6bc2dc8ef28a8699e4b3ba:
>
>      Reported-by: Bugaddr <Bugaddr@protonmail.com>
>      Closes: https://bugaddr.tech/posts/2025-11-16-debugging-the-acer-nitro-5-an515-58-fn-f10-keyboard-backlight-bug-on-linux/#wmi-interface-issues
>      Tested-by: Bugaddr <Bugaddr@protonmail.com>
>      Signed-off-by: Armin Wolf <W_Armin@gmx.de>
>      Link: https://patch.msgid.link/20251117155938.3030-1-W_Armin@gmx.de
>      Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>      Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>
> ?

Strange, but the tags are indeed correct. In this case no further action seems to be necessary.

Thanks,
Armin Wolf

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.