[PATCH] block: rate-limit capacity change info log

Li Chen posted 1 patch 7 months, 1 week ago
block/genhd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] block: rate-limit capacity change info log
Posted by Li Chen 7 months, 1 week ago
From: Li Chen <chenl311@chinatelecom.cn>

loop devices under heavy stress-ng loop streessor can trigger many
capacity change events in a short time. Each event prints an info
message from set_capacity_and_notify(), flooding the console and
contributing to soft lockups on slow consoles.

Switch the printk in set_capacity_and_notify() to
pr_info_ratelimited() so frequent capacity changes do not spam
the log while still reporting occasional changes.

Cc: stable@vger.kernel.org
Signed-off-by: Li Chen <chenl311@chinatelecom.cn>
---
 block/genhd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/genhd.c b/block/genhd.c
index 9bbc38d12792..bd3a6841e5b5 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -90,7 +90,7 @@ bool set_capacity_and_notify(struct gendisk *disk, sector_t size)
 	    (disk->flags & GENHD_FL_HIDDEN))
 		return false;
 
-	pr_info("%s: detected capacity change from %lld to %lld\n",
+	pr_info_ratelimited("%s: detected capacity change from %lld to %lld\n",
 		disk->disk_name, capacity, size);
 
 	/*
-- 
2.51.0
Re: [PATCH] block: rate-limit capacity change info log
Posted by Jens Axboe 7 months, 1 week ago
On Mon, 17 Nov 2025 13:34:07 +0800, Li Chen wrote:
> loop devices under heavy stress-ng loop streessor can trigger many
> capacity change events in a short time. Each event prints an info
> message from set_capacity_and_notify(), flooding the console and
> contributing to soft lockups on slow consoles.
> 
> Switch the printk in set_capacity_and_notify() to
> pr_info_ratelimited() so frequent capacity changes do not spam
> the log while still reporting occasional changes.
> 
> [...]

Applied, thanks!

[1/1] block: rate-limit capacity change info log
      commit: 3179a5f7f86bcc3acd5d6fb2a29f891ef5615852

Best regards,
-- 
Jens Axboe
Re: [PATCH] block: rate-limit capacity change info log
Posted by Chaitanya Kulkarni 7 months, 1 week ago
On 11/16/25 21:34, Li Chen wrote:
> From: Li Chen<chenl311@chinatelecom.cn>
>
> loop devices under heavy stress-ng loop streessor can trigger many
> capacity change events in a short time. Each event prints an info
> message from set_capacity_and_notify(), flooding the console and
> contributing to soft lockups on slow consoles.
>
> Switch the printk in set_capacity_and_notify() to
> pr_info_ratelimited() so frequent capacity changes do not spam
> the log while still reporting occasional changes.
>
> Cc:stable@vger.kernel.org
> Signed-off-by: Li Chen<chenl311@chinatelecom.cn>



Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck
Re: [PATCH] block: rate-limit capacity change info log
Posted by Bart Van Assche 7 months, 1 week ago
On 11/16/25 9:34 PM, Li Chen wrote:
> From: Li Chen <chenl311@chinatelecom.cn>
> 
> loop devices under heavy stress-ng loop streessor can trigger many
> capacity change events in a short time. Each event prints an info
> message from set_capacity_and_notify(), flooding the console and
> contributing to soft lockups on slow consoles.
> 
> Switch the printk in set_capacity_and_notify() to
> pr_info_ratelimited() so frequent capacity changes do not spam
> the log while still reporting occasional changes.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Li Chen <chenl311@chinatelecom.cn>
> ---
>   block/genhd.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/genhd.c b/block/genhd.c
> index 9bbc38d12792..bd3a6841e5b5 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -90,7 +90,7 @@ bool set_capacity_and_notify(struct gendisk *disk, sector_t size)
>   	    (disk->flags & GENHD_FL_HIDDEN))
>   		return false;
>   
> -	pr_info("%s: detected capacity change from %lld to %lld\n",
> +	pr_info_ratelimited("%s: detected capacity change from %lld to %lld\n",
>   		disk->disk_name, capacity, size);
>   
>   	/*

Reviewed-by: Bart Van Assche <bvanassche@acm.org>