On Mon, Nov 17, 2025 at 01:58:13PM -0500, Frank Li wrote:
> Use devm_pm_runtime_enable() to simplify code. Change to use
> dev_err_probe() because previous goto change to return.
>
> No functional change.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 16 +++++++---------
> 1 file changed, 7 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> index c3d411ddf492eb27b372763ce5d344a90c6ec524..a884976ac8f8295120c404941f7ee19b90723924 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> @@ -499,13 +499,14 @@ static int mxc_isi_probe(struct platform_device *pdev)
> dma_size = isi->pdata->has_36bit_dma ? 36 : 32;
> dma_set_mask_and_coherent(dev, DMA_BIT_MASK(dma_size));
>
> - pm_runtime_enable(dev);
> + ret = devm_pm_runtime_enable(dev);
> + if (ret)
> + return ret;
>
> ret = mxc_isi_crossbar_init(isi);
> - if (ret) {
> - dev_err(dev, "Failed to initialize crossbar: %d\n", ret);
> - goto err_pm;
> - }
> + if (ret)
> + return dev_err_probe(dev, ret,
> + "Failed to initialize crossbar: %d\n", ret);
No need to print the error value anymore.
>
> for (i = 0; i < isi->pdata->num_channels; ++i) {
> ret = mxc_isi_pipe_init(isi, i);
> @@ -528,8 +529,7 @@ static int mxc_isi_probe(struct platform_device *pdev)
>
> err_xbar:
> mxc_isi_crossbar_cleanup(&isi->crossbar);
> -err_pm:
> - pm_runtime_disable(isi->dev);
> +
> return ret;
> }
>
> @@ -548,8 +548,6 @@ static void mxc_isi_remove(struct platform_device *pdev)
>
> mxc_isi_crossbar_cleanup(&isi->crossbar);
> mxc_isi_v4l2_cleanup(isi);
> -
> - pm_runtime_disable(isi->dev);
> }
>
> static const struct of_device_id mxc_isi_of_match[] = {
>
> --
> 2.34.1
>
--
Regards,
Laurent Pinchart