The sun4i TCON needs a reference to the D-PHY in order to support LVDS
on Allwinner D1s/T113.

Add phys and phy-names to DT bindings.

Signed-off-by: Kuba Szczodrzyński <kuba@szczodrzynski.pl>
---
 .../bindings/display/allwinner,sun4i-a10-tcon.yaml          | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
index 724d93b91..52589341f 100644
--- a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
+++ b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
@@ -115,6 +115,12 @@ properties:
           - const: edp
           - const: lvds
 
+  phys:
+    maxItems: 1
+
+  phy-names:
+    const: combo-phy
+
   ports:
     $ref: /schemas/graph.yaml#/properties/ports
 
-- 
2.25.1

On Sun, Nov 16, 2025 at 02:49:43PM +0100, Kuba Szczodrzyński wrote:
> The sun4i TCON needs a reference to the D-PHY in order to support LVDS
> on Allwinner D1s/T113.
> 
> Add phys and phy-names to DT bindings.

Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets. See also:
https://elixir.bootlin.com/linux/v6.16-rc2/source/Documentation/process/submitting-patches.rst#L830


> 
> Signed-off-by: Kuba Szczodrzyński <kuba@szczodrzynski.pl>
> ---
>  .../bindings/display/allwinner,sun4i-a10-tcon.yaml          | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
> index 724d93b91..52589341f 100644
> --- a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
> +++ b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
> @@ -115,6 +115,12 @@ properties:
>            - const: edp
>            - const: lvds
>  
> +  phys:
> +    maxItems: 1
> +
> +  phy-names:
> +    const: combo-phy

Drop phy suffix. Can a "phy" property hold reference to something else
than phy? You don't need names in the first place, you have only one
entry.

Best regards,
Krzysztof

W dniu 2025-11-17 o 08:05:33, Krzysztof Kozlowski pisze:

> On Sun, Nov 16, 2025 at 02:49:43PM +0100, Kuba Szczodrzyński wrote:
>> The sun4i TCON needs a reference to the D-PHY in order to support LVDS
>> on Allwinner D1s/T113.
>>
>> Add phys and phy-names to DT bindings.
> Do not attach (thread) your patchsets to some other threads (unrelated
> or older versions). This buries them deep in the mailbox and might
> interfere with applying entire sets. See also:
> https://elixir.bootlin.com/linux/v6.16-rc2/source/Documentation/process/submitting-patches.rst#L830

I'll resend v4 as a new patchset.

>
>> Signed-off-by: Kuba Szczodrzyński <kuba@szczodrzynski.pl>
>> ---
>>   .../bindings/display/allwinner,sun4i-a10-tcon.yaml          | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
>> index 724d93b91..52589341f 100644
>> --- a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
>> +++ b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml
>> @@ -115,6 +115,12 @@ properties:
>>             - const: edp
>>             - const: lvds
>>   
>> +  phys:
>> +    maxItems: 1
>> +
>> +  phy-names:
>> +    const: combo-phy
> Drop phy suffix. Can a "phy" property hold reference to something else
> than phy?

Will do.

> You don't need names in the first place, you have only one
> entry.

However, phy-names was added because of how other bindings are made, such as "allwinner,sun4i-a10-musb" (single phy entry with const name).

So I think it makes sense to keep it, in line with other drivers.

Regards
Kuba

>
> Best regards,
> Krzysztof
>

On 17/11/2025 12:08, Kuba Szczodrzyński wrote:
> Will do.
> 
>> You don't need names in the first place, you have only one
>> entry.
> 
> However, phy-names was added because of how other bindings are made, such as "allwinner,sun4i-a10-musb" (single phy entry with const name).


It looks like USB binding, not a display one, so not really applicable
argument. Do existing display drivers using this binding rely on names
of phy or not?

Best regards,
Krzysztof

W dniu 2025-11-17 o 12:53:41, Krzysztof Kozlowski pisze:

> On 17/11/2025 12:08, Kuba Szczodrzyński wrote:
>> Will do.
>>
>>> You don't need names in the first place, you have only one
>>> entry.
>> However, phy-names was added because of how other bindings are made, such as "allwinner,sun4i-a10-musb" (single phy entry with const name).
>
> It looks like USB binding, not a display one, so not really applicable
> argument. Do existing display drivers using this binding rely on names
> of phy or not?

Actually, existing display bindings that use PHY rely on their names.
See: allwinner,sun6i-a31-mipi-dsi, allwinner,sun8i-a83t-dw-hdmi, as well as some bindings for different SoCs.

> Best regards,
> Krzysztof