usb: dwc3: core: Remove redundant comment in core init

[PATCH] usb: dwc3: core: Remove redundant comment in core init

Posted by Krishna Kurapati 2 months, 3 weeks ago

Remove redundant comment which was put in to address LLUCTL register
modifications for all applicable ports of multiport controller. Although
the support was added, the todo comment wasn't removed then.

Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
 drivers/usb/dwc3/core.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 96f85eada047..fbedf46d7468 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -1484,10 +1484,6 @@ int dwc3_core_init(struct dwc3 *dwc)
 
 	dwc3_config_threshold(dwc);
 
-	/*
-	 * Modify this for all supported Super Speed ports when
-	 * multiport support is added.
-	 */
 	if (hw_mode != DWC3_GHWPARAMS0_MODE_GADGET &&
 	    (DWC3_IP_IS(DWC31)) &&
 	    dwc->maximum_speed == USB_SPEED_SUPER) {
-- 
2.34.1

Re: [PATCH] usb: dwc3: core: Remove redundant comment in core init

Posted by Thinh Nguyen 2 months, 2 weeks ago

On Sun, Nov 16, 2025, Krishna Kurapati wrote:
> Remove redundant comment which was put in to address LLUCTL register
> modifications for all applicable ports of multiport controller. Although
> the support was added, the todo comment wasn't removed then.
> 
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
>  drivers/usb/dwc3/core.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 96f85eada047..fbedf46d7468 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -1484,10 +1484,6 @@ int dwc3_core_init(struct dwc3 *dwc)
>  
>  	dwc3_config_threshold(dwc);
>  
> -	/*
> -	 * Modify this for all supported Super Speed ports when
> -	 * multiport support is added.
> -	 */
>  	if (hw_mode != DWC3_GHWPARAMS0_MODE_GADGET &&
>  	    (DWC3_IP_IS(DWC31)) &&
>  	    dwc->maximum_speed == USB_SPEED_SUPER) {
> -- 
> 2.34.1
> 

Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>

BR,
Thinh